Skip to content

Commit 9953977

Browse files
committed
Using OSPrivacyConsentController
also cleans up a few TODO comments
1 parent ef0da64 commit 9953977

File tree

5 files changed

+65
-88
lines changed

5 files changed

+65
-88
lines changed

iOS_SDK/OneSignalSDK/OneSignalCore/Source/API/OneSignalClient.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#import "OneSignalCommonDefines.h"
3131
#import "OneSignalLog.h"
3232
#import "OneSignalCoreHelper.h"
33+
#import "OSPrivacyConsentController.h"
3334

3435
@interface OneSignalClient ()
3536
@property (strong, nonatomic) NSURLSession *sharedSession;
@@ -183,8 +184,7 @@ - (void)executeSimultaneousRequests:(NSDictionary<NSString *, OneSignalRequest *
183184
}
184185

185186
- (void)executeRequest:(OneSignalRequest *)request onSuccess:(OSResultSuccessBlock)successBlock onFailure:(OSFailureBlock)failureBlock {
186-
// ECM TODO: We need to handle privacy consent
187-
if (request.method != GET) { //&& [OneSignal shouldLogMissingPrivacyConsentErrorWithMethodName:nil]) {
187+
if (request.method != GET && [OSPrivacyConsentController shouldLogMissingPrivacyConsentErrorWithMethodName:nil]) {
188188
if (failureBlock) {
189189
failureBlock([self privacyConsentErrorWithRequestType:NSStringFromClass(request.class)]);
190190
}

0 commit comments

Comments
 (0)