fix permission observer that was accessing a nil observer

nan-li · nan-li · commit bd5dfa72fb02 · 2023-01-23T23:58:20.000-08:00
* Needs to use `self.permissionStateChangesObserver` instead of `_permissionStateChangesObserver`
diff --git a/iOS_SDK/OneSignalSDK/OneSignalNotifications/OSNotificationsManager.m b/iOS_SDK/OneSignalSDK/OneSignalNotifications/OSNotificationsManager.m
@@ -423,14 +423,14 @@ + (void)setSubscriptionErrorStatus:(int)errorType {
 
 // onOSPermissionChanged should only fire if something changed.
 + (void)addPermissionObserver:(NSObject<OSPermissionObserver>*)observer {
-    [_permissionStateChangesObserver addObserver:observer];
+    [self.permissionStateChangesObserver addObserver:observer];
     
     if ([self.currentPermissionState compare:self.lastPermissionState])
         [OSPermissionChangedInternalObserver fireChangesObserver:self.currentPermissionState];
 }
 
 + (void)removePermissionObserver:(NSObject<OSPermissionObserver>*)observer {
-    [_permissionStateChangesObserver removeObserver:observer];
+    [self.permissionStateChangesObserver removeObserver:observer];
 }
 
 //    User just responed to the iOS native notification permission prompt.

Original file line number	Diff line number	Diff line change
`@@ -423,14 +423,14 @@ + (void)setSubscriptionErrorStatus:(int)errorType {`
`423`	`423`
`424`	`424`	`// onOSPermissionChanged should only fire if something changed.`
`425`	`425`	`+ (void)addPermissionObserver:(NSObject<OSPermissionObserver>*)observer {`
`426`		`- [_permissionStateChangesObserver addObserver:observer];`
	`426`	`+ [self.permissionStateChangesObserver addObserver:observer];`
`427`	`427`
`428`	`428`	`if ([self.currentPermissionState compare:self.lastPermissionState])`
`429`	`429`	`[OSPermissionChangedInternalObserver fireChangesObserver:self.currentPermissionState];`
`430`	`430`	`}`
`431`	`431`
`432`	`432`	`+ (void)removePermissionObserver:(NSObject<OSPermissionObserver>*)observer {`
`433`		`- [_permissionStateChangesObserver removeObserver:observer];`
	`433`	`+ [self.permissionStateChangesObserver removeObserver:observer];`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`// User just responed to the iOS native notification permission prompt.`