Merge pull request #1068 from OneSignal/fix/more_detailed_error_logs

Log entire `NSError` instead of just `localizedDescription`

Author: nan-li

iOS_SDK/OneSignalSDK/Source/OSInAppMessageView.m

@@ -67,7 +67,7 @@ - (NSString *)getTagsString {
     NSString *jsonString;
     if (!jsonData) {
         [OneSignal onesignalLog:ONE_S_LL_ERROR message:
-         [NSString stringWithFormat:@"Error parsing tag dictionary to json :%@",error.localizedDescription]];
+         [NSString stringWithFormat:@"Error parsing tag dictionary to json: %@", error]];
     } else {
          jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
     }

iOS_SDK/OneSignalSDK/Source/OneSignal.m

@@ -1733,7 +1733,7 @@ + (void)trackColdRestart {
         [[OneSignalClient sharedClient] executeRequest:[OSRequestTrackV1 trackUsageData:osUsageData appId:appId] onSuccess:^(NSDictionary *result) {
             [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"trackColdRestart: successfully tracked cold restart"];
         } onFailure:^(NSError *error) {
-            [OneSignal onesignal_Log:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"trackColdRestart: Failed to track cold restart: %@", error.localizedDescription]];
+            [OneSignal onesignal_Log:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"trackColdRestart: Failed to track cold restart: %@", error]];
         }];
     }
 }

iOS_SDK/OneSignalSDK/Source/OneSignalHelper.m

@@ -104,7 +104,7 @@ -(void)URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dataT
     }
 
     if (fileHandleError != nil) {
-        [OneSignal onesignalLog:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"OneSignal Error encountered while downloading attachment: %@", fileHandleError.localizedDescription]];
+        [OneSignal onesignalLog:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"OneSignal Error encountered while downloading attachment: %@", fileHandleError]];
     }
 }
 

iOS_SDK/OneSignalSDK/Source/OneSignalNotificationServiceExtensionHandler.m

@@ -157,7 +157,7 @@ + (void)onNotificationReceived:(NSString *)receivedNotificationId withBlockingTa
                 dispatch_semaphore_signal(semaphore);
             }
         } failureBlock:^(NSError *error) {
-            [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"OneSignal onNotificationReceived sendReceiveReceipt Failed for playerId: %@ error:%@", playerId, error.localizedDescription]];
+            [OneSignal onesignal_Log:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"OneSignal onNotificationReceived sendReceiveReceipt Failed for playerId: %@ error: %@", playerId, error]];
             if (semaphore) {
                 dispatch_semaphore_signal(semaphore);
             }

iOS_SDK/OneSignalSDK/Source/OneSignalWebView.m

@@ -84,7 +84,7 @@ -(void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigati
 }
 
 -(void)webView:(WKWebView *)webView didFailNavigation:(WKNavigation *)navigation withError:(NSError *)error {
-    [OneSignal onesignal_Log:ONE_S_LL_ERROR message:error.localizedDescription];
+    [OneSignal onesignal_Log:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"webView: An error occurred during navigation: %@", error]];
 }
 
 - (void)pinSubviewToMarginsWithSubview:(UIView *)subview withSuperview:(UIView *)superview {