Skip to content

Commit c10545f

Browse files
committed
Fixing testGetDeviceVariant
1 parent 21d08e8 commit c10545f

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3096,19 +3096,20 @@ - (void)testHexStringFromDataWithInvalidValues {
30963096

30973097

30983098
- (void)testGetDeviceVariant {
3099-
// Simulator iPhone
31003099
var deviceModel = [OneSignalHelper getDeviceVariant];
3101-
XCTAssertEqualObjects(@"Simulator iPhone", deviceModel);
3102-
31033100
// Catalyst ("Mac")
3104-
[UIDeviceOverrider setSystemName:@"Mac OS X"];
3105-
deviceModel = [OneSignalHelper getDeviceVariant];
3106-
XCTAssertEqualObjects(@"Mac", deviceModel);
3107-
3108-
// Real iPhone
3109-
[OneSignalHelperOverrider setSystemInfoMachine:@"iPhone9,3"];
3110-
deviceModel = [OneSignalHelper getDeviceVariant];
3111-
XCTAssertEqualObjects(@"iPhone9,3", deviceModel);
3101+
#if TARGET_OS_MACCATALYST
3102+
XCTAssertEqualObjects(@"Mac", deviceModel);
3103+
#elif TARGET_OS_SIMULATOR
3104+
// Simulator iPhone
3105+
deviceModel = [OneSignalHelper getDeviceVariant];
3106+
XCTAssertEqualObjects(@"Simulator iPhone", deviceModel);
3107+
#else
3108+
// Real iPhone
3109+
[OneSignalHelperOverrider setSystemInfoMachine:@"iPhone9,3"];
3110+
deviceModel = [OneSignalHelper getDeviceVariant];
3111+
XCTAssertEqualObjects(@"iPhone9,3", deviceModel);
3112+
#endif
31123113
}
31133114

31143115
- (void)testDeviceStateJson {

0 commit comments

Comments
 (0)