Skip to content

Commit c5ca29e

Browse files
committed
Setting OneSignal.m to session manager delegate. Unittests.m passes
1 parent 3c9aa94 commit c5ca29e

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalAttachmentHandler.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@
1212
@interface OneSignalAttachmentHandler : NSObject
1313
+ (void)addAttachments:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
1414
+ (void)addActionButtons:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
15+
+ (UNNotificationAction *)createActionForButton:(NSDictionary *)button;
1516
@end
1617

iOS_SDK/OneSignalSDK/Source/OneSignal.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,6 +1796,7 @@ + (void)registerUserInternal {
17961796
return;
17971797

17981798
[_outcomeEventsController clearOutcomes];
1799+
[OSSessionManager sharedSessionManager].delegate = self;
17991800
[[OSSessionManager sharedSessionManager] restartSessionIfNeeded:_appEntryState];
18001801

18011802
[OneSignalTrackFirebaseAnalytics trackInfluenceOpenEvent];

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ @interface OneSignal (TestHelper)
8989
+ (DelayedConsentInitializationParameters *)delayedInitParameters;
9090
@end
9191

92-
@interface OneSignalHelper (TestHelper)
92+
@interface OneSignalAttachmentHandler (TestHelper)
9393
+ (NSString*)downloadMediaAndSaveInBundle:(NSString*)urlString;
9494
@end
9595

@@ -2037,7 +2037,7 @@ -(void)testDelayedSubscriptionUpdate {
20372037
- (void)testHandlingMediaUrlExtensions {
20382038
let testUrl = @"https://images.pexels.com/photos/104827/cat-pet-animal-domestic-104827.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=100";
20392039

2040-
let cacheName = [OneSignalHelper downloadMediaAndSaveInBundle:testUrl];
2040+
let cacheName = [OneSignalAttachmentHandler downloadMediaAndSaveInBundle:testUrl];
20412041

20422042
XCTAssertNotNil(cacheName);
20432043
}
@@ -3200,7 +3200,7 @@ - (void)testCreateActionForButtonsWithIcon {
32003200
}]
32013201
}};
32023202
OSNotification *notification = [OSNotification parseWithApns:aps];
3203-
UNNotificationAction *action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
3203+
UNNotificationAction *action = [OneSignalAttachmentHandler createActionForButton:notification.actionButtons[0]];
32043204
XCTAssertNotNil(action.icon);
32053205

32063206
aps = @{
@@ -3221,7 +3221,7 @@ - (void)testCreateActionForButtonsWithIcon {
32213221
}]
32223222
}};
32233223
notification = [OSNotification parseWithApns:aps];
3224-
action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
3224+
action = [OneSignalAttachmentHandler createActionForButton:notification.actionButtons[0]];
32253225
XCTAssertNotNil(action.icon);
32263226

32273227
aps = @{
@@ -3240,7 +3240,7 @@ - (void)testCreateActionForButtonsWithIcon {
32403240
}]
32413241
}};
32423242
notification = [OSNotification parseWithApns:aps];
3243-
action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
3243+
action = [OneSignalAttachmentHandler createActionForButton:notification.actionButtons[0]];
32443244
XCTAssertNil(action.icon);
32453245
}
32463246
}

0 commit comments

Comments
 (0)