Merge pull request #695 from OneSignal/fix/always_register_for_push_on_main_thread

emawby · web-flow · commit c99c12db9f78 · 2020-06-26T14:33:25.000-07:00
Always call registerForRemoteNotifications from the main thread
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m
@@ -955,7 +955,9 @@ + (BOOL)registerForAPNsToken {
     [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Firing registerForRemoteNotifications"];
     
     waitingForApnsResponse = true;
-    [[UIApplication sharedApplication] registerForRemoteNotifications];
+    [OneSignalHelper dispatch_async_on_main_queue:^{
+        [[UIApplication sharedApplication] registerForRemoteNotifications];
+    }];
     
     return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,9 @@ + (BOOL)registerForAPNsToken {`
`955`	`955`	`[OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Firing registerForRemoteNotifications"];`
`956`	`956`
`957`	`957`	`waitingForApnsResponse = true;`
`958`		`- [[UIApplication sharedApplication] registerForRemoteNotifications];`
	`958`	`+ [OneSignalHelper dispatch_async_on_main_queue:^{`
	`959`	`+ [[UIApplication sharedApplication] registerForRemoteNotifications];`
	`960`	`+ }];`
`959`	`961`
`960`	`962`	`return true;`
`961`	`963`	`}`