unit test for adding icon to notification action

Author: emawby

iOS_SDK/OneSignalSDK/UnitTests/Shadows/OneSignalHelperOverrider.h

@@ -28,6 +28,11 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
+#import "OneSignalHelper.h"
+
+@interface OneSignalHelper (Tests)
++ (UNNotificationAction *)createActionForButton:(NSDictionary *)button;
+@end
 
 @interface OneSignalHelperOverrider : NSObject
 + (void)reset;

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

@@ -3150,13 +3150,78 @@ - (void)testParseNotificationTemplateActionIconJson {
                                 @"i": @"id1",
                                 @"n": @"text1",
                                 @"path": @"myImage/thumbsup",
-                                @"icon_type": @"template"
+                                @"icon_type": @"custom"
                             }]
                         }};
     OSNotification *notification = [OSNotification parseWithApns:aps];
     XCTAssertEqualObjects(notification.actionButtons[0][@"templateIcon"], @"myImage/thumbsup");
 }
 
+- (void)testCreateActionForButtonsWithIcon {
+    if (@available(iOS 15.0, *)) {
+        NSDictionary *aps = @{
+                            @"aps": @{
+                                @"content-available": @1,
+                                @"mutable-content": @1,
+                                @"alert": @"Message Body",
+                            },
+                            @"os_data": @{
+                                @"i": @"notif id",
+                                @"ti": @"templateId123",
+                                @"tn": @"Template name",
+                                @"buttons": @[@{
+                                    @"i": @"id1",
+                                    @"n": @"text1",
+                                    @"path": @"myImage/thumbsup",
+                                    @"icon_type": @"custom"
+                                }]
+                            }};
+        OSNotification *notification = [OSNotification parseWithApns:aps];
+        UNNotificationAction *action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
+        XCTAssertNotNil(action.icon);
+        
+        aps = @{
+                @"aps": @{
+                    @"content-available": @1,
+                    @"mutable-content": @1,
+                    @"alert": @"Message Body",
+                },
+                @"os_data": @{
+                    @"i": @"notif id",
+                    @"ti": @"templateId123",
+                    @"tn": @"Template name",
+                    @"buttons": @[@{
+                        @"i": @"id1",
+                        @"n": @"text1",
+                        @"path": @"hand.thumbsup",
+                        @"icon_type": @"system"
+                    }]
+                }};
+        notification = [OSNotification parseWithApns:aps];
+        action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
+        XCTAssertNotNil(action.icon);
+        
+        aps = @{
+                @"aps": @{
+                    @"content-available": @1,
+                    @"mutable-content": @1,
+                    @"alert": @"Message Body",
+                },
+                @"os_data": @{
+                    @"i": @"notif id",
+                    @"ti": @"templateId123",
+                    @"tn": @"Template name",
+                    @"buttons": @[@{
+                        @"i": @"id1",
+                        @"n": @"text1"
+                    }]
+                }};
+        notification = [OSNotification parseWithApns:aps];
+        action = [OneSignalHelper createActionForButton:notification.actionButtons[0]];
+        XCTAssertNil(action.icon);
+    }
+}
+
 - (void)testNotificationJson {
     NSDictionary *aps = @{
                         @"aps": @{