Skip to content

Commit de9c0a4

Browse files
committed
Remove some warnings from code
1 parent e0470fb commit de9c0a4

11 files changed

+32
-24
lines changed

iOS_SDK/OneSignalSDK/Source/OSAttributedFocusTimeProcessor.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ - (void)beginDelayBackgroundTask {
5151

5252
- (void)endDelayBackgroundTask {
5353
[OneSignal onesignal_Log:ONE_S_LL_DEBUG
54-
message:[NSString stringWithFormat:@"OSAttributedFocusTimeProcessor:endDelayBackgroundTask:%d", delayBackgroundTask]];
54+
message:[NSString stringWithFormat:@"OSAttributedFocusTimeProcessor:endDelayBackgroundTask:%lu", (unsigned long)delayBackgroundTask]];
5555
[UIApplication.sharedApplication endBackgroundTask:delayBackgroundTask];
5656
delayBackgroundTask = UIBackgroundTaskInvalid;
5757
}

iOS_SDK/OneSignalSDK/Source/OSInAppMessageDisplayStats.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ + (instancetype)instanceWithJson:(NSDictionary * _Nonnull)json {
8888
return displayStats;
8989
}
9090

91+
+ (instancetype)instancePreviewFromPayload:(OSNotificationPayload *)payload {
92+
return [OSInAppMessageDisplayStats new];
93+
}
94+
9195
-(NSDictionary *)jsonRepresentation {
9296
let json = [NSMutableDictionary new];
9397

iOS_SDK/OneSignalSDK/Source/OSInAppMessageOutcome.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ + (instancetype)instanceWithJson:(NSDictionary *)json {
5353
outcome.weight = @0;
5454
}
5555
if ([json[@"unique"] isKindOfClass:[NSNumber class]]) {
56-
outcome.unique = json[@"unique"];
56+
outcome.unique = [json[@"unique"] boolValue];
5757
} else {
5858
outcome.unique = NO;
5959
}

iOS_SDK/OneSignalSDK/Source/OSIndirectInfluence.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
#import "OSJSONHandling.h"
2929

30-
@interface OSIndirectInfluence : NSObject <NSCoding, OSJSONDecodable, OSJSONEncodable>
30+
@interface OSIndirectInfluence : NSObject <NSCoding, OSJSONEncodable, OSJSONDecodable>
3131

3232
@property (nonatomic, readonly) NSString *channelIdTag;
3333
@property (nonatomic, readonly) NSString *influenceId;

iOS_SDK/OneSignalSDK/Source/OSIndirectInfluence.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ + (instancetype)instanceWithJson:(NSDictionary * _Nonnull)json {
7373
return indirectInfluence;
7474
}
7575

76+
+ (instancetype)instancePreviewFromPayload:(OSNotificationPayload *)payload {
77+
return [OSIndirectInfluence new];
78+
}
79+
7680
-(NSDictionary *)jsonRepresentation {
7781
let json = [NSMutableDictionary new];
7882

iOS_SDK/OneSignalSDK/Source/OSOutcomeEvent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#import "OSOutcomeEventParams.h"
3131
#import "OSJSONHandling.h"
3232

33-
@interface OSOutcomeEvent () <OSJSONDecodable>
33+
@interface OSOutcomeEvent () <OSJSONEncodable>
3434

3535
- (id _Nonnull)initWithSession:(Session)session
3636
notificationIds:(NSArray * _Nullable)notificationIds

iOS_SDK/OneSignalSDK/Source/OSOutcomeEventsCache.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ THE SOFTWARE.
3333
- (BOOL)isOutcomesV2ServiceEnabled;
3434
- (void)saveOutcomesV2ServiceEnabled:(BOOL)isEnabled;
3535

36-
- (NSSet *)getUnattributedUniqueOutcomeEventsSent;
37-
- (void)saveUnattributedUniqueOutcomeEventsSent:(NSSet *)unattributedUniqueOutcomeEventsSentSet;
36+
- (NSSet * _Nullable)getUnattributedUniqueOutcomeEventsSent;
37+
- (void)saveUnattributedUniqueOutcomeEventsSent:(NSSet * _Nullable)unattributedUniqueOutcomeEventsSentSet;
3838

39-
- (NSArray *)getAttributedUniqueOutcomeEventSent;
40-
- (void)saveAttributedUniqueOutcomeEventNotificationIds:(NSArray *)attributedUniqueOutcomeEventNotificationIdsSent;
39+
- (NSArray * _Nullable)getAttributedUniqueOutcomeEventSent;
40+
- (void)saveAttributedUniqueOutcomeEventNotificationIds:(NSArray * _Nullable)attributedUniqueOutcomeEventNotificationIdsSent;
4141

4242
@end
4343

iOS_SDK/OneSignalSDK/Source/OSOutcomeEventsFactory.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ THE SOFTWARE.
3333

3434
@interface OSOutcomeEventsFactory : NSObject
3535

36-
- (instancetype)initWithCache:(OSOutcomeEventsCache *)cache;
36+
- (id _Nonnull)initWithCache:(OSOutcomeEventsCache * _Nonnull)cache;
3737

38-
- (OSOutcomeEventsRepository *)repository;
38+
- (OSOutcomeEventsRepository * _Nonnull)repository;
3939

4040
@end
4141

iOS_SDK/OneSignalSDK/Source/OSOutcomeEventsRepository.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,18 @@ THE SOFTWARE.
3737

3838
@property (strong, nonatomic, readonly, nonnull) OSOutcomeEventsCache *outcomeEventsCache;
3939

40-
- (id)initWithCache:(OSOutcomeEventsCache *)outcomeEventsCache;
41-
- (void)requestMeasureOutcomeEventWithAppId:(NSString *)appId
42-
deviceType:(NSNumber *)deviceType
43-
event:(OSOutcomeEventParams *)event
44-
onSuccess:(OSResultSuccessBlock)successBlock
45-
onFailure:(OSFailureBlock)failureBlock;
46-
47-
- (NSSet *)getUnattributedUniqueOutcomeEventsSent;
48-
- (void)saveUnattributedUniqueOutcomeEventsSent:(NSSet *)unattributedUniqueOutcomeEventsSentSet;
49-
50-
- (NSArray *)getNotCachedUniqueInfluencesForOutcome:(NSString *)name influences:(NSArray<OSInfluence *> *)influences;
51-
- (void)saveUniqueOutcomeEventParams:(OSOutcomeEventParams *)eventParams;
40+
- (id _Nonnull)initWithCache:(OSOutcomeEventsCache * _Nonnull)outcomeEventsCache;
41+
- (void)requestMeasureOutcomeEventWithAppId:(NSString * _Nonnull)appId
42+
deviceType:(NSNumber * _Nonnull)deviceType
43+
event:(OSOutcomeEventParams * _Nonnull)event
44+
onSuccess:(OSResultSuccessBlock _Nonnull)successBlock
45+
onFailure:(OSFailureBlock _Nonnull)failureBlock;
46+
47+
- (NSSet * _Nullable)getUnattributedUniqueOutcomeEventsSent;
48+
- (void)saveUnattributedUniqueOutcomeEventsSent:(NSSet * _Nullable)unattributedUniqueOutcomeEventsSentSet;
49+
50+
- (NSArray * _Nonnull)getNotCachedUniqueInfluencesForOutcome:(NSString * _Nonnull)name influences:(NSArray<OSInfluence *> * _Nonnull)influences;
51+
- (void)saveUniqueOutcomeEventParams:(OSOutcomeEventParams * _Nonnull)eventParams;
5252

5353
@end
5454

iOS_SDK/OneSignalSDK/Source/OSTrackerFactory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ THE SOFTWARE.
3636

3737
@interface OSTrackerFactory : NSObject
3838

39-
- (id)initWithRepository:(OSInfluenceDataRepository *)dataRepository;
39+
- (id _Nonnull)initWithRepository:(OSInfluenceDataRepository * _Nonnull)dataRepository;
4040
- (void)saveInfluenceParams:(NSDictionary * _Nonnull)params;
4141
- (void)initFromCache;
4242
- (NSArray<OSInfluence *> * _Nonnull)influences;

0 commit comments

Comments
 (0)