Merge pull request #1086 from OneSignal/fix_location_crash

Fixing crash when attempting to get Location

Author: emawby

iOS_SDK/OneSignalSDK/Source/OneSignalLocation.m

@@ -154,7 +154,11 @@ + (void)onFocus:(BOOL)isActive {
         }
     } else {
         //Check if always granted
-        if ([[NSClassFromString(@"CLLocationManager") performSelector:@selector(authorizationStatus)] intValue] == kCLAuthorizationStatusAuthorizedAlways) {
+        #pragma clang diagnostic push
+        #pragma clang diagnostic ignored "-Wpointer-integer-compare"
+        #pragma clang diagnostic push
+        #pragma clang diagnostic ignored "-Wint-conversion"
+        if ([NSClassFromString(@"CLLocationManager") performSelector:@selector(authorizationStatus)] == kCLAuthorizationStatusAuthorizedAlways) {
             [OneSignalLocation beginTask];
             [requestLocationTimer invalidate];
             [self requestLocation];
@@ -186,7 +190,7 @@ + (void)sendAndClearLocationListener:(PromptActionResult)result {
 
 + (void)sendCurrentAuthStatusToListeners {
     id clLocationManagerClass = NSClassFromString(@"CLLocationManager");
-    CLAuthorizationStatus permissionStatus = [[clLocationManagerClass performSelector:@selector(authorizationStatus)] intValue];
+    CLAuthorizationStatus permissionStatus = [clLocationManagerClass performSelector:@selector(authorizationStatus)];
     if (permissionStatus == kCLAuthorizationStatusNotDetermined)
         return;
 
@@ -203,7 +207,7 @@ + (void)internalGetLocation:(bool)prompt fallbackToSettings:(BOOL)fallback {
     // If location permissions was not asked "started" will never be true
     if ([self started]) {
         // We evaluate the following cases after permissions were asked (denied or given)
-        CLAuthorizationStatus permissionStatus = [[clLocationManagerClass performSelector:@selector(authorizationStatus)] intValue];
+        CLAuthorizationStatus permissionStatus = [clLocationManagerClass performSelector:@selector(authorizationStatus)];
         BOOL showSettings = prompt && fallback && permissionStatus == kCLAuthorizationStatusDenied;
         [OneSignal onesignalLog:ONE_S_LL_DEBUG message:[NSString stringWithFormat:@"internalGetLocation called showSettings: %@", showSettings ? @"YES" : @"NO"]];
         // Fallback to settings alert view when the following condition are true:
@@ -224,7 +228,7 @@ + (void)internalGetLocation:(bool)prompt fallbackToSettings:(BOOL)fallback {
         return;
     }
 
-    CLAuthorizationStatus permissionStatus = [[clLocationManagerClass performSelector:@selector(authorizationStatus)] intValue];
+    CLAuthorizationStatus permissionStatus = [clLocationManagerClass performSelector:@selector(authorizationStatus)];
     // return if permission not determined and should not prompt
     if (permissionStatus == kCLAuthorizationStatusNotDetermined && !prompt) {
         [OneSignal onesignalLog:ONE_S_LL_DEBUG message:@"internalGetLocation kCLAuthorizationStatusNotDetermined."];