nit: Fix a string description to simplify tests

* Fix the string description of OSRequestCreateUser to be uniform

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalUser/Source/Requests/OSRequestCreateUser.swift

@@ -70,7 +70,7 @@ class OSRequestCreateUser: OneSignalRequest, OSUserRequest {
         self.identityModel = identityModel
         self.pushSubscriptionModel = pushSubscriptionModel
         self.originalPushToken = originalPushToken
-        self.stringDescription = "<OSRequestCreateUser with externalId: \(identityModel.externalId ?? "nil")>"
+        self.stringDescription = "<OSRequestCreateUser with external_id: \(identityModel.externalId ?? "nil")>"
         super.init()
 
         var params: [String: Any] = [:]
@@ -95,7 +95,7 @@ class OSRequestCreateUser: OneSignalRequest, OSUserRequest {
 
     init(aliasLabel: String, aliasId: String, identityModel: OSIdentityModel) {
         self.identityModel = identityModel
-        self.stringDescription = "<OSRequestCreateUser with alias \(aliasLabel): \(aliasId)>"
+        self.stringDescription = "<OSRequestCreateUser with \(aliasLabel): \(aliasId)>"
         super.init()
         self.parameters = [
             "identity": [aliasLabel: aliasId],
@@ -126,7 +126,7 @@ class OSRequestCreateUser: OneSignalRequest, OSUserRequest {
         self.identityModel = identityModel
         self.pushSubscriptionModel = coder.decodeObject(forKey: "pushSubscriptionModel") as? OSSubscriptionModel
         self.originalPushToken = coder.decodeObject(forKey: "originalPushToken") as? String
-        self.stringDescription = "<OSRequestCreateUser with externalId: \(identityModel.externalId ?? "nil")>"
+        self.stringDescription = "<OSRequestCreateUser with external_id: \(identityModel.externalId ?? "nil")>"
         super.init()
         self.parameters = parameters
         self.method = HTTPMethod(rawValue: rawMethod)

iOS_SDK/OneSignalSDK/OneSignalUserMocks/MockUserRequests.swift

@@ -80,7 +80,7 @@ extension MockUserRequests {
         let anonCreateResponse = testDefaultFullCreateUserResponse(onesignalId: anonUserOSID, externalId: nil, subscriptionId: testPushSubId)
 
         client.setMockResponseForRequest(
-            request: "<OSRequestCreateUser with externalId: nil>",
+            request: "<OSRequestCreateUser with external_id: nil>",
             response: anonCreateResponse)
     }
 
@@ -90,7 +90,7 @@ extension MockUserRequests {
         let userResponse = MockUserRequests.testIdentityPayload(onesignalId: osid, externalId: externalId)
 
         client.setMockResponseForRequest(
-            request: "<OSRequestCreateUser with externalId: \(externalId)>",
+            request: "<OSRequestCreateUser with external_id: \(externalId)>",
             response: userResponse
         )
         client.setMockResponseForRequest(
@@ -114,7 +114,7 @@ extension MockUserRequests {
             // 2. Set the response for the subsequent Create User request
             let userResponse = MockUserRequests.testIdentityPayload(onesignalId: osid, externalId: externalId)
             client.setMockResponseForRequest(
-                request: "<OSRequestCreateUser with externalId: \(externalId)>",
+                request: "<OSRequestCreateUser with external_id: \(externalId)>",
                 response: userResponse)
             // 3. Set the response for the subsequent Fetch User request
             client.setMockResponseForRequest(