Skip to content

Commit f479811

Browse files
committed
Fix failing unit test for Firebase influence open
Test was failing due to expecting to track the notification received event, since removed.
1 parent 0c1d008 commit f479811

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -920,16 +920,7 @@ - (void)testFirebaseAnalyticsInfluenceNotificationOpen {
920920
withMutableNotificationContent:nil];
921921
#pragma clang diagnostic pop
922922

923-
// Make sure we are tracking the notification received event to firebase.
924-
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 1);
925-
id received_event = @{
926-
@"os_notification_received": @{
927-
@"campaign": @"Template Name - 1117f966-d8cc-11e4-bed1-df8f05be55bb",
928-
@"medium": @"notification",
929-
@"notification_id": @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
930-
@"source": @"OneSignal"}
931-
};
932-
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[0], received_event);
923+
// Note: we are no longer logging the notification received event to Firebase for iOS.
933924

934925
// Trigger a new app session
935926
[UnitTestCommonMethods backgroundApp];
@@ -941,15 +932,15 @@ - (void)testFirebaseAnalyticsInfluenceNotificationOpen {
941932
// TODO: Test carry over causes this influence_open not to fire
942933
// Since we opened the app under 2 mintues after receiving a notification
943934
// an influence_open should be sent to firebase.
944-
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 2);
935+
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 1);
945936
id influence_open_event = @{
946937
@"os_notification_influence_open": @{
947938
@"campaign": @"Template Name - 1117f966-d8cc-11e4-bed1-df8f05be55bb",
948939
@"medium": @"notification",
949940
@"notification_id": @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
950941
@"source": @"OneSignal"}
951942
};
952-
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[1], influence_open_event);
943+
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[0], influence_open_event);
953944
}
954945

955946
- (void)testOSNotificationPayloadParsesTemplateFields {

0 commit comments

Comments
 (0)