Skip to content

Commit f76184b

Browse files
committed
removing deltaQueue isempty checks
1 parent ae9c4cd commit f76184b

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSOperationRepo.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,6 @@ public class OSOperationRepo: NSObject {
115115
}
116116
start()
117117
print("🔥 OSOperationRepo flushDeltaQueue with queue: \(deltaQueue)")
118-
if deltaQueue.isEmpty {
119-
return
120-
}
121118

122119
var index = 0
123120
for delta in deltaQueue {

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSIdentityOperationExecutor.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ class OSIdentityOperationExecutor: OSOperationExecutor {
5959
}
6060

6161
func processDeltaQueue() {
62-
if deltaQueue.isEmpty {
63-
return
64-
}
65-
6662
for delta in deltaQueue {
6763
guard let model = delta.model as? OSIdentityModel,
6864
let aliases = delta.value as? [String: String]

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSPropertyOperationExecutor.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ class OSPropertyOperationExecutor: OSOperationExecutor {
5959
}
6060

6161
func processDeltaQueue() {
62-
if deltaQueue.isEmpty {
63-
return
64-
}
65-
6662
for delta in deltaQueue {
6763
guard let model = delta.model as? OSPropertiesModel else {
6864
// Log error

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSSubscriptionOperationExecutor.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
5959
}
6060

6161
func processDeltaQueue() {
62-
if deltaQueue.isEmpty {
63-
return
64-
}
65-
6662
for delta in deltaQueue {
6763
guard let model = delta.model as? OSSubscriptionModel else {
6864
// Log error
@@ -171,6 +167,10 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
171167

172168
func executeUpdateSubscriptionRequest(_ request: OSRequestUpdateSubscription) {
173169
print("🔥 OSSubscriptionOperationExecutor: executeUpdateSubscriptionRequest making request: \(request)")
170+
171+
guard request.prepareForExecution() else {
172+
return
173+
}
174174
OneSignalClient.shared().execute(request) { result in
175175

176176
// On success, remove request from cache. No model hydration occurs.

0 commit comments

Comments
 (0)