Skip to content

Commit f828623

Browse files
committed
chore: code coverage, add all targets
* Add all frameworks to check code coverage for. * Reminder there are 2 test plans that can be run: - UnitTestApp_TestPlan_Reduced (default plan in CI) - UnitTestApp_TestPlan_Full (default plan in Xcode)
1 parent 47972a4 commit f828623

File tree

3 files changed

+86
-14
lines changed

3 files changed

+86
-14
lines changed

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@
9696
3C6299A92BEEA46C00649187 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 3C6299A82BEEA46C00649187 /* PrivacyInfo.xcprivacy */; };
9797
3C6299AB2BEEA4C000649187 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 3C6299AA2BEEA4C000649187 /* PrivacyInfo.xcprivacy */; };
9898
3C67F77A2BEB2B710085A0F0 /* SwitchUserIntegrationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3C67F7792BEB2B710085A0F0 /* SwitchUserIntegrationTests.swift */; };
99+
3C7021E32ECF0821001768C6 /* OneSignalFramework.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3E2400381D4FFC31008BDE70 /* OneSignalFramework.framework */; };
100+
3C7021E42ECF0821001768C6 /* OneSignalFramework.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 3E2400381D4FFC31008BDE70 /* OneSignalFramework.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
99101
3C70FA672D0B68A100031066 /* OneSignalClientError.h in Headers */ = {isa = PBXBuildFile; fileRef = 3C70FA652D0B68A100031066 /* OneSignalClientError.h */; settings = {ATTRIBUTES = (Public, ); }; };
100102
3C70FA682D0B68A100031066 /* OneSignalClientError.m in Sources */ = {isa = PBXBuildFile; fileRef = 3C70FA662D0B68A100031066 /* OneSignalClientError.m */; };
101103
3C789DBD293C2206004CF83D /* OSFocusInfluenceParam.m in Sources */ = {isa = PBXBuildFile; fileRef = 7A600B432453790700514A53 /* OSFocusInfluenceParam.m */; };
@@ -643,6 +645,13 @@
643645
remoteGlobalIDString = 3C115160289A259500565C41;
644646
remoteInfo = OneSignalOSCore;
645647
};
648+
3C7021E52ECF0821001768C6 /* PBXContainerItemProxy */ = {
649+
isa = PBXContainerItemProxy;
650+
containerPortal = 37747F8B19147D6400558FAD /* Project object */;
651+
proxyType = 1;
652+
remoteGlobalIDString = 3E2400371D4FFC31008BDE70;
653+
remoteInfo = OneSignalFramework;
654+
};
646655
3C7A39C32B7BED900082665E /* PBXContainerItemProxy */ = {
647656
isa = PBXContainerItemProxy;
648657
containerPortal = 37747F8B19147D6400558FAD /* Project object */;
@@ -1207,6 +1216,7 @@
12071216
DEBAAE2F2A4211DA00BF2C1C /* OneSignalInAppMessages.framework in Embed Frameworks */,
12081217
475F47252B8E398E00EC05B3 /* OneSignalLiveActivities.framework in Embed Frameworks */,
12091218
3C8544BD2C5AEFF700F542A9 /* OneSignalOSCoreMocks.framework in Embed Frameworks */,
1219+
3C7021E42ECF0821001768C6 /* OneSignalFramework.framework in Embed Frameworks */,
12101220
DEA4B4632888C4DC00E9FE12 /* OneSignalOutcomes.framework in Embed Frameworks */,
12111221
3CEE934B2B7C73B6008440BD /* OneSignalUserMocks.framework in Embed Frameworks */,
12121222
DEA4B45D2888C1D000E9FE12 /* OneSignalCore.framework in Embed Frameworks */,
@@ -1939,6 +1949,7 @@
19391949
isa = PBXFrameworksBuildPhase;
19401950
buildActionMask = 2147483647;
19411951
files = (
1952+
3C7021E32ECF0821001768C6 /* OneSignalFramework.framework in Frameworks */,
19421953
3C11518E289AF83600565C41 /* OneSignalOSCore.framework in Frameworks */,
19431954
DE3784852888D00300453A8E /* OneSignalUser.framework in Frameworks */,
19441955
DEBAAE2E2A4211DA00BF2C1C /* OneSignalInAppMessages.framework in Frameworks */,
@@ -3725,6 +3736,7 @@
37253736
3CEE934D2B7C73B6008440BD /* PBXTargetDependency */,
37263737
475F47232B8E398E00EC05B3 /* PBXTargetDependency */,
37273738
3C8544BB2C5AEFF700F542A9 /* PBXTargetDependency */,
3739+
3C7021E62ECF0821001768C6 /* PBXTargetDependency */,
37283740
);
37293741
name = UnitTestApp;
37303742
productName = UnitTestApp;
@@ -4619,6 +4631,11 @@
46194631
target = 3C115160289A259500565C41 /* OneSignalOSCore */;
46204632
targetProxy = 3C115199289AF86C00565C41 /* PBXContainerItemProxy */;
46214633
};
4634+
3C7021E62ECF0821001768C6 /* PBXTargetDependency */ = {
4635+
isa = PBXTargetDependency;
4636+
target = 3E2400371D4FFC31008BDE70 /* OneSignalFramework */;
4637+
targetProxy = 3C7021E52ECF0821001768C6 /* PBXContainerItemProxy */;
4638+
};
46224639
3C7A39C42B7BED900082665E /* PBXTargetDependency */ = {
46234640
isa = PBXTargetDependency;
46244641
target = 3CC063992B6D7A8C002BB07F /* OneSignalCoreMocks */;
@@ -6874,7 +6891,7 @@
68746891
buildSettings = {
68756892
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
68766893
CLANG_ANALYZER_NONNULL = YES;
6877-
CLANG_ENABLE_CODE_COVERAGE = NO;
6894+
CLANG_ENABLE_CODE_COVERAGE = YES;
68786895
CLANG_ENABLE_MODULES = YES;
68796896
CLANG_ENABLE_MODULE_DEBUGGING = YES;
68806897
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -6888,6 +6905,7 @@
68886905
DYLIB_COMPATIBILITY_VERSION = 1;
68896906
DYLIB_CURRENT_VERSION = 1;
68906907
DYLIB_INSTALL_NAME_BASE = "@rpath";
6908+
ENABLE_TESTABILITY = YES;
68916909
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
68926910
INFOPLIST_FILE = OneSignalFramework/Info.plist;
68936911
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -7055,7 +7073,7 @@
70557073
buildSettings = {
70567074
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
70577075
CLANG_ANALYZER_NONNULL = YES;
7058-
CLANG_ENABLE_CODE_COVERAGE = NO;
7076+
CLANG_ENABLE_CODE_COVERAGE = YES;
70597077
CLANG_ENABLE_MODULES = YES;
70607078
CLANG_ENABLE_MODULE_DEBUGGING = YES;
70617079
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -7069,6 +7087,7 @@
70697087
DYLIB_COMPATIBILITY_VERSION = 1;
70707088
DYLIB_CURRENT_VERSION = 1;
70717089
DYLIB_INSTALL_NAME_BASE = "@rpath";
7090+
ENABLE_TESTABILITY = YES;
70727091
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
70737092
INFOPLIST_FILE = OneSignalFramework/Info.plist;
70747093
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";

iOS_SDK/OneSignalSDK/UnitTestApp/UnitTestApp_TestPlan_Full.xctestplan

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@
1111
"defaultOptions" : {
1212
"codeCoverage" : {
1313
"targets" : [
14-
{
15-
"containerPath" : "container:OneSignal.xcodeproj",
16-
"identifier" : "911E2CB91E398AB3003112A4",
17-
"name" : "UnitTests"
18-
},
1914
{
2015
"containerPath" : "container:OneSignal.xcodeproj",
2116
"identifier" : "DE7D17E527026B95002D3A5D",
@@ -48,18 +43,23 @@
4843
},
4944
{
5045
"containerPath" : "container:OneSignal.xcodeproj",
51-
"identifier" : "3CC063EA2B6D7FE8002BB07F",
52-
"name" : "OneSignalUserTests"
46+
"identifier" : "DEBAAE272A4211D900BF2C1C",
47+
"name" : "OneSignalInAppMessages"
48+
},
49+
{
50+
"containerPath" : "container:OneSignal.xcodeproj",
51+
"identifier" : "475F471D2B8E398D00EC05B3",
52+
"name" : "OneSignalLiveActivities"
5353
},
5454
{
5555
"containerPath" : "container:OneSignal.xcodeproj",
56-
"identifier" : "3CC063A02B6D7A8D002BB07F",
57-
"name" : "OneSignalCoreTests"
56+
"identifier" : "DEBAADF82A420A3700BF2C1C",
57+
"name" : "OneSignalLocation"
5858
},
5959
{
6060
"containerPath" : "container:OneSignal.xcodeproj",
61-
"identifier" : "DEBA2A192C20E35E00E234DB",
62-
"name" : "OneSignalNotificationsTests"
61+
"identifier" : "DEF784282912DEB600A1F3A5",
62+
"name" : "OneSignalNotifications"
6363
}
6464
]
6565
},

iOS_SDK/OneSignalSDK/UnitTestApp/UnitTestApp_TestPlan_Reduced.xctestplan

Lines changed: 54 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,60 @@
99
}
1010
],
1111
"defaultOptions" : {
12-
12+
"codeCoverage" : {
13+
"targets" : [
14+
{
15+
"containerPath" : "container:OneSignal.xcodeproj",
16+
"identifier" : "3E2400371D4FFC31008BDE70",
17+
"name" : "OneSignalFramework"
18+
},
19+
{
20+
"containerPath" : "container:OneSignal.xcodeproj",
21+
"identifier" : "DE7D17F827026BA3002D3A5D",
22+
"name" : "OneSignalExtension"
23+
},
24+
{
25+
"containerPath" : "container:OneSignal.xcodeproj",
26+
"identifier" : "DE7D17E527026B95002D3A5D",
27+
"name" : "OneSignalCore"
28+
},
29+
{
30+
"containerPath" : "container:OneSignal.xcodeproj",
31+
"identifier" : "DE69E19A282ED8060090BB3D",
32+
"name" : "OneSignalUser"
33+
},
34+
{
35+
"containerPath" : "container:OneSignal.xcodeproj",
36+
"identifier" : "DE7D187F27037F43002D3A5D",
37+
"name" : "OneSignalOutcomes"
38+
},
39+
{
40+
"containerPath" : "container:OneSignal.xcodeproj",
41+
"identifier" : "DEF784282912DEB600A1F3A5",
42+
"name" : "OneSignalNotifications"
43+
},
44+
{
45+
"containerPath" : "container:OneSignal.xcodeproj",
46+
"identifier" : "475F471D2B8E398D00EC05B3",
47+
"name" : "OneSignalLiveActivities"
48+
},
49+
{
50+
"containerPath" : "container:OneSignal.xcodeproj",
51+
"identifier" : "DEBAAE272A4211D900BF2C1C",
52+
"name" : "OneSignalInAppMessages"
53+
},
54+
{
55+
"containerPath" : "container:OneSignal.xcodeproj",
56+
"identifier" : "DEBAADF82A420A3700BF2C1C",
57+
"name" : "OneSignalLocation"
58+
},
59+
{
60+
"containerPath" : "container:OneSignal.xcodeproj",
61+
"identifier" : "3C115160289A259500565C41",
62+
"name" : "OneSignalOSCore"
63+
}
64+
]
65+
}
1366
},
1467
"testTargets" : [
1568
{

0 commit comments

Comments
 (0)