|
1 | 1 | <!-- START --> |
| 2 | + |
2 | 3 | # READ AND DELETE THIS SECTION BEFORE SUBMITTING PR |
3 | | -* **Fill out each _REQUIRED_ section** |
4 | | -* **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR** |
5 | | -* **Read and fill out each of the checklists below** |
6 | | -* **Remove this section after reading** |
| 4 | + |
| 5 | +- **Fill out each _REQUIRED_ section** |
| 6 | +- **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR** |
| 7 | +- **Read and fill out each of the checklists below** |
| 8 | +- **Remove this section after reading** |
7 | 9 | <!-- END --> |
8 | 10 |
|
9 | 11 | # Description |
| 12 | + |
10 | 13 | ## One Line Summary |
| 14 | + |
11 | 15 | **REQUIRED** - Very short description that summaries the changes in this PR. |
12 | 16 |
|
13 | 17 | ## Details |
14 | 18 |
|
15 | 19 | ### Motivation |
| 20 | + |
16 | 21 | **REQUIRED -** Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X. |
17 | 22 |
|
18 | 23 | ### Scope |
| 24 | + |
19 | 25 | **RECOMMEND - OPTIONAL -** What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default. |
20 | 26 |
|
21 | 27 | ### OPTIONAL - Other |
| 28 | + |
22 | 29 | **OPTIONAL -** Feel free to add any other sections or sub-sections that can explain your PR better. |
23 | 30 |
|
24 | 31 | # Testing |
25 | 32 |
|
26 | 33 | ## Manual testing |
27 | | -**REQUIRED -** Explain what scenarios were tested and the environment. |
28 | 34 |
|
| 35 | +**REQUIRED -** Explain what scenarios were tested and the environment. |
29 | 36 |
|
30 | 37 | # Checklist |
| 38 | + |
31 | 39 | ## Overview |
32 | | - - [ ] I have filled out all **REQUIRED** sections above |
33 | | - - [ ] PR does one thing |
34 | | - - If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR |
35 | | - - [ ] Any Public API changes are explained in the PR details and conform to existing APIs |
| 40 | + |
| 41 | +- [ ] I have filled out all **REQUIRED** sections above |
| 42 | +- [ ] PR does one thing |
| 43 | + - If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR |
| 44 | +- [ ] Any Public API changes are explained in the PR details and conform to existing APIs |
36 | 45 |
|
37 | 46 | ## Testing |
38 | | - - [ ] I have personally tested this on my device, or explained why that is not possible |
39 | | - - [ ] I have tested this on the latest version of the plugin |
40 | | - - [ ] I have tested this on both Android and iOS, or explained why that is not possible |
| 47 | + |
| 48 | +- [ ] I have personally tested this on my device, or explained why that is not possible |
| 49 | +- [ ] I have tested this on the latest version of the plugin |
| 50 | +- [ ] I have tested this on both Android and iOS, or explained why that is not possible |
41 | 51 |
|
42 | 52 | ## Final pass |
43 | | - - [ ] Code is as readable as possible. |
44 | | - - Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code. |
45 | | - - [ ] I have reviewed this PR myself, ensuring it meets each checklist item |
46 | | - - WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this. |
| 53 | + |
| 54 | +- [ ] Code is as readable as possible. |
| 55 | + - Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code. |
| 56 | +- [ ] I have reviewed this PR myself, ensuring it meets each checklist item |
| 57 | + - WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this. |
0 commit comments