Skip to content

Commit 5f0d8dd

Browse files
committed
chore: format codebase with vite-plus formatter
1 parent c03f022 commit 5f0d8dd

File tree

81 files changed

+929
-1045
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+929
-1045
lines changed

.github/ISSUE_TEMPLATE/ask-question.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🙋‍♂️ Ask a question
22
description: Tell us what's on your mind
3-
title: "[Question]: "
4-
labels: ["Question"]
3+
title: '[Question]: '
4+
labels: ['Question']
55
body:
66
- type: markdown
77
attributes:

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🪳 Bug Report
22
description: File a bug report
3-
title: "[Bug]: "
4-
labels: ["Bug"]
3+
title: '[Bug]: '
4+
labels: ['Bug']
55
body:
66
- type: markdown
77
attributes:

.github/ISSUE_TEMPLATE/general-feedback.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 📣 General feedback
22
description: Tell us what's on your mind
3-
title: "[Feedback]: "
4-
labels: ["Feedback"]
3+
title: '[Feedback]: '
4+
labels: ['Feedback']
55
body:
66
- type: markdown
77
attributes:

.github/pull_request_template.md

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,57 @@
11
<!-- START -->
2+
23
# READ AND DELETE THIS SECTION BEFORE SUBMITTING PR
3-
* **Fill out each _REQUIRED_ section**
4-
* **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR**
5-
* **Read and fill out each of the checklists below**
6-
* **Remove this section after reading**
4+
5+
- **Fill out each _REQUIRED_ section**
6+
- **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR**
7+
- **Read and fill out each of the checklists below**
8+
- **Remove this section after reading**
79
<!-- END -->
810

911
# Description
12+
1013
## One Line Summary
14+
1115
**REQUIRED** - Very short description that summaries the changes in this PR.
1216

1317
## Details
1418

1519
### Motivation
20+
1621
**REQUIRED -** Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
1722

1823
### Scope
24+
1925
**RECOMMEND - OPTIONAL -** What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
2026

2127
### OPTIONAL - Other
28+
2229
**OPTIONAL -** Feel free to add any other sections or sub-sections that can explain your PR better.
2330

2431
# Testing
2532

2633
## Manual testing
27-
**REQUIRED -** Explain what scenarios were tested and the environment.
2834

35+
**REQUIRED -** Explain what scenarios were tested and the environment.
2936

3037
# Checklist
38+
3139
## Overview
32-
- [ ] I have filled out all **REQUIRED** sections above
33-
- [ ] PR does one thing
34-
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
35-
- [ ] Any Public API changes are explained in the PR details and conform to existing APIs
40+
41+
- [ ] I have filled out all **REQUIRED** sections above
42+
- [ ] PR does one thing
43+
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
44+
- [ ] Any Public API changes are explained in the PR details and conform to existing APIs
3645

3746
## Testing
38-
- [ ] I have personally tested this on my device, or explained why that is not possible
39-
- [ ] I have tested this on the latest version of the plugin
40-
- [ ] I have tested this on both Android and iOS, or explained why that is not possible
47+
48+
- [ ] I have personally tested this on my device, or explained why that is not possible
49+
- [ ] I have tested this on the latest version of the plugin
50+
- [ ] I have tested this on both Android and iOS, or explained why that is not possible
4151

4252
## Final pass
43-
- [ ] Code is as readable as possible.
44-
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
45-
- [ ] I have reviewed this PR myself, ensuring it meets each checklist item
46-
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
53+
54+
- [ ] Code is as readable as possible.
55+
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
56+
- [ ] I have reviewed this PR myself, ensuring it meets each checklist item
57+
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

.github/workflows/claude-code-review.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,3 @@ jobs:
4141
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
4242
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
4343
# or https://code.claude.com/docs/en/cli-reference for available options
44-

.github/workflows/claude.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,3 @@ jobs:
4747
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
4848
# or https://code.claude.com/docs/en/cli-reference for available options
4949
# claude_args: '--allowed-tools Bash(gh pr:*)'
50-

.vscode/extensions.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
{
2-
"recommendations": [
3-
"VoidZero.vite-plus-extension-pack"
4-
]
2+
"recommendations": ["VoidZero.vite-plus-extension-pack"]
53
}

CHANGELOG.md

Lines changed: 46 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,100 +1,145 @@
11
# Changelog
2+
23
All notable changes to this project will be documented in this file.
34

45
## October 2023
6+
57
### `2.0.2` - 10/16/23
8+
69
#### Changes
10+
711
- Move target check to top of function to avoid adding duped PBXGroup
812

913
## September 2023
14+
1015
### `2.0.1` - 09/27/23
16+
1117
#### Changes
18+
1219
- Plugin Prop Validation & Improvements
1320
- Add ability to set the small icon accent color
1421
- Update Usage in README to reflect major release changes
1522

1623
### `2.0.0` - 09/12/23
24+
1725
#### Changes
26+
1827
- Native version update & major release
1928
- Bump word-wrap from 1.2.3 to 1.2.4
2029

2130
## April 2023
31+
2232
### `1.3.2` - 04/18/23
33+
2334
#### Changes
35+
2436
- Update iOS generation to write xcode project via expo mod rather than directly to file system.
2537
- Bump qs from 6.5.2 to 6.5.3
26-
- Bump decode-uri-component from 0.2.0 to 0.2.2
38+
- Bump decode-uri-component from 0.2.0 to 0.2.2
2739
- Bump @xmldom/xmldom from 0.7.5 to 0.7.10
2840
- Bump multiple dependency versions in OneSignal Example App (ua-parser-js, decode-uri-component, @sideway/formula, @xmldom/xmldom)
2941

3042
## March 2023
43+
3144
### `1.3.1` - 03/03/23
45+
3246
#### Changes
47+
3348
- Update monorepo logic to rely on the more reliable `require.resolve` to find the `onesignal-expo-plugin` package.
3449

3550
## November 2022
51+
3652
### `1.3.0` - 11/30/22
53+
3754
#### Changes
55+
3856
- Add `iosNSEFilePath` configuration options to the plugin, which allows an app to specify a custom iOS Notification Service Extension.
3957

4058
## October 2022
59+
4160
### `1.2.0` - 10/25/22
61+
4262
#### Changes
63+
4364
- Add `smallIcons` and `largeIcons` configuration options to the plugin, which allows an app to specify large and small notification icons to package within the Android build.
4465
- Bump jpeg-js from 0.4.3 to 0.4.4
4566
- Bump simple-plist from 1.3.0 to 1.3.1
4667

4768
### `1.1.2` - 10/04/22
69+
4870
#### Fixes
71+
4972
- Specify `use_frameworks` on `OneSignalNotificationServiceExtension` target in iOS Podfile when applicable (i.e. the app target also specifies `use_frameworks`).
5073

5174
## September 2022
75+
5276
### `1.1.1` - 09/06/22
77+
5378
#### Fixes
79+
5480
- Fix issue where EAS release builds were no longer successfully building due to log statement
5581

5682
### `1.1.0` - 09/01/22
83+
5784
#### Changes
85+
5886
- No longer inject the OneSignal Gradle plugin on Android builds
87+
5988
#### Fixes
89+
6090
- Fix issue where plugin does not support monorepos
6191

6292
## April 2022
93+
6394
### `1.0.1` - 04/11/22
6495

6596
#### Changes
97+
6698
- Add more info regarding the `expo prebuild` command to README.
99+
67100
#### Fixes
101+
68102
- Upstream EAS workaround for "Missing Push Capability on iOS" issue. Adds `aps-environment` entitlement to NSE template. Although it is **not** required in normal builds, there is an upstream limitation from EAS that is resolved by including the push entitlement in both target entitlement files. As of 4/8/22, EAS builds will randomly pick an entitlement file if there are multiple in a project without differentiating among targets. This is resulting in flaky builds where half the time they work and half the time they don't. This can be seen as a temporary fix. Note it carries no side-effects / repercussions (i.e: the entitlement is superfluous but not critical to remove in the future).
69103

70104
## March 2022
105+
71106
### `1.0.0` - 03/28/22
72107

73108
#### Fixes
109+
74110
- Upgrade dependencies (via dependabot)
111+
75112
#### Changes
113+
76114
- Add credentials guide and update README
77115
- Advance to General Availability
78116

79117
## February 2022
118+
80119
### `1.0.0-beta11` - 02/18/2022
120+
81121
#### Added
122+
82123
- Linting
83124
- Instead of creating a "WriterManager", we repurpose the ReaderManager class by renaming it to FileManager and adding a synchronized write helper function (synchronous in the sense that it block further execution until complete).
84125
- iOS constants file
85126

86127
#### Fixes
128+
87129
- Import cleanups
88130
- Linting errors
89131
- Write safety issu. NSE updater helper functions were previously writing to the entitlements & plist files asynchronously. We should await on each to ensure we don't have multiple writes to the same file at once (which is unsafe).
90132

91133
## January 2022
92134

93135
### `1.0.0-beta10` - 01/24/2022
136+
94137
#### Added
138+
95139
- ability to configure version numbers used in the NSE target's plist file.
96140
- `OneSignalLog` class for better console logging.
97141
- this changelog file.
98142

99143
#### Fixed
144+
100145
- re-running `expo prebuild` will no longer result in duplicate entitlements and dependencies added to native files.

EAS.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
# Expo Application Services
2+
23
EAS is Expo's cloud-build service.
34

45
## [EAS Homepage](https://expo.dev/eas)
56

67
## EAS + OneSignal Setup
8+
79
To get OneSignal push notifications working in an EAS-built app, see our guide on how to configure your [iOS credentials](IOS_CREDENTIALS_EAS.md).
810

911
## How to run an iOS EAS-built app
12+
1013
### Run in a production environment
11-
For production builds, your generated ipa file should to be distributed to the App Store or Testflight.
1214

15+
For production builds, your generated ipa file should to be distributed to the App Store or Testflight.
1316

1417
### Run in custom development client
18+
1519
For development/internal distribution builds, you will need to install a [development client](https://docs.expo.dev/development/getting-started/) on your iOS device.
1620

1721
1. Scan the QR code shown in the terminal after EAS build success and install the development client application to your device.

0 commit comments

Comments
 (0)