Skip to content

[feedback]: Should list react-native-onesignal as a peer dependency or somehow express supported version rangeΒ #236

@conrad-vanl

Description

@conrad-vanl

What's on your mind?

Trying to add this plugin on an existing app that uses a 4.x version of react-native-onesignal. I've been running into pod install issues, and just tracked it down to needing to be on a 1.x version of this plugin instead of a 2.x (we're not ready to upgrade react-native-onesignal to 5.x yet). This would've been much easier to track down if react-native-onesignal was listed as a peerDependency on this repo or otherwise communicated somewhere. The 2.0 release notes I don't think even make it entirely clear that the react-native-onesignal version number was being bumped to 5.x.

Otherwise, thanks for providing a great service!

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions