Skip to content

Commit 3472b8b

Browse files
authored
Merge pull request #1537 from OneSignal/user_model_ga
[User Model] GA Upates
2 parents 2314ab6 + 39c6665 commit 3472b8b

File tree

7 files changed

+43
-41
lines changed

7 files changed

+43
-41
lines changed

MIGRATION_GUIDE.md

Lines changed: 24 additions & 22 deletions
Large diffs are not rendered by default.

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ dependencies {
3131

3232
// api is used instead of implementation so the parent :app project can access any of the OneSignal Java
3333
// classes if needed. Such as com.onesignal.NotificationExtenderService
34-
api 'com.onesignal:OneSignal:5.0.0-beta4'
34+
api 'com.onesignal:OneSignal:5.0.0'
3535

3636
testImplementation 'junit:junit:4.12'
3737
}

android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ public void removeGroupedNotifications(String id) {
455455
}
456456

457457

458-
// OneSignal.User.PushSubscription namespace methods
458+
// OneSignal.User.pushSubscription namespace methods
459459
@ReactMethod
460460
public void getPushSubscriptionId(Promise promise) {
461461
IPushSubscription pushSubscription = OneSignal.getUser().getPushSubscription();

examples/RNOneSignalTS/src/OSButtons.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ class OSButtons extends React.Component<Props> {
355355
'Get Push Subscription Id',
356356
async () => {
357357
const id =
358-
await OneSignal.User.PushSubscription.getPushSubscriptionId();
358+
await OneSignal.User.pushSubscription.getPushSubscriptionId();
359359
loggingFunction('Push Subscription Id: ', id);
360360
},
361361
);
@@ -364,24 +364,24 @@ class OSButtons extends React.Component<Props> {
364364
'Get Push Subscription Token',
365365
async () => {
366366
const token =
367-
await OneSignal.User.PushSubscription.getPushSubscriptionToken();
367+
await OneSignal.User.pushSubscription.getPushSubscriptionToken();
368368
loggingFunction('Push Subscription Token: ', token);
369369
},
370370
);
371371

372372
const getOptedInButton = renderButtonView('Is Opted In', async () => {
373-
const optedIn = await OneSignal.User.PushSubscription.getOptedIn();
373+
const optedIn = await OneSignal.User.pushSubscription.getOptedIn();
374374
loggingFunction('Subscribed for the push notifications: ', optedIn);
375375
});
376376

377377
const optInButton = renderButtonView('Opt In', () => {
378378
loggingFunction('Subscribing for the push notifications');
379-
OneSignal.User.PushSubscription.optIn();
379+
OneSignal.User.pushSubscription.optIn();
380380
});
381381

382382
const optOutButton = renderButtonView('Opt Out', () => {
383383
loggingFunction('Unsubscribing from the push notifications');
384-
OneSignal.User.PushSubscription.optOut();
384+
OneSignal.User.pushSubscription.optOut();
385385
});
386386

387387
return [

examples/RNOneSignalTS/src/OSDemo.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class OSDemo extends React.Component<Props, State> {
8989
this.OSLog('OneSignal: did dismiss IAM: ', event);
9090
});
9191

92-
OneSignal.User.PushSubscription.addEventListener(
92+
OneSignal.User.pushSubscription.addEventListener(
9393
'change',
9494
(subscription) => {
9595
this.OSLog('OneSignal: subscription changed:', subscription);

react-native-onesignal.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ Pod::Spec.new do |s|
2222
# pod 'React', :path => '../node_modules/react-native/'
2323

2424
# The Native OneSignal-iOS-SDK XCFramework from cocoapods.
25-
s.dependency 'OneSignalXCFramework', '5.0.0-beta-06'
25+
s.dependency 'OneSignalXCFramework', '5.0.1'
2626
end

src/index.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export enum LogLevel {
5555
let notificationPermission = false;
5656

5757
// Internal wrapper push subscription state that is being updated by the subscription change handler.
58-
let pushSubscription: PushSubscriptionState = {
58+
let pushSub: PushSubscriptionState = {
5959
id: '',
6060
token: '',
6161
optedIn: false,
@@ -70,16 +70,16 @@ async function _addPermissionObserver() {
7070
}
7171

7272
async function _addPushSubscriptionObserver() {
73-
OneSignal.User.PushSubscription.addEventListener(
73+
OneSignal.User.pushSubscription.addEventListener(
7474
'change',
7575
(subscriptionChange) => {
76-
pushSubscription = subscriptionChange.current;
76+
pushSub = subscriptionChange.current;
7777
},
7878
);
7979

80-
pushSubscription.id = await RNOneSignal.getPushSubscriptionId();
81-
pushSubscription.token = await RNOneSignal.getPushSubscriptionToken();
82-
pushSubscription.optedIn = await RNOneSignal.getOptedIn();
80+
pushSub.id = await RNOneSignal.getPushSubscriptionId();
81+
pushSub.token = await RNOneSignal.getPushSubscriptionToken();
82+
pushSub.optedIn = await RNOneSignal.getOptedIn();
8383
}
8484

8585
export namespace OneSignal {
@@ -192,7 +192,7 @@ export namespace OneSignal {
192192
}
193193

194194
export namespace User {
195-
export namespace PushSubscription {
195+
export namespace pushSubscription {
196196
/** Add a callback that fires when the OneSignal subscription state changes. */
197197
export function addEventListener(
198198
event: 'change',
@@ -224,7 +224,7 @@ export namespace OneSignal {
224224
return '';
225225
}
226226

227-
return pushSubscription.id;
227+
return pushSub.id;
228228
}
229229

230230
/** The readonly push subscription token */
@@ -233,7 +233,7 @@ export namespace OneSignal {
233233
return '';
234234
}
235235

236-
return pushSubscription.token;
236+
return pushSub.token;
237237
}
238238

239239
/**
@@ -247,7 +247,7 @@ export namespace OneSignal {
247247
return false;
248248
}
249249

250-
return pushSubscription.optedIn;
250+
return pushSub.optedIn;
251251
}
252252

253253
/** Enable the push notification subscription to OneSignal. */

0 commit comments

Comments
 (0)