PR changes

joonmanji · joonmanji · commit 4e1153b7ba28 · 2021-09-22T14:53:44.000-07:00
diff --git a/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java b/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java
@@ -120,12 +120,9 @@ private String appIdFromManifest(ReactApplicationContext context) {
    }
 
    private void removeObservers() {
-      OneSignal.removeEmailSubscriptionObserver(this);
-      OneSignal.removePermissionObserver(this);
-      OneSignal.removeSubscriptionObserver(this);
-      hasSetEmailSubscriptionObserver = false;
-      hasSetPermissionObserver = false;
-      hasSetSubscriptionObserver = false;
+      this.removeEmailSubscriptionObserver();
+      this.removePermissionObserver();
+      this.removeSubscriptionObserver();
    }
 
    private void removeHandlers() {

Original file line number	Diff line number	Diff line change
`@@ -120,12 +120,9 @@ private String appIdFromManifest(ReactApplicationContext context) {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`private void removeObservers() {`
`123`		`- OneSignal.removeEmailSubscriptionObserver(this);`
`124`		`- OneSignal.removePermissionObserver(this);`
`125`		`- OneSignal.removeSubscriptionObserver(this);`
`126`		`- hasSetEmailSubscriptionObserver = false;`
`127`		`- hasSetPermissionObserver = false;`
`128`		`- hasSetSubscriptionObserver = false;`
	`123`	`+ this.removeEmailSubscriptionObserver();`
	`124`	`+ this.removePermissionObserver();`
	`125`	`+ this.removeSubscriptionObserver();`
`129`	`126`	`}`
`130`	`127`
`131`	`128`	`private void removeHandlers() {`