Skip to content

Commit 8acf1b8

Browse files
committed
Remove Unused Event
• Removed the `onRegistered` event, as it seems that it has never been used for anything.
1 parent 72d6820 commit 8acf1b8

File tree

6 files changed

+2
-32
lines changed

6 files changed

+2
-32
lines changed

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,14 +335,12 @@ export default class App extends Component {
335335
componentWillMount() {
336336
OneSignal.addEventListener('received', this.onReceived);
337337
OneSignal.addEventListener('opened', this.onOpened);
338-
OneSignal.addEventListener('registered', this.onRegistered);
339338
OneSignal.addEventListener('ids', this.onIds);
340339
}
341340

342341
componentWillUnmount() {
343342
OneSignal.removeEventListener('received', this.onReceived);
344343
OneSignal.removeEventListener('opened', this.onOpened);
345-
OneSignal.removeEventListener('registered', this.onRegistered);
346344
OneSignal.removeEventListener('ids', this.onIds);
347345
}
348346

@@ -357,10 +355,6 @@ export default class App extends Component {
357355
console.log('openResult: ', openResult);
358356
}
359357

360-
onRegistered(notifData) {
361-
console.log("Device had been registered for push notifications!", notifData);
362-
}
363-
364358
onIds(device) {
365359
console.log('Device info: ', device);
366360
}

examples/RNOneSignal/index.android.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,30 +51,23 @@ export default class RNOneSignal extends Component {
5151

5252

5353
OneSignal.inFocusDisplaying(2)
54-
55-
OneSignal.getPermissionSubscriptionState((response) => {
56-
console.log("Received permission subscription state: ", response);
57-
});
5854
}
5955

6056
componentDidMount() {
6157
this.onReceived = this.onReceived.bind(this);
6258
this.onOpened = this.onOpened.bind(this);
6359
this.onIds = this.onIds.bind(this);
64-
this.onRegistered = this.onRegistered.bind(this);
6560
this.onEmailRegistrationChange = this.onEmailRegistrationChange.bind(this);
6661

6762
OneSignal.addEventListener('received', this.onReceived);
6863
OneSignal.addEventListener('opened', this.onOpened);
69-
OneSignal.addEventListener('registered', this.onRegistered);
7064
OneSignal.addEventListener('ids', this.onIds);
7165
OneSignal.addEventListener('emailSubscription', this.onEmailRegistrationChange);
7266
}
7367

7468
componentWillUnmount() {
7569
OneSignal.removeEventListener('received', this.onReceived);
7670
OneSignal.removeEventListener('opened', this.onOpened);
77-
OneSignal.removeEventListener('registered', this.onRegistered);
7871
OneSignal.removeEventListener('ids', this.onIds);
7972
OneSignal.removeEventListener('emailSubscription', this.onEmailRegistrationChange);
8073
}
@@ -94,10 +87,6 @@ export default class RNOneSignal extends Component {
9487
console.log('openResult: ', openResult);
9588
}
9689

97-
onRegistered(notifData) {
98-
console.log("Device had been registered for push notifications!", notifData);
99-
}
100-
10190
onIds(device) {
10291
console.log('Device info: ', device);
10392
}

examples/RNOneSignal/index.ios.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,17 @@ export default class RNOneSignal extends Component {
6161
this.onReceived = this.onReceived.bind(this);
6262
this.onOpened = this.onOpened.bind(this);
6363
this.onIds = this.onIds.bind(this);
64-
this.onRegistered = this.onRegistered.bind(this);
6564
this.onEmailRegistrationChange = this.onEmailRegistrationChange.bind(this);
6665

6766
OneSignal.addEventListener('received', this.onReceived);
6867
OneSignal.addEventListener('opened', this.onOpened);
69-
OneSignal.addEventListener('registered', this.onRegistered);
7068
OneSignal.addEventListener('ids', this.onIds);
7169
OneSignal.addEventListener('emailSubscription', this.onEmailRegistrationChange);
7270
}
7371

7472
componentWillUnmount() {
7573
OneSignal.removeEventListener('received', this.onReceived);
7674
OneSignal.removeEventListener('opened', this.onOpened);
77-
OneSignal.removeEventListener('registered', this.onRegistered);
7875
OneSignal.removeEventListener('ids', this.onIds);
7976
OneSignal.removeEventListener('emailSubscription', this.onEmailRegistrationChange);
8077
}
@@ -94,10 +91,6 @@ export default class RNOneSignal extends Component {
9491
console.log('openResult: ', openResult);
9592
}
9693

97-
onRegistered(notifData) {
98-
console.log("Device had been registered for push notifications!", notifData);
99-
}
100-
10194
onIds(device) {
10295
console.log('Device info: ', device);
10396
}

index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ var oneSignalEventEmitter = new NativeEventEmitter(RNOneSignal);
1111
const eventBroadcastNames = [
1212
'OneSignal-remoteNotificationReceived',
1313
'OneSignal-remoteNotificationOpened',
14-
'OneSignal-remoteNotificationsRegistered',
1514
'OneSignal-idsAvailable',
1615
'OneSignal-emailSubscription'
1716
];
1817

19-
var _eventNames = [ "received", "opened", "registered", "ids", "emailSubscription"];
18+
var _eventNames = [ "received", "opened", "ids", "emailSubscription"];
2019

2120
var _notificationHandler = new Map();
2221
var _notificationCache = new Map();

ios/RCTOneSignal/RCTOneSignal.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,6 @@ - (NSDictionary *)jsonObjectWithString:(NSString *)jsonString {
114114
return json;
115115
}
116116

117-
- (void)handleRemoteNotificationsRegistered:(NSNotification *)notification {
118-
[self sendEvent:OSEventString(NotificationReceived) withBody:notification.userInfo];
119-
}
120-
121117
- (void)sendEvent:(NSString *)eventName withBody:(NSDictionary *)body {
122118
[RCTOneSignalEventEmitter sendEventWithName:eventName withBody:body];
123119
}

ios/RCTOneSignal/RCTOneSignalEventEmitter.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@
1515
typedef NS_ENUM(NSInteger, OSNotificationEventTypes) {
1616
NotificationReceived,
1717
NotificationOpened,
18-
NotificationRegistered,
1918
IdsAvailable,
2019
EmailSubscriptionChanged
2120
};
2221

23-
#define OSNotificationEventTypesArray @[@"OneSignal-remoteNotificationReceived",@"OneSignal-remoteNotificationOpened",@"OneSignal-remoteNotificationsRegistered",@"OneSignal-idsAvailable",@"OneSignal-emailSubscription"]
22+
#define OSNotificationEventTypesArray @[@"OneSignal-remoteNotificationReceived",@"OneSignal-remoteNotificationOpened",@"OneSignal-idsAvailable",@"OneSignal-emailSubscription"]
2423
#define OSEventString(enum) [OSNotificationEventTypesArray objectAtIndex:enum]
2524

2625

0 commit comments

Comments
 (0)