Skip to content

Commit ec9255b

Browse files
authored
Merge pull request #663 from geektimecoil/remove_componentWillMount
Remove componentWillMount()
2 parents 479fcad + 66cbec5 commit ec9255b

File tree

2 files changed

+20
-22
lines changed

2 files changed

+20
-22
lines changed

examples/CocoapodsDemo/App.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,13 @@ let imageUri = 'https://cdn-images-1.medium.com/max/300/1*7xHdCFeYfD8zrIivMiQcCQ
2828
export default class RNOneSignal extends Component {
2929
constructor(properties) {
3030
super(properties);
31-
}
3231

33-
validateEmail(email) {
34-
var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
35-
return re.test(String(email).toLowerCase());
36-
}
37-
38-
async componentWillMount() {
3932
OneSignal.setLogLevel(7, 0);
4033

4134
let requiresConsent = false;
4235

43-
this.setState({emailEnabled: false,
36+
this.state = {
37+
emailEnabled: false,
4438
animatingEmailButton : false,
4539
initialOpenFromPush : "Did NOT open from push",
4640
activityWidth : 0,
@@ -50,22 +44,27 @@ export default class RNOneSignal extends Component {
5044
jsonDebugText : "",
5145
privacyButtonTitle : "Privacy Consent: Not Granted",
5246
requirePrivacyConsent : requiresConsent
53-
});
47+
};
5448

5549
OneSignal.setRequiresUserPrivacyConsent(requiresConsent);
5650

5751
OneSignal.init("b2f7f966-d8cc-11e4-bed1-df8f05be55ba", {kOSSettingsKeyAutoPrompt : true});
52+
}
5853

54+
validateEmail(email) {
55+
var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
56+
return re.test(String(email).toLowerCase());
57+
}
58+
59+
async componentDidMount() {
5960
var providedConsent = await OneSignal.userProvidedPrivacyConsent();
6061

6162
this.setState({privacyButtonTitle : `Privacy Consent: ${providedConsent ? "Granted" : "Not Granted"}`, privacyGranted : providedConsent});
6263

6364
OneSignal.setLocationShared(true);
6465

6566
OneSignal.inFocusDisplaying(2)
66-
}
6767

68-
componentDidMount() {
6968
this.onReceived = this.onReceived.bind(this);
7069
this.onOpened = this.onOpened.bind(this);
7170
this.onIds = this.onIds.bind(this);

examples/RNOneSignal/index.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,13 @@ let imageUri = 'https://cdn-images-1.medium.com/max/300/1*7xHdCFeYfD8zrIivMiQcCQ
2828
export default class RNOneSignal extends Component {
2929
constructor(properties) {
3030
super(properties);
31-
}
3231

33-
validateEmail(email) {
34-
var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
35-
return re.test(String(email).toLowerCase());
36-
}
37-
38-
async componentWillMount() {
3932
OneSignal.setLogLevel(7, 0);
4033

4134
let requiresConsent = false;
4235

43-
this.setState({emailEnabled: false,
36+
this.state = {
37+
emailEnabled: false,
4438
animatingEmailButton : false,
4539
initialOpenFromPush : "Did NOT open from push",
4640
activityWidth : 0,
@@ -50,22 +44,27 @@ export default class RNOneSignal extends Component {
5044
jsonDebugText : "",
5145
privacyButtonTitle : "Privacy Consent: Not Granted",
5246
requirePrivacyConsent : requiresConsent
53-
});
47+
};
5448

5549
OneSignal.setRequiresUserPrivacyConsent(requiresConsent);
5650

5751
OneSignal.init("b2f7f966-d8cc-11e4-bed1-df8f05be55ba", {kOSSettingsKeyAutoPrompt : true});
52+
}
5853

54+
validateEmail(email) {
55+
var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
56+
return re.test(String(email).toLowerCase());
57+
}
58+
59+
async componentDidMount() {
5960
var providedConsent = await OneSignal.userProvidedPrivacyConsent();
6061

6162
this.setState({privacyButtonTitle : `Privacy Consent: ${providedConsent ? "Granted" : "Not Granted"}`, privacyGranted : providedConsent});
6263

6364
OneSignal.setLocationShared(true);
6465

6566
OneSignal.inFocusDisplaying(2)
66-
}
6767

68-
componentDidMount() {
6968
this.onReceived = this.onReceived.bind(this);
7069
this.onOpened = this.onOpened.bind(this);
7170
this.onIds = this.onIds.bind(this);

0 commit comments

Comments
 (0)