Skip to content

Commit ce6e58f

Browse files
authored
Merge pull request #126 from OneSignal/fg/remove-version-scripts
Remove version updater scripts
2 parents c5c1d52 + db85816 commit ce6e58f

File tree

6 files changed

+9
-114
lines changed

6 files changed

+9
-114
lines changed

.husky/pre-commit

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
scripts/sync-versions.sh

README.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,14 @@ The code generator uses an `api.json` spec file from the [OneSignal-Website-SDK]
1212

1313
The generator uses the URL hard-coded as a constant in the `src/support/constants.ts` file to fetch the spec. Make sure to update this URL as needed.
1414

15-
## Building For Release
16-
17-
**Update version in `package.json` files**
15+
## Making Changes
1816

19-
Run the `update-version-numbers` script in the `scripts` folder and input the update type (major, minor, patch, beta).
17+
If you made changes to templates, dependencies or other items that affect the downstream builds. When changes are merged to main, a pr is made to the downstreams prs.
18+
**PLEASE UPDATE THE COMMIT MESSAGE** to be accurate to the change. E.g. `fix: ...` or `feat: ...` depending on the type of change.
2019

21-
**Update `README.md` files where needed**
20+
## Building For Release
2221

23-
- React: `src/static/react/README.md`
24-
- Vue: `src/static/vue/README.md`
25-
- Angular: `src/static/onesignal-ngx/README.md`
22+
Can run the build script to bundle release for each package. Used in CD.
2623

2724
```
2825
npm run build

scripts/update-version-numbers

Lines changed: 0 additions & 13 deletions
This file was deleted.

scripts/version-updater

Lines changed: 0 additions & 90 deletions
This file was deleted.

src/static/vue/v2/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/static/vue/v2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "onesignal-vue",
3-
"version": "2.4.2",
3+
"version": "2.5.0",
44
"description": "Vue OneSignal Plugin: Make it easy to integrate OneSignal with your Vue App!",
55
"type": "module",
66
"contributors": [

0 commit comments

Comments
 (0)