Use DI more correctly; New Raw HyperSerializerDelegate, intending for passing byte arrays as responses; HyperStatus now includes the hyper serializer to use

Author: OoLunar

benchmarks/Responders/OkResponder.cs

@@ -11,6 +11,6 @@ namespace HyperSharp.Benchmarks.Responders
     {
         public static Type[] Needs => Type.EmptyTypes;
 
-        public Result<HyperStatus> Respond(HyperContext context, CancellationToken cancellationToken = default) => Result.Success(new HyperStatus(HttpStatusCode.OK));
+        public Result<HyperStatus> Respond(HyperContext context, CancellationToken cancellationToken = default) => Result.Success(HyperStatus.OK());
     }
 }

benchmarks/Responders/OkTaskResponder.cs

@@ -14,7 +14,7 @@ namespace HyperSharp.Benchmarks.Responders
 
         public async Task<Result<HyperStatus>> RespondAsync(HyperContext context, CancellationToken cancellationToken = default)
         {
-            await context.RespondAsync(new HyperStatus(HttpStatusCode.OK), HyperSerializers.PlainTextAsync, cancellationToken);
+            await context.RespondAsync(HyperStatus.OK(), HyperSerializers.PlainTextAsync, cancellationToken);
             return Result.Success(default(HyperStatus));
         }
     }

src/HyperSharp.SourceGeneration/src/Tasks/HyperStatusConstructorGenerator.cs

@@ -23,20 +23,57 @@ namespace HyperSharp.Protocol
     public readonly partial record struct HyperStatus
     {
         /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
-        public static HyperStatus {{Code}}() => new(global::System.Net.HttpStatusCode.{{Code}}, new HyperHeaderCollection(), null);
+        public static HyperStatus {{Code}}() => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}}
+        };
 
         /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
         /// <param name="body">The body of the response.</param>
-        public static HyperStatus {{Code}}(object? body) => new(global::System.Net.HttpStatusCode.{{Code}}, new HyperHeaderCollection(), body);
+        public static HyperStatus {{Code}}(object? body) => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}},
+            Body = body
+        };
+
+        /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
+        /// <param name="body">The body of the response.</param>
+        /// <param name="serializer">Which serializer to use to serialize the body.</param>
+        public static HyperStatus {{Code}}(object? body, HyperSerializerDelegate serializer) => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}},
+            Body = body,
+            Serializer = serializer
+        };
 
         /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
         /// <param name="headers">The headers of the response.</param>
-        public static HyperStatus {{Code}}(HyperHeaderCollection headers) => new(global::System.Net.HttpStatusCode.{{Code}}, headers, null);
+        public static HyperStatus {{Code}}(HyperHeaderCollection headers) => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}},
+            Headers = headers
+        };
 
         /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
         /// <param name="headers">The headers of the response.</param>
         /// <param name="body">The body of the response.</param>
-        public static HyperStatus {{Code}}(HyperHeaderCollection headers, object? body) => new(global::System.Net.HttpStatusCode.{{Code}}, headers, body);
+        public static HyperStatus {{Code}}(HyperHeaderCollection headers, object? body) => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}},
+            Headers = headers,
+            Body = body
+        };
+
+        /// <inheritdoc cref="global::System.Net.HttpStatusCode.{{Code}}" />
+        /// <param name="headers">The headers of the response.</param>
+        /// <param name="body">The body of the response.</param>
+        public static HyperStatus {{Code}}(HyperHeaderCollection headers, object? body, HyperSerializerDelegate serializer) => new HyperStatus()
+        {
+            Code = global::System.Net.HttpStatusCode.{{Code}},
+            Headers = headers,
+            Body = body,
+            Serializer = serializer
+        };
     }
 }
 

src/HyperSharp/HyperConfiguration.cs

@@ -55,31 +55,30 @@ public sealed record HyperConfiguration
         /// <summary>
         /// Creates a new <see cref="HyperConfiguration"/> with the default values.
         /// </summary>
-        public HyperConfiguration() : this(new ServiceCollection().AddLogging(builder => builder.AddProvider(NullLoggerProvider.Instance)).AddHyperSharp(), new HyperConfigurationBuilder()) { }
+        public HyperConfiguration() : this(new ServiceCollection().AddLogging(builder => builder.AddProvider(NullLoggerProvider.Instance)).AddHyperSharp().BuildServiceProvider(), new HyperConfigurationBuilder()) { }
 
         /// <summary>
         /// Creates a new <see cref="HyperConfiguration"/> with the specified values.
         /// </summary>
         /// <param name="builder">The <see cref="HyperConfigurationBuilder"/> to use.</param>
-        public HyperConfiguration(HyperConfigurationBuilder builder) : this(new ServiceCollection().AddLogging(builder => builder.AddProvider(NullLoggerProvider.Instance)).AddHyperSharp(), builder) { }
+        public HyperConfiguration(HyperConfigurationBuilder builder) : this(new ServiceCollection().AddLogging(builder => builder.AddProvider(NullLoggerProvider.Instance)).AddHyperSharp().BuildServiceProvider(), builder) { }
 
         /// <summary>
         /// Creates a new <see cref="HyperConfiguration"/> using the specified <see cref="IServiceCollection"/>.
         /// </summary>
         /// <param name="serviceDescriptors">The <see cref="IServiceCollection"/> to use when creating the responders.</param>
-        public HyperConfiguration(IServiceCollection serviceDescriptors) : this(serviceDescriptors, new HyperConfigurationBuilder()) { }
+        public HyperConfiguration(IServiceCollection serviceDescriptors) : this(serviceDescriptors.BuildServiceProvider(), new HyperConfigurationBuilder()) { }
 
         /// <summary>
         /// Creates a new <see cref="HyperConfiguration"/> using the specified <see cref="IServiceCollection"/> and <see cref="HyperConfigurationBuilder"/>.
         /// </summary>
-        /// <param name="serviceDescriptors">The <see cref="IServiceCollection"/> to use when creating the responders.</param>
+        /// <param name="serviceProvider">The <see cref="IServiceProvider"/> to use.</param>
         /// <param name="builder">The <see cref="HyperConfigurationBuilder"/> to use.</param>
-        public HyperConfiguration(IServiceCollection serviceDescriptors, HyperConfigurationBuilder builder)
+        public HyperConfiguration(IServiceProvider serviceProvider, HyperConfigurationBuilder builder)
         {
-            ArgumentNullException.ThrowIfNull(serviceDescriptors, nameof(serviceDescriptors));
+            ArgumentNullException.ThrowIfNull(serviceProvider, nameof(serviceProvider));
             ArgumentNullException.ThrowIfNull(builder, nameof(builder));
 
-            IServiceProvider serviceProvider = serviceDescriptors.BuildServiceProvider();
             if (!Uri.TryCreate($"http://{builder.ListeningEndpoint}/", UriKind.Absolute, out Uri? host))
             {
                 throw new ArgumentException("The listening endpoint is invalid.", nameof(builder));

src/HyperSharp/HyperServer.cs

@@ -178,7 +178,7 @@ private async Task HandleConnectionAsync(Ulid id, NetworkStream networkStream)
                         _ => throw new NotImplementedException("Unimplemented result status, please open a GitHub issue as this is a bug.")
                     };
 
-                    await context.Value.RespondAsync(response, HyperSerializers.JsonAsync, cancellationTokenSource.Token);
+                    await context.Value.RespondAsync(response, cancellationTokenSource.Token);
                     HyperLogging.HttpResponded(_logger, connection.Id, response, null);
                 }
             }

src/HyperSharp/Protocol/HyperContext.cs

@@ -105,7 +105,7 @@ public HyperContext(HttpMethod method, Uri route, Version version, HyperHeaderCo
         }
 
         /// <inheritdoc cref="RespondAsync(HyperStatus, HyperSerializerDelegate, CancellationToken)"/>
-        public ValueTask RespondAsync(HyperStatus status, CancellationToken cancellationToken = default) => RespondAsync(status, HyperSerializers.JsonAsync, cancellationToken);
+        public ValueTask RespondAsync(HyperStatus status, CancellationToken cancellationToken = default) => RespondAsync(status, status.Serializer, cancellationToken);
 
         /// <summary>
         /// Responds to the request with the specified status in plain text.

src/HyperSharp/Protocol/HyperHeaderCollection.cs

@@ -1,7 +1,9 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
+using System.Linq;
 using System.Net.Http.Headers;
 using System.Text;
 
@@ -10,6 +12,7 @@ namespace HyperSharp.Protocol
     /// <summary>
     /// Represents a collection of headers with string keys and lists of string values.
     /// </summary>
+    [DebuggerDisplay("{ToString(),nq}")]
     public sealed partial class HyperHeaderCollection : IList<KeyValuePair<string, byte[]>>
     {
         private readonly List<KeyValuePair<string, byte[]>> _headers;
@@ -548,5 +551,19 @@ public bool TryGetValues(string key, [NotNullWhen(true)] out List<byte[]>? value
         /// <inheritdoc />
         public IEnumerator<KeyValuePair<string, byte[]>> GetEnumerator() => _headers.GetEnumerator();
         IEnumerator IEnumerable.GetEnumerator() => _headers.GetEnumerator();
+
+        public override string ToString()
+        {
+            StringBuilder stringBuilder = new();
+            foreach (KeyValuePair<string, byte[]> header in _headers.OrderBy(x => x.Key))
+            {
+                stringBuilder.Append(header.Key);
+                stringBuilder.Append(": ");
+                stringBuilder.Append(Encoding.ASCII.GetString(header.Value));
+                stringBuilder.Append("\r\n");
+            }
+
+            return stringBuilder.ToString();
+        }
     }
 }

src/HyperSharp/Protocol/HyperHeaderName.cs

@@ -1,5 +1,5 @@
 // <auto-generated/>
-// Last modified at 2024-06-28.
+// Last modified at 2024-07-30.
 
 namespace HyperSharp.Protocol
 {

src/HyperSharp/Protocol/HyperSerializers/JsonAsync.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text;
 using System.Text.Json;
 using System.Threading;
@@ -9,7 +10,7 @@ namespace HyperSharp.Protocol
 {
     public static partial class HyperSerializers
     {
-        private static readonly byte[] _contentTypeJsonEncodingHeader = "Content-Type: application/json; charset=utf-8\r\nContent-Length: "u8.ToArray();
+        private static readonly byte[] _contentTypeJsonEncodingHeader = "Content-Type: application/json\r\nContent-Length: "u8.ToArray();
 
         /// <summary>
         /// Serializes the body to the client as JSON using the <see cref="JsonSerializer.SerializeToUtf8Bytes{TValue}(TValue, JsonSerializerOptions?)"/> method with the <see cref="HyperConfiguration.JsonSerializerOptions"/> options.
@@ -28,7 +29,7 @@ public static ValueTask<bool> JsonAsync(HyperContext context, HyperStatus status
             byte[] body = JsonSerializer.SerializeToUtf8Bytes(status.Body ?? new object(), context.Connection.Server.Configuration.JsonSerializerOptions);
 
             // Finish the Content-Length header
-            context.Connection.StreamWriter.Write<byte>(Encoding.ASCII.GetBytes(body.Length.ToString()));
+            context.Connection.StreamWriter.Write<byte>(Encoding.ASCII.GetBytes(body.Length.ToString(CultureInfo.InvariantCulture)));
             context.Connection.StreamWriter.Write<byte>(_newLine);
 
             // Write body

src/HyperSharp/Protocol/HyperSerializers/PlainTextAsync.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -29,7 +30,7 @@ public static ValueTask<bool> PlainTextAsync(HyperContext context, HyperStatus s
             byte[] body = Encoding.UTF8.GetBytes(status.Body?.ToString() ?? "");
 
             // Write Content-Length header
-            context.Connection.StreamWriter.Write<byte>(Encoding.ASCII.GetBytes(body.Length.ToString()));
+            context.Connection.StreamWriter.Write<byte>(Encoding.UTF8.GetBytes(body.Length.ToString(CultureInfo.InvariantCulture)));
             context.Connection.StreamWriter.Write<byte>(_newLine);
 
             // Write body