Always and Trial hint types break if order is 0

[aofengen]

This screenshot is the resulting error if a hint distribution has an order of 0 for the trial hint type. The same error occurs if the always hint type is set to an order of 0. Having an order of 0 causes a hint type to not be a part of the hint_dist dictionary, which causes a break in lines 1497 and 1542 of Hints.py. To my knowledge no other hint types function this way, where the hint types are hardcoded to always be expected.

[fenhl]

The error is intentional behavior (though I'd consider the bad error message to be a bug), so I'm going to label this as an enhancement issue, but I agree that it would be nice to not require the order which is effectively ignored anyway. See #2019 for a similar change that made most entries in the distribution object optional.

[jdunn596]

This is the error message I get when changing the order to 0 for any hint type required of the preset, including both trial and always hints (S9 Settings, changed in tournament.json)

Traceback (most recent call last):
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer/OoTRandomizer.py", line 57, in start
    main(settings)
    ~~~~^^^^^^^^^^
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer\Main.py", line 46, in main
    spoiler = generate(settings)
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer\Main.py", line 125, in generate
    return make_spoiler(settings, worlds)
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer\Main.py", line 195, in make_spoiler
    build_gossip_hints(spoiler, worlds)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer\Hints.py", line 1346, in build_gossip_hints
    build_world_gossip_hints(spoiler, world, checked_locations.pop(world.id, {}))
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Jimmy\Documents\Projects\OoT-Randomizer\Hints.py", line 1453, in build_world_gossip_hints
    raise Exception("There are gaps in the custom hint orders. Please revise your plando file to remove them.")
Exception: There are gaps in the custom hint orders. Please revise your plando file to remove them.

Was this recently changed?