Skip to content

Commit d44b9f8

Browse files
author
AnotherCommander
committed
The full version string is now printed in the log header and the main title screen when the -showversion argument is used. Also, fixed snapshot build watermark not showing the game version.
1 parent f83805a commit d44b9f8

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ release-deployment:
4141

4242
.PHONY: release-snapshot
4343
release-snapshot:
44-
$(MAKE) -f GNUmakefile SNAPSHOT_BUILD=yes VERSION_STRING=$(VER) debug=no
44+
$(MAKE) -f GNUmakefile SNAPSHOT_BUILD=yes debug=no
4545
mkdir -p AddOns && rm -rf AddOns/Basic-debug.oxp && cp -rf DebugOXP/Debug.oxp AddOns/Basic-debug.oxp
4646

4747
.PHONY: debug

src/Core/Entities/PlayerEntity.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10075,7 +10075,7 @@ - (void) setGuiToIntroFirstGo:(BOOL)justCobra
1007510075
if ([[arguments objectAtIndex:i] isEqual:@"-showversion"])
1007610076
{
1007710077
OOGUIRow ms_start = msgLine;
10078-
NSString *version = [NSString stringWithFormat:@"Version %@", [[[NSBundle mainBundle] infoDictionary] objectForKey:@"CFBundleVersion"]];
10078+
NSString *version = [NSString stringWithFormat:@"Version %s", OO_VERSION_FULL];
1007910079
OOGUIRow i = msgLine = [gui addLongText:version startingAtRow:ms_start align:GUI_ALIGN_CENTER];
1008010080
for (i-- ; i >= ms_start; i--)
1008110081
{

src/Core/OOLogHeader.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,10 @@ void OOPrintLogHeader(void)
161161
#endif
162162

163163
NSString *versionString = nil;
164-
#if (defined (SNAPSHOT_BUILD) && defined (OOLITE_SNAPSHOT_VERSION))
165-
versionString = @"development version " OOLITE_SNAPSHOT_VERSION;
164+
#if (defined (SNAPSHOT_BUILD)) // && defined (OOLITE_SNAPSHOT_VERSION))
165+
versionString = @"development version " @OO_VERSION_FULL;
166166
#else
167-
versionString = [NSString stringWithFormat:@"version %@", [[[NSBundle mainBundle] infoDictionary] objectForKey:@"CFBundleVersion"]];
167+
versionString = [NSString stringWithFormat:@"version %s", OO_VERSION_FULL];
168168
#endif
169169
if (versionString == nil) versionString = @"<unknown version>";
170170

src/Core/Universe.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5229,8 +5229,8 @@ - (void) drawUniverse
52295229
// should come after the HUD to avoid it being overlapped by it
52305230
[self drawMessage];
52315231

5232-
#if (defined (SNAPSHOT_BUILD) && defined (OOLITE_SNAPSHOT_VERSION))
5233-
[self drawWatermarkString:@"Development version " @OOLITE_SNAPSHOT_VERSION];
5232+
#if (defined (SNAPSHOT_BUILD)) // && defined (OOLITE_SNAPSHOT_VERSION))
5233+
[self drawWatermarkString:@"Development version " @OO_VERSION_FULL];
52345234
#endif
52355235

52365236
OOLog(@"universe.profile.drawHUD", @"%@", @"End HUD drawing");

0 commit comments

Comments
 (0)