Token registry integrations

[marlowl]

@superical @simboonlong I checked out the beta branch of the token-registry, looks like quite an big upgrade compared to the v3 versions. Is there any timeline of when this beta will be released into a 'full' major v4 release?

And which of the versions would you recommend to build stable integrations against? I could imagine this is still the v2 packages, since these versions are also integrated, in other TradeTrust/OA tooling. (see this and this for example).

[superical]

hey @marlowl!

Is there any timeline of when this beta will be released into a 'full' major v4 release?

The v4 beta contracts are undergoing an audit. I'd like to think that a good time for transiting into a full major v4 could be when the audit is completed and issues are rectified.

And which of the versions would you recommend to build stable integrations against?

I'm not sure if there is an official recommendation from the product team about the version, but v3 is currently the "latest" distribution version. I'll have to check on this if you need.

But if you were asking for my personal (hence unofficial😅) opinion from a technical perspective, I would go with the v4 beta as much as I can. Just my 2 sats though.

I could imagine this is still the v2 packages, since these versions are also integrated, in other TradeTrust/OA tooling.

Yea, few of them are still stuck at some of the early versions of v2. There are works in the pipeline to update them.

[marlowl]

@superical This is one of the repro cases I can build:

Deploy a factory

npx hardhat deploy:factory --network goerli
[Deployer] 0x0861152F372688F61112ece01B2a8Af9BE06e0a1
[Transaction] Pending 0x52679c010fa1a5499a2a57eb81f69658fe124597b395f82ac5df6410985a06b2
[Address] Deployed to 0x762fc6bF4Ac40e49677E9a577F9c4d3e46D1D3eE
[Transaction] Pending 0x52679c010fa1a5499a2a57eb81f69658fe124597b395f82ac5df6410985a06b2
[Status] Deployed to 0x762fc6bF4Ac40e49677E9a577F9c4d3e46D1D3eE
[Status] ✅ Completed deploying Title Escrow Factory at 0x762fc6bF4Ac40e49677E9a577F9c4d3e46D1D3eE

Trying to deploy a token to a given factory

npx hardhat deploy:token --name ebl --symbol ebl --network goerli --factory 0x762fc6bF4Ac40e49677E9a577F9c4d3e46D1D3eE
[Deployer] 0x0861152F372688F61112ece01B2a8Af9BE06e0a1
[Status] Title Escrow Factory interface check is OK.
[Transaction] Pending 0x908221eb5852e08be0696ba1ad604b155cc35a44497f8cd95a452391c5778e90
[Status] ❌ An error occurred while deploying token
Cannot find topic 0x3588ebb5c75fdf91927f8472318f41513ee567c2612a5ce52ac840dcf6f162f5

[superical]

Ahh... This looks like a bug in the address config + goerli isn't fully supported yet for quick start mode in token registry. As mentioned in the readme, only mumbai, rinkeby, and ropsten are currently supported for quick start.

Coincidentally, I'm right in the midst of pushing support for goerli and sepolia for the token registry after merging the same support for the frontend and cli this week.😄 I should be able to add support for goerli in token registry ready by today or early tomorrow. I have also pushed in a fix for the address bug in Open-Attestation/token-registry#126.

[superical]

@marlowl The update for goerli and sepolia in quick start mode has been merged into the beta branch yesterday. Let us know if it works for you now. 😊

[marlowl]

@superical can confirm it works on my side as well now! 😄

[superical]

Nice! Glad that it works for you now!😃

[marlowl]

@superical @simboonlong I noticed that the major v4 version of the token-registry was released, nice 😄

Does the v4 version already contain the audited version of the smart contracts?

[superical]

Still working out a couple of minor items to be confirmed with the auditor though.

[marlowl]

@superical Thanks for clarifying!
Once those minor items are cleared, I guess there will be something like another major release?

[superical]

I don't think so. We promoted the version from beta to major only because product team requested it for their publication and so there are still some remaining changes to be confirmed. I'm not expecting the changes to be too far from what it is now though. Perhaps I can update this thread when the remaining items are all confirmed so that you will be aware of it?

[marlowl]

That would be great, thanks! 😄