Changed misleading 'max dirty ratio' name

The updated name version is 'dirty ratio trigger'

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>

Author: Deixx

inc/cleaning/alru.h

@@ -17,7 +17,7 @@ enum ocf_cleaning_alru_parameters {
 	ocf_alru_stale_buffer_time,
 	ocf_alru_flush_max_buffers,
 	ocf_alru_activity_threshold,
-	ocf_alru_max_dirty_ratio,
+	ocf_alru_dirty_ratio_trigger,
 };
 
 /**
@@ -70,17 +70,18 @@ enum ocf_cleaning_alru_parameters {
 #define OCF_ALRU_DEFAULT_ACTIVITY_THRESHOLD	10000
 
 /**
- * ALRU max dirty ratio for a cache device
+ * ALRU dirty ratio based cleaning trigger for a cache device
  */
 
-/** Minimum dirty ratio value */
-#define OCF_ALRU_MIN_MAX_DIRTY_RATIO		0
-/** Maximum dirty ratio value */
-#define OCF_ALRU_MAX_MAX_DIRTY_RATIO		100
-/** Default dirty ratio value */
-#define OCF_ALRU_DEFAULT_MAX_DIRTY_RATIO	OCF_ALRU_MAX_MAX_DIRTY_RATIO
+/** Minimum dirty ratio trigger value */
+#define OCF_ALRU_MIN_DIRTY_RATIO_TRIGGER		0
+/** Maximum dirty ratio trigger value */
+#define OCF_ALRU_MAX_DIRTY_RATIO_TRIGGER		100
+/** Default dirty ratio trigger value */
+#define OCF_ALRU_DEFAULT_DIRTY_RATIO_TRIGGER	\
+		OCF_ALRU_MAX_DIRTY_RATIO_TRIGGER
 /** Default dirty ratio trigger inertia */
-#define OCF_ALRU_DEFAULT_TRIGGER_INERTIA	5
+#define OCF_ALRU_DEFAULT_TRIGGER_INERTIA		5
 /**
  * @}
  */

src/cleaning/alru.c

@@ -363,7 +363,7 @@ void cleaning_policy_alru_setup(struct ocf_cache *cache)
 	config->stale_buffer_time = OCF_ALRU_DEFAULT_STALENESS_TIME;
 	config->flush_max_buffers = OCF_ALRU_DEFAULT_FLUSH_MAX_BUFFERS;
 	config->activity_threshold = OCF_ALRU_DEFAULT_ACTIVITY_THRESHOLD;
-	config->max_dirty_ratio = OCF_ALRU_DEFAULT_MAX_DIRTY_RATIO;
+	config->dirty_trigger_threshold = OCF_ALRU_DEFAULT_DIRTY_RATIO_TRIGGER;
 	config->dirty_trigger_inertia = OCF_ALRU_DEFAULT_TRIGGER_INERTIA;
 }
 
@@ -632,18 +632,19 @@ int cleaning_policy_alru_set_cleaning_param(ocf_cache_t cache,
 				"activity time threshold: %d\n",
 				config->activity_threshold);
 		break;
-	case ocf_alru_max_dirty_ratio:
+	case ocf_alru_dirty_ratio_trigger:
 		OCF_CLEANING_CHECK_PARAM(cache, param_value,
-				OCF_ALRU_MIN_MAX_DIRTY_RATIO,
-				OCF_ALRU_MAX_MAX_DIRTY_RATIO,
-				"max_dirty_ratio");
-		config->max_dirty_ratio = param_value;
+				OCF_ALRU_MIN_DIRTY_RATIO_TRIGGER,
+				OCF_ALRU_MAX_DIRTY_RATIO_TRIGGER,
+				"dirty_trigger_threshold");
+		config->dirty_trigger_threshold = param_value;
 		ocf_cache_log(cache, log_info, "Write-back flush thread "
-				"max dirty ratio: %d\n",
-				config->max_dirty_ratio);
-		if (config->max_dirty_ratio < config->dirty_trigger_inertia)
+				"dirty ratio trigger threshold: %d\n",
+				config->dirty_trigger_threshold);
+		if (config->dirty_trigger_threshold
+			< config->dirty_trigger_inertia)
 			config->dirty_trigger_inertia
-				= config->max_dirty_ratio;
+				= config->dirty_trigger_threshold;
 		break;
 	default:
 		return -OCF_ERR_INVAL;
@@ -672,8 +673,8 @@ int cleaning_policy_alru_get_cleaning_param(ocf_cache_t cache,
 	case ocf_alru_activity_threshold:
 		*param_value = config->activity_threshold;
 		break;
-	case ocf_alru_max_dirty_ratio:
-		*param_value = config->max_dirty_ratio;
+	case ocf_alru_dirty_ratio_trigger:
+		*param_value = config->dirty_trigger_threshold;
 		break;
 	default:
 		return -OCF_ERR_INVAL;
@@ -728,16 +729,17 @@ static bool check_for_dirty_ratio(ocf_cache_t cache,
 	struct alru_context *ctx;
 	uint32_t threshold;
 
-	if (config->max_dirty_ratio == OCF_ALRU_MAX_MAX_DIRTY_RATIO)
+	if (config->dirty_trigger_threshold == OCF_ALRU_MAX_DIRTY_RATIO_TRIGGER)
 		return false;
 
 	if (ocf_cache_get_info(cache, &info))
 		return false;
 
 	ctx = cache->cleaner.cleaning_policy_context;
 	threshold = ctx->dirty_ratio_triggered
-		? config->max_dirty_ratio - config->dirty_trigger_inertia
-		: config->max_dirty_ratio;
+		? config->dirty_trigger_threshold
+			- config->dirty_trigger_inertia
+		: config->dirty_trigger_threshold;
 
 	ctx->dirty_ratio_triggered = info.dirty * 100 / info.size >= threshold;
 	return ctx->dirty_ratio_triggered;
@@ -753,7 +755,7 @@ static bool is_cleanup_possible(ocf_cache_t cache, struct alru_flush_ctx *fctx)
 	if (check_for_dirty_ratio(cache, config)) {
 		fctx->dirty_ratio_exceeded = true;
 		OCF_DEBUG_PARAM(cache, "Dirty ratio exceeds: %u%%",
-				config->max_dirty_ratio);
+				config->dirty_trigger_threshold);
 		return true;
 	}
 

src/cleaning/alru_structs.h

@@ -22,7 +22,7 @@ struct alru_cleaning_policy_config {
 	uint32_t stale_buffer_time;			/* in seconds */
 	uint32_t flush_max_buffers;			/* in lines */
 	uint32_t activity_threshold;		/* in milliseconds */
-	uint32_t max_dirty_ratio;			/* percent */
+	uint32_t dirty_trigger_threshold;	/* percent */
 	uint32_t dirty_trigger_inertia;		/* percent */
 };