Return different errors for metadata found during start and attach

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>

Author: Deixx

inc/ocf_def.h

@@ -1,6 +1,6 @@
 /*
  * Copyright(c) 2012-2022 Intel Corporation
- * Copyright(c) 2024 Huawei Technologies
+ * Copyright(c) 2024-2025 Huawei Technologies
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
@@ -128,6 +128,9 @@ typedef enum {
 	ocf_cache_state_standby = 4,     //!< ocf_cache_state_standby
 		/*!< OCF cache is currently in standby mode */
 
+	ocf_cache_state_initializing = 5,     //!< ocf_cache_state_initializing
+		/*!< OCF cache is being initialized */
+
 	ocf_cache_state_max              //!< ocf_cache_state_max
 		/*!< Stopper of cache state enumerator */
 } ocf_cache_state_t;

inc/ocf_err.h

@@ -1,6 +1,6 @@
 /*
  * Copyright(c) 2012-2021 Intel Corporation
- * Copyright(c) 2024 Huawei Technologies
+ * Copyright(c) 2024-2025 Huawei Technologies
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
@@ -42,9 +42,12 @@ typedef enum {
 	/** No metadata found on device */
 	OCF_ERR_NO_METADATA,
 
-	/** Cache metadata found on device */
+	/** Cache metadata found on device on cache start */
 	OCF_ERR_METADATA_FOUND,
 
+	/** Cache metadata found on device on cache attach */
+	OCF_ERR_METADATA_FOUND_ATTACH,
+
 	/** Metadata on the device doesn't match with metadata in DRAM */
 	OCF_ERR_SUPERBLOCK_MISMATCH,
 

src/mngt/ocf_mngt_cache.c

@@ -1,6 +1,6 @@
 /*
  * Copyright(c) 2012-2022 Intel Corporation
- * Copyright(c) 2023-2024 Huawei Technologies
+ * Copyright(c) 2023-2025 Huawei Technologies
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
@@ -176,6 +176,7 @@ struct ocf_cache_attach_context {
 };
 
 static void _ocf_mngt_cache_set_detached(ocf_cache_t cache);
+static void _ocf_mngt_cache_set_initializing(ocf_cache_t cache);
 
 static void __init_partitions(ocf_cache_t cache)
 {
@@ -885,7 +886,7 @@ static int _ocf_mngt_init_new_cache(struct ocf_cache_mngt_init_params *params,
 	env_atomic_set(&(cache->last_access_ms),
 			env_ticks_to_msecs(env_get_tick_count()));
 
-	_ocf_mngt_cache_set_detached(cache);
+	_ocf_mngt_cache_set_initializing(cache);
 
 	params->cache = cache;
 	params->flags.cache_alloc = true;
@@ -1200,14 +1201,17 @@ static void _ocf_mngt_attach_read_properties_end(void *priv, int error,
 		struct ocf_metadata_load_properties *properties)
 {
 	struct ocf_cache_attach_context *context = priv;
+	ocf_cache_t cache = context->cache;
 
 	if (error != -OCF_ERR_NO_METADATA) {
 		if (!error) {
 			/*
 			 * To prevent silent metadata overriding, return error if old
 			 * metadata was detected when attempting to attach cache.
 			 */
-			OCF_PL_FINISH_RET(context->pipeline, -OCF_ERR_METADATA_FOUND);
+			if (env_bit_test(ocf_cache_state_initializing, &cache->cache_state))
+				OCF_PL_FINISH_RET(context->pipeline, -OCF_ERR_METADATA_FOUND);
+			OCF_PL_FINISH_RET(context->pipeline, -OCF_ERR_METADATA_FOUND_ATTACH);
 		}
 		OCF_PL_FINISH_RET(context->pipeline, error);
 	}
@@ -1586,6 +1590,7 @@ static void _ocf_mngt_cache_set_valid(ocf_cache_t cache)
 	 * Clear initialization state and set the valid bit so we know
 	 * its in use.
 	 */
+	env_bit_clear(ocf_cache_state_initializing, &cache->cache_state);
 	env_bit_clear(ocf_cache_state_detached, &cache->cache_state);
 	env_bit_set(ocf_cache_state_running, &cache->cache_state);
 }
@@ -1614,6 +1619,13 @@ static void _ocf_mngt_cache_set_detached(ocf_cache_t cache)
 	env_bit_set(ocf_cache_state_detached, &cache->cache_state);
 }
 
+static void _ocf_mngt_cache_set_initializing(ocf_cache_t cache)
+{
+	env_bit_clear(ocf_cache_state_running, &cache->cache_state);
+	env_bit_set(ocf_cache_state_detached, &cache->cache_state);
+	env_bit_set(ocf_cache_state_initializing, &cache->cache_state);
+}
+
 static void _ocf_mngt_init_attached_nonpersistent(ocf_pipeline_t pipeline,
 		void *priv, ocf_pipeline_arg_t arg)
 {