tests: fix pep8 style violation

Signed-off-by: Kamil Gierszewski <[email protected]>

Author: Kamil Gierszewski

test/functional/api/cas/cache.py

@@ -50,7 +50,7 @@ def __get_cache_device(self) -> Device | None:
         if not cache:
             return None
 
-        if cache["device_path"] is "-":
+        if cache["device_path"] == "-":
             return None
 
         return Device(path=cache["device_path"])

test/functional/api/cas/cas_packaging.py

@@ -1,6 +1,6 @@
 #
 # Copyright(c) 2022 Intel Corporation
-# Copyright(c) 2024 Huawei Technologies Co., Ltd.
+# Copyright(c) 2024-2025 Huawei Technologies Co., Ltd.
 # SPDX-License-Identifier: BSD-3-Clause
 #
 
@@ -49,7 +49,7 @@ def create(
         arch: str = "",
         source: bool = False,
     ):
-        TestRun.LOGGER.info(f"Creating Open CAS RPM packages")
+        TestRun.LOGGER.info("Creating Open CAS RPM packages")
 
         self.packages_dir = (
             packages_dir or self.packages_dir or os.path.join(sources_dir, "packages")
@@ -79,7 +79,7 @@ def create(
         arch: str = "",
         source: bool = False,
     ):
-        TestRun.LOGGER.info(f"Creating Open CAS DEB packages")
+        TestRun.LOGGER.info("Creating Open CAS DEB packages")
 
         self.packages_dir = (
             packages_dir or self.packages_dir or os.path.join(sources_dir, "packages")

test/functional/api/cas/cli.py

@@ -447,7 +447,7 @@ def script_try_add_cmd(cache_id: str, core_dev: str, core_id: str) -> str:
     command = " --script --add-core --try-add"
     command += " --cache-id " + cache_id
     command += " --core-device " + core_dev
-    command += f" --core-id " + core_id
+    command += "--core-id " + core_id
     return casadm_bin + command
 
 

test/functional/tests/512b/test_different_io_sizes_support.py

@@ -55,7 +55,7 @@ def test_support_different_io_size(cache_mode):
         core.create_filesystem(Filesystem.xfs)
         core.mount(mountpoint)
 
-    with TestRun.step(f"Run fio"):
+    with TestRun.step("Run fio"):
         bs_list = [Size(x, Unit.KibiByte) for x in block_sizes]
 
         fio = (

test/functional/tests/basic/test_basic.py

@@ -51,7 +51,7 @@ def test_cas_version():
 
     with TestRun.step("Compare cmd and file versions"):
         if not all(file_cas_version == cmd_cas_version for cmd_cas_version in cmd_cas_versions):
-            TestRun.LOGGER.error(f"Cmd and file versions doesn't match")
+            TestRun.LOGGER.error("Cmd and file versions doesn't match")
 
 
 @pytest.mark.CI

test/functional/tests/cache_ops/test_attach_detach.py

@@ -14,7 +14,6 @@
 from api.cas.cli import attach_cache_cmd
 from api.cas.cli_messages import check_stderr_msg, attach_with_existing_metadata
 from connection.utils.output import CmdException
-from core.test_run import TestRun
 from core.test_run_utils import TestRun
 from storage_devices.disk import DiskTypeSet, DiskType, DiskTypeLowerThan
 from storage_devices.nullblk import NullBlk
@@ -225,7 +224,7 @@ def test_stop_cache_during_attach(cache_mode):
         core_dev.create_partitions([Size(2, Unit.GibiByte)])
         core_dev = core_dev.partitions[0]
 
-    with TestRun.step(f"Start cache and add core"):
+    with TestRun.step("Start cache and add core"):
         cache = casadm.start_cache(cache_dev, force=True, cache_mode=cache_mode)
         cache.add_core(core_dev)
 
@@ -259,4 +258,4 @@ def _get_random_uniq_cache_line_size(cache_line_size) -> CacheLineSize:
 
 
 def _get_random_uniq_cache_mode(cache_mode) -> CacheMode:
-    return random.choice([c for c in list(CacheMode) if c is not cache_mode])
+    return random.choice([c for c in list(CacheMode) if c is not cache_mode])

test/functional/tests/cache_ops/test_dynamic_cache_mode_switching.py

@@ -61,7 +61,7 @@ def test_cache_stop_and_load(cache_mode):
         core_dev = TestRun.disks["core"]
         core_dev.create_partitions([Size(2, Unit.GibiByte)])
 
-    with TestRun.step(f"Disable udev"):
+    with TestRun.step("Disable udev"):
         Udev.disable()
 
     with TestRun.step(f"Start cache in {cache_mode[0]} mode"):

test/functional/tests/cache_ops/test_multistream_seq_cutoff.py

@@ -57,7 +57,7 @@ def test_multistream_seq_cutoff_functional(streams_number, threshold):
     with TestRun.step("Disable udev"):
         Udev.disable()
 
-    with TestRun.step(f"Start cache in Write-Back cache mode"):
+    with TestRun.step("Start cache in Write-Back cache mode"):
         cache_disk = TestRun.disks["cache"]
         core_disk = TestRun.disks["core"]
         cache = casadm.start_cache(cache_disk, CacheMode.WB, force=True)
@@ -154,16 +154,16 @@ def test_multistream_seq_cutoff_stress_raw(streams_seq_rand):
 
         cache_disk.create_partitions([Size(1.5, Unit.GibiByte)])
 
-    with TestRun.step(f"Disable udev"):
+    with TestRun.step("Disable udev"):
         Udev.disable()
 
-    with TestRun.step(f"Start cache in Write-Back mode and add core"):
+    with TestRun.step("Start cache in Write-Back mode and add core"):
         cache = casadm.start_cache(
             cache_dev=cache_disk.partitions[0], cache_mode=CacheMode.WB, force=True
         )
         core = cache.add_core(core_disk)
 
-    with TestRun.step(f"Set seq-cutoff policy to always and threshold to 512KiB"):
+    with TestRun.step("Set seq-cutoff policy to always and threshold to 512KiB"):
         core.set_seq_cutoff_policy(SeqCutOffPolicy.always)
         core.set_seq_cutoff_threshold(Size(512, Unit.KibiByte))
 

test/functional/tests/cache_ops/test_seq_cutoff.py

@@ -312,7 +312,7 @@ def test_seq_cutoff_thresh(cache_line_size, io_dir, policy, verify_type):
     with TestRun.step("Disable udev"):
         Udev.disable()
 
-    with TestRun.step(f"Start cache and add core"):
+    with TestRun.step("Start cache and add core"):
         cache = casadm.start_cache(
             cache_dev=cache_part,
             force=True,
@@ -396,7 +396,7 @@ def test_seq_cutoff_thresh_fill(cache_line_size, io_dir):
     with TestRun.step("Disable udev"):
         Udev.disable()
 
-    with TestRun.step(f"Start cache and add core"):
+    with TestRun.step("Start cache and add core"):
         cache = casadm.start_cache(
             cache_dev=cache_part,
             force=True,

test/functional/tests/cli/test_cleaning_policy.py

@@ -9,7 +9,6 @@
 
 from core.test_run_utils import TestRun
 from type_def.size import Size, Unit
-from core.test_run import TestRun
 from storage_devices.disk import DiskType, DiskTypeSet, DiskTypeLowerThan
 from test_tools.fio.fio import Fio
 from test_tools.fio.fio_param import ReadWrite, IoEngine
@@ -47,7 +46,7 @@ def test_cleaning_policy_change():
     with TestRun.step("Disable udev"):
         Udev.disable()
 
-    with TestRun.step(f"Start cache in Write-Back mode and set cleaning policy to NOP"):
+    with TestRun.step("Start cache in Write-Back mode and set cleaning policy to NOP"):
         cache = casadm.start_cache(cache_dev, cache_mode=CacheMode.WB, force=True)
         cache.set_cleaning_policy(CleaningPolicy.nop)