enhanced error message for bad PDSC files

bgn42 · bgn42 · commit 45c458b26c2c · 2025-11-12T17:30:02.000+01:00
diff --git a/cmd/installer/root.go b/cmd/installer/root.go
@@ -572,8 +572,7 @@ func InitializeCache() error {
 		}
 		pdscXML := xml.NewPdscXML(pdscFilePath)
 		if err := pdscXML.Read(); err != nil {
-			log.Errorf("Could not retrieve pack's PDSC file from %q", pdscFilePath)
-			return errs.ErrUnknownBehavior
+			return fmt.Errorf("%q: %w", pdscFilePath, err)
 		}
 		releaseTag := pdscXML.FindReleaseTagByVersion("")
 		cacheTag := xml.PdscTag{
@@ -2117,8 +2116,7 @@ func (p *PacksInstallationType) downloadPdscFile(pdscTag xml.PdscTag, skipInstal
 
 	pdscXML := xml.NewPdscXML(pdscFilePath)
 	if err := pdscXML.Read(); err != nil {
-		log.Errorf("Could not retrieve pack's PDSC file from %q", pdscFilePath)
-		return errs.ErrUnknownBehavior
+		return fmt.Errorf("%q: %w", pdscFilePath, err)
 	}
 	releaseTag := pdscXML.FindReleaseTagByVersion("")
 	cacheTag := xml.PdscTag{

Original file line number	Diff line number	Diff line change
`@@ -572,8 +572,7 @@ func InitializeCache() error {`
`572`	`572`	`}`
`573`	`573`	`pdscXML := xml.NewPdscXML(pdscFilePath)`
`574`	`574`	`if err := pdscXML.Read(); err != nil {`
`575`		`- log.Errorf("Could not retrieve pack's PDSC file from %q", pdscFilePath)`
`576`		`- return errs.ErrUnknownBehavior`
	`575`	`+ return fmt.Errorf("%q: %w", pdscFilePath, err)`
`577`	`576`	`}`
`578`	`577`	`releaseTag := pdscXML.FindReleaseTagByVersion("")`
`579`	`578`	`cacheTag := xml.PdscTag{`
`@@ -2117,8 +2116,7 @@ func (p *PacksInstallationType) downloadPdscFile(pdscTag xml.PdscTag, skipInstal`
`2117`	`2116`
`2118`	`2117`	`pdscXML := xml.NewPdscXML(pdscFilePath)`
`2119`	`2118`	`if err := pdscXML.Read(); err != nil {`
`2120`		`- log.Errorf("Could not retrieve pack's PDSC file from %q", pdscFilePath)`
`2121`		`- return errs.ErrUnknownBehavior`
	`2119`	`+ return fmt.Errorf("%q: %w", pdscFilePath, err)`
`2122`	`2120`	`}`
`2123`	`2121`	`releaseTag := pdscXML.FindReleaseTagByVersion("")`
`2124`	`2122`	`cacheTag := xml.PdscTag{`