added a precalculated flag for deprecated date

Author: bgn42

DESIGN.md

@@ -205,6 +205,7 @@ The `configureInstaller` pre-run hook:
 | `list --cached` | Lists packs in `.Download/` |
 | `list --public` | Lists all non-deprecated packs from the public index |
 | `list --public --deprecated` | Lists deprecated packs from the public index |
+| `list --deprecated` | Lists deprecated packs from the public index |
 | `list --updates` | Lists packs with newer versions available |
 | `list --filter` | Filters results (case-sensitive, accepts multiple expressions) |
 | `list-required` | Lists dependencies of installed packs |
@@ -240,12 +241,15 @@ type PacksInstallationType struct {
 - `UpdatePack()` — Updates one or all packs to latest versions
 - `InitializeCache()` — Builds `cache.pidx` from existing PDSC files in `.Web/`
 - `CheckConcurrency()` — Validates and adjusts the concurrent-downloads setting
-- `DownloadPDSCFiles()` — Downloads all PDSC files from the public index in parallel, optionally skipping deprecated packs
+- `DownloadPDSCFiles()` — Downloads all PDSC files from the public
+  index in parallel, optionally skipping deprecated packs
 - `UpdateInstalledPDSCFiles()` — Refreshes already-cached PDSC files from the index
 - `UpdatePublicIndexIfOnline()` — Updates the public index only when connectivity is available
-- `UpdatePublicIndex()` — Downloads and updates the public index and PDSC files, with option to skip deprecated PDSC files
-- `ListInstalledPacks()` — Lists packs with various filter modes; supports `--deprecated` flag to show only deprecated
- packs (hidden by default in `--public` listing)
+- `UpdatePublicIndex()` — Downloads and updates the public index and
+  PDSC files, with option to skip deprecated PDSC files
+- `ListInstalledPacks()` — Lists packs with various filter modes;
+  supports `--deprecated` flag to show only deprecated packs
+  (hidden by default in `--public` listing)
 - `FindPackURL()` — Resolves a pack ID to a download URL from the index
 - `SetPackRoot()` — Initializes the `Installation` singleton and directory paths
 - `ReadIndexFiles()` — Loads `index.pidx`, `local_repository.pidx`, and `cache.pidx`
@@ -331,17 +335,19 @@ type PidxXML struct {
         Pdscs []PdscTag     // List of all pack references
     }
     // Internal lookup maps for O(1) access
-    pdscList     map[string][]int   // key → indices
-    pdscListName map[string][]int   // vendor.name → indices
+    pdscList       map[string][]PdscTag // key → PdscTags
+    pdscListName   map[string]string    // vendor.name → key
+    deprecatedDate time.Time            // today UTC, set once per Read()
 }
 
 type PdscTag struct {
-    URL         string   `xml:"url,attr"`
-    Vendor      string   `xml:"vendor,attr"`
-    Name        string   `xml:"name,attr"`
-    Version     string   `xml:"version,attr"`
-    Deprecated  string   `xml:"deprecated,attr,omitempty"`
-    Replacement string   `xml:"replacement,attr,omitempty"`
+    URL          string `xml:"url,attr"`
+    Vendor       string `xml:"vendor,attr"`
+    Name         string `xml:"name,attr"`
+    Version      string `xml:"version,attr"`
+    Deprecated   string `xml:"deprecated,attr,omitempty"`
+    Replacement  string `xml:"replacement,attr,omitempty"`
+    isDeprecated bool   // cached flag, computed on insert
 }
 ```
 
@@ -361,8 +367,11 @@ type PdscTag struct {
 - `YamlPackID()` — Returns `Vendor::Name@Version` format
 - `PackURL()` — Constructs the full `.pack` download URL (PdscTag method)
 - `PdscFileName()` — Returns the `.pdsc` filename (PdscTag method)
-- `IsDeprecated()` — Returns `true` if the `Deprecated` date (format `YYYY-MM-DD`) is today or in the
- past (PdscTag method)
+- `IsDeprecated()` — Returns the cached deprecated flag.
+  Computed via `computeIsDeprecated()` when a PdscTag is
+  inserted (`Read`, `AddPdsc`, `AddReplacePdsc`).
+  Uses `PidxXML.deprecatedDate` (today UTC, set once per
+  `NewPidxXML`/`Read`) as reference (PdscTag method)
 
 ### 7.2 PDSC — Pack Description (`pdsc.go`)
 
@@ -670,7 +679,8 @@ All errors are predefined constants in `errors.go`, allowing consistent error ch
 Helper functions:
 
 - `Is()` — Wraps `errors.Is()` for convenience
-- `AlreadyLogged()` — Wraps errors to prevent the same message from being logged twice as the error travels up the call stack
+- `AlreadyLogged()` — Wraps errors to prevent the same message from
+  being logged twice as the error travels up the call stack
 
 ---
 

cmd/xml/pidx.go

@@ -33,10 +33,11 @@ type PidxXML struct {
 		Pdscs   []PdscTag `xml:"pdsc"`
 	} `xml:"pindex"`
 
-	pdscList     map[string][]PdscTag // map of PdscTag.Key() to PdscTag
-	pdscListName map[string]string    // map of lowercase Vendor.Pack to PdscTag.Key()
-	fileName     string
-	isCache      bool // to know if this really is a cache index instead of a PDSC index
+	pdscList       map[string][]PdscTag // map of PdscTag.Key() to PdscTag
+	pdscListName   map[string]string    // map of lowercase Vendor.Pack to PdscTag.Key()
+	fileName       string
+	isCache        bool      // to know if this really is a cache index instead of a PDSC index
+	deprecatedDate time.Time // reference date (today UTC) for deprecated evaluation, refreshed once per Read()
 }
 
 // PdscTag maps a <pdsc> tag that goes in PIDX files.
@@ -48,6 +49,8 @@ type PdscTag struct {
 	Version     string   `xml:"version,attr"`
 	Deprecated  string   `xml:"deprecated,attr,omitempty"`
 	Replacement string   `xml:"replacement,attr,omitempty"`
+
+	isDeprecated bool // to mark a tag as deprecated to speed up filtering
 }
 
 // NewPidxXML initializes a new PidxXML object with the given file name.
@@ -63,6 +66,7 @@ func NewPidxXML(fileName string, isCache bool) *PidxXML {
 	p := new(PidxXML)
 	p.fileName = fileName
 	p.isCache = isCache
+	p.deprecatedDate = time.Now().UTC().Truncate(24 * time.Hour)
 	return p
 }
 
@@ -104,6 +108,7 @@ func (p *PidxXML) Clear() {
 func (p *PidxXML) AddPdsc(pdsc PdscTag) error {
 	log.Debugf("Adding pdsc tag %v to %q", pdsc, p.fileName)
 	pdsc.Version = utils.SemverStripMeta(pdsc.Version)
+	pdsc.computeIsDeprecated(p.deprecatedDate)
 	if p.HasPdsc(pdsc) != PdscIndexNotFound {
 		return errs.ErrPdscEntryExists
 	}
@@ -136,6 +141,7 @@ func (p *PidxXML) AddPdsc(pdsc PdscTag) error {
 func (p *PidxXML) AddReplacePdsc(cTag PdscTag) error {
 	log.Debugf("AddReplacePdsc pdsc tag %v to %q", cTag, p.fileName)
 	cTag.Version = utils.SemverStripMeta(cTag.Version)
+	cTag.computeIsDeprecated(p.deprecatedDate)
 	name := strings.ToLower(cTag.VName())
 	key, ok := p.pdscListName[name]
 	if ok {
@@ -402,6 +408,7 @@ func (p *PidxXML) Read() error {
 
 	p.pdscList = make(map[string][]PdscTag)
 	p.pdscListName = make(map[string]string)
+	p.deprecatedDate = time.Now().UTC().Truncate(24 * time.Hour)
 
 	// Create a new empty Pidx file if it does not exist
 	if !utils.FileExists(p.fileName) {
@@ -439,6 +446,7 @@ func (p *PidxXML) Read() error {
 
 	for _, pdsc := range p.Pindex.Pdscs {
 		pdsc.Version = utils.SemverStripMeta(pdsc.Version)
+		pdsc.computeIsDeprecated(p.deprecatedDate)
 		key := pdsc.Key()
 		name := strings.ToLower(pdsc.VName())
 		//		log.Debugf("Registring %q", key)
@@ -503,15 +511,24 @@ func (p *PdscTag) PdscFileName() string {
 	return p.VName() + utils.PdscExtension
 }
 
-// IsDeprecated returns true if the Deprecated field contains a date (YYYY-MM-DD)
-// that is not in the future, i.e. the pack is considered deprecated as of today.
-func (p *PdscTag) IsDeprecated() bool {
+// computeIsDeprecated evaluates the Deprecated date string against the given
+// reference date and caches the result in the isDeprecated field.
+func (p *PdscTag) computeIsDeprecated(refDate time.Time) {
 	if p.Deprecated == "" {
-		return false
+		p.isDeprecated = false
+		return
 	}
 	t, err := time.Parse("2006-01-02", p.Deprecated)
 	if err != nil {
-		return false
+		p.isDeprecated = false
+		return
 	}
-	return !time.Now().UTC().Before(t)
+	p.isDeprecated = !refDate.Before(t)
+}
+
+// IsDeprecated returns the cached deprecated status.
+// The flag is computed when the PdscTag is added to a PidxXML (Read, AddPdsc, AddReplacePdsc)
+// and is based on the reference date set at that time.
+func (p *PdscTag) IsDeprecated() bool {
+	return p.isDeprecated
 }

cmd/xml/pidx_test.go

@@ -57,30 +57,45 @@ func TestPdscTag(t *testing.T) {
 	})
 
 	t.Run("test IsDeprecated with empty string", func(t *testing.T) {
-		pdscTag := xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"}
-		assert.False(pdscTag.IsDeprecated())
+		pidx := xml.NewPidxXML("test.pidx", false)
+		pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"})
+		tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"})
+		assert.Equal(1, len(tags))
+		assert.False(tags[0].IsDeprecated())
 	})
 
 	t.Run("test IsDeprecated with past date", func(t *testing.T) {
-		pdscTag := xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0", Deprecated: "2020-01-01"}
-		assert.True(pdscTag.IsDeprecated())
+		pidx := xml.NewPidxXML("test.pidx", false)
+		pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P1", Version: "1.0.0", Deprecated: "2020-01-01"})
+		tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P1", Version: "1.0.0"})
+		assert.Equal(1, len(tags))
+		assert.True(tags[0].IsDeprecated())
 	})
 
 	t.Run("test IsDeprecated with today's date", func(t *testing.T) {
 		today := time.Now().Format("2006-01-02")
-		pdscTag := xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0", Deprecated: today}
-		assert.True(pdscTag.IsDeprecated())
+		pidx := xml.NewPidxXML("test.pidx", false)
+		pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P2", Version: "1.0.0", Deprecated: today})
+		tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P2", Version: "1.0.0"})
+		assert.Equal(1, len(tags))
+		assert.True(tags[0].IsDeprecated())
 	})
 
 	t.Run("test IsDeprecated with future date", func(t *testing.T) {
 		future := time.Now().AddDate(1, 0, 0).Format("2006-01-02")
-		pdscTag := xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0", Deprecated: future}
-		assert.False(pdscTag.IsDeprecated())
+		pidx := xml.NewPidxXML("test.pidx", false)
+		pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P3", Version: "1.0.0", Deprecated: future})
+		tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P3", Version: "1.0.0"})
+		assert.Equal(1, len(tags))
+		assert.False(tags[0].IsDeprecated())
 	})
 
 	t.Run("test IsDeprecated with invalid date", func(t *testing.T) {
-		pdscTag := xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0", Deprecated: "not-a-date"}
-		assert.False(pdscTag.IsDeprecated())
+		pidx := xml.NewPidxXML("test.pidx", false)
+		pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P4", Version: "1.0.0", Deprecated: "not-a-date"})
+		tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P4", Version: "1.0.0"})
+		assert.Equal(1, len(tags))
+		assert.False(tags[0].IsDeprecated())
 	})
 }