Skip to content

Commit 05218d3

Browse files
committed
Address CodeQL findings
1 parent a9ebb4f commit 05218d3

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

tools/projmgr/src/ProjMgrRunDebug.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,14 @@ bool ProjMgrRunDebug::CollectSettings(const vector<ContextItem*>& contexts) {
9292
}
9393

9494
// outputs
95-
for (const auto& context : contexts) {
96-
auto output = context->outputTypes;
95+
for (const auto& c : contexts) {
96+
auto output = c->outputTypes;
9797
if (output.elf.on) {
98-
RteFsUtils::NormalizePath(output.elf.filename, context->directories.outdir);
98+
RteFsUtils::NormalizePath(output.elf.filename, c->directories.outdir);
9999
m_runDebug.outputs.push_back({ output.elf.filename, RteConstants::OUTPUT_TYPE_ELF });
100100
}
101101
if (output.hex.on) {
102-
RteFsUtils::NormalizePath(output.hex.filename, context->directories.outdir);
102+
RteFsUtils::NormalizePath(output.hex.filename, c->directories.outdir);
103103
m_runDebug.outputs.push_back({ output.hex.filename, RteConstants::OUTPUT_TYPE_HEX });
104104
}
105105
}

tools/projmgr/src/ProjMgrYamlEmitter.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ bool ProjMgrYamlEmitter::WriteFile(YAML::Node& rootNode, const std::string& file
6969
YAML::Emitter emitter;
7070
emitter.SetNullFormat(YAML::EmptyNull);
7171
emitter.SetIntBase(YAML::Hex);
72-
//emitter.SetStringFormat(YAML::DoubleQuoted);
7372
emitter << rootNode;
7473
fileStream << emitter.c_str();
7574
fileStream << endl;

tools/projmgr/test/src/ProjMgrUnitTests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6581,7 +6581,6 @@ TEST_F(ProjMgrUnitTests, TestRunDebug) {
65816581
argv[3] = (char*)"--context-set";
65826582
argv[4] = (char*)"-o";
65836583
argv[5] = (char*)testoutput_folder.c_str();
6584-
//argv[6] = (char*)"-n";
65856584
EXPECT_EQ(0, RunProjMgr(6, argv, m_envp));
65866585

65876586
ProjMgrTestEnv::CompareFile(testoutput_folder + "/TestHW.cbuild-run.yml",

0 commit comments

Comments
 (0)