[packchk] added implicit eXecute attribute when checking for deprecated IRAMx / IROMx (#1195)

Author: thorstendb-ARM

tools/packchk/src/ValidateSemantic.cpp

@@ -277,11 +277,13 @@ bool ValidateSemantic::CheckMemories(RteDeviceItem* device)
         }
       }
 
-      // Check startup attribute
+     // Check startup attribute
      if(startup == "1") {
         rxRegionWithStartup.push_back(memory);
-        if(access.find_first_of("x") == string::npos) {
-          LogMsg("M608", NAME(memoryName), ATTR("startup"), VALUE("1"), ATTR2("access"), VALUE2("x"), lineNo);
+        if(id.find("IROM") != 0 && id.find("IRAM") != 0) {  // no deprecated IRAM / IROM which have eXecute implicitly set
+          if(access.find_first_of("x") == string::npos) {
+            LogMsg("M608", NAME(memoryName), ATTR("startup"), VALUE("1"), ATTR2("access"), VALUE2("x"), lineNo);
+          }
         }
       }
     }

tools/packchk/test/data/MemoryAttributes/TestVendor.MemoryAttributes.pdsc

@@ -42,6 +42,15 @@
 The TestSubFamily is ...
         </description>
 
+        <!-- *************************  TestDeviceOk, old IDs  ************************ -->
+        <device Dname="TestDeviceOkOldIDs">
+          <processor Dcore="Cortex-M4"  DcoreVersion="r0p1" Dfpu="SP_FPU" Dmpu="MPU" Ddsp="NO_DSP" Dendian="Little-endian" Dclock="204000000"/>
+          <memory    id="IROM1"                            start="0x08000000" size="0x00010000" default="1" startup="1"/>
+          <memory    id="IROM2"                            start="0x09000000" size="0x00010000" default="0" />
+          <memory    id="IRAM1"                            start="0x10000000" size="0x00010000" default="1" />
+          <memory    id="IRAM2"                            start="0x20000000" size="0x00010000" default="0" />
+        </device>
+
         <!-- ******************************  TestDeviceOk  ***************************** -->
         <device Dname="TestDeviceOk">
           <processor Dcore="Cortex-M4"  DcoreVersion="r0p1" Dfpu="SP_FPU" Dmpu="MPU" Ddsp="NO_DSP" Dendian="Little-endian" Dclock="204000000"/>