Show "Open Disassembly View" in gutter context menu (#641)

* Add 'vscode-cmsis-debugger.openDisassemblyView' command which wraps VS Code built-in 'debug.action.openDisassemblyView' command.
* Contribute new command to gutter context menu

---------

Signed-off-by: Jens Reinecke <[email protected]>

Author: jreineckearm

package.json

@@ -65,6 +65,12 @@
       ]
     },
     "commands": [
+      {
+        "command": "vscode-cmsis-debugger.openDisassemblyView",
+        "title": "Open Disassembly View",
+        "category": "Run and Debug",
+        "when": "inDebugMode"
+      },
       {
         "title": "CPU Time",
         "shortTitle": "CPU Time",
@@ -143,6 +149,13 @@
           "group": "z_commands"
         }
       ],
+      "editor/lineNumber/context": [
+        {
+          "command": "vscode-cmsis-debugger.openDisassemblyView",
+          "when": "inDebugMode",
+          "group": "z_commands"
+        }
+      ],
       "debug/variables/context": [
         {
           "command": "vscode-cmsis-debugger.liveWatch.addToLiveWatchFromVariablesView",
@@ -158,6 +171,10 @@
         }
       ],
       "commandPalette": [
+        {
+          "command": "vscode-cmsis-debugger.openDisassemblyView",
+          "when": "false"
+        },
         {
           "command": "vscode-cmsis-debugger.showCpuTimeHistory",
           "when": "inDebugMode"

src/desktop/extension.ts

@@ -23,6 +23,7 @@ import { CpuStatesStatusBarItem } from '../features/cpu-states/cpu-states-status
 import { CpuStates } from '../features/cpu-states/cpu-states';
 import { CpuStatesCommands } from '../features/cpu-states/cpu-states-commands';
 import { LiveWatchTreeDataProvider } from '../views/live-watch/live-watch';
+import { GenericCommands } from '../features/generic-commands';
 
 const BUILTIN_TOOLS_PATHS = [
     'tools/pyocd/pyocd',
@@ -32,6 +33,7 @@ const BUILTIN_TOOLS_PATHS = [
 let liveWatchTreeDataProvider: LiveWatchTreeDataProvider;
 
 export const activate = async (context: vscode.ExtensionContext): Promise<void> => {
+    const genericCommands = new GenericCommands();
     const gdbtargetDebugTracker = new GDBTargetDebugTracker();
     const gdbtargetConfigurationProvider = new GDBTargetConfigurationProvider();
     const cpuStates = new CpuStates();
@@ -41,6 +43,8 @@ export const activate = async (context: vscode.ExtensionContext): Promise<void>
     liveWatchTreeDataProvider = new LiveWatchTreeDataProvider(context);
 
     addToolsToPath(context, BUILTIN_TOOLS_PATHS);
+    // Activate generic commands
+    genericCommands.activate(context);
     // Activate components
     gdbtargetDebugTracker.activate(context);
     gdbtargetConfigurationProvider.activate(context);

src/features/generic-commands.test.ts

@@ -0,0 +1,52 @@
+/**
+ * Copyright 2025 Arm Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as vscode from 'vscode';
+import { extensionContextFactory } from '../__test__/vscode.factory';
+import { GenericCommands } from './generic-commands';
+
+describe('GenericCommands', () => {
+    let context: vscode.ExtensionContext;
+    let genericCommands: GenericCommands;
+    let registeredCommands: Map<string, () => Promise<void>>;
+
+    beforeEach(() => {
+        context = extensionContextFactory();
+        genericCommands = new GenericCommands();
+        registeredCommands = new Map();
+        (vscode.commands.registerCommand as jest.Mock).mockImplementation(async (command: string, handler: () => Promise<void>) => {
+            registeredCommands.set(command, handler);
+        });
+        (vscode.commands.executeCommand as jest.Mock).mockImplementation(async (command: string) => {
+            const handler = registeredCommands.get(command);
+            if (handler) {
+                await handler();
+            }
+        });
+    });
+
+    it('registers expected commands', () => {
+        genericCommands.activate(context);
+        expect(vscode.commands.registerCommand as jest.Mock).toHaveBeenCalledWith(GenericCommands.openDisassemblyViewID, expect.any(Function));
+    });
+
+    it('calls \'debug.action.openDisassemblyView\' command', async () => {
+        genericCommands.activate(context);
+        await vscode.commands.executeCommand(GenericCommands.openDisassemblyViewID);
+        expect(vscode.commands.executeCommand as jest.Mock).toHaveBeenCalledWith('debug.action.openDisassemblyView');
+    });
+
+});

src/features/generic-commands.ts

@@ -0,0 +1,33 @@
+/**
+ * Copyright 2025 Arm Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as vscode from 'vscode';
+import { EXTENSION_NAME } from '../manifest';
+
+export class GenericCommands {
+    public static readonly openDisassemblyViewID = `${EXTENSION_NAME}.openDisassemblyView`;
+
+    public activate(context: vscode.ExtensionContext): void {
+        // Register item and command
+        context.subscriptions.push(
+            vscode.commands.registerCommand(GenericCommands.openDisassemblyViewID, () => this.handleOpenDisassemblyView()),
+        );
+    }
+
+    protected async handleOpenDisassemblyView(): Promise<void> {
+        vscode.commands.executeCommand('debug.action.openDisassemblyView');
+    }
+};