Issue #699 bands_from_stac_collection test coverage

Author: soxofaan

openeo/testing/stac.py

@@ -65,6 +65,7 @@ def collection(
         extent: Optional[dict] = None,
         cube_dimensions: Optional[dict] = None,
         summaries: Optional[dict] = None,
+        links: Optional[List[dict]] = None,
     ) -> dict:
         """Create a STAC Collection represented as dictionary."""
         if extent is None:
@@ -77,7 +78,7 @@ def collection(
             "description": description,
             "license": license,
             "extent": extent,
-            "links": [],
+            "links": links or [],
         }
         if cube_dimensions is not None:
             d["cube:dimensions"] = cube_dimensions

tests/test_metadata.py

@@ -1302,6 +1302,112 @@ def test_bands_from_stac_collection(self, data, expected):
         collection = pystac.Collection.from_dict(data)
         assert _StacMetadataParser().bands_from_stac_collection(collection=collection) == expected
 
+    @pytest.mark.parametrize(
+        ["entities", "kwargs", "expected"],
+        [
+            (
+                {
+                    "collection.json": StacDummyBuilder.collection(
+                        stac_version="1.0.0",
+                        links=[
+                            {"rel": "item", "href": "item.json"},
+                        ],
+                    ),
+                    "item.json": StacDummyBuilder.item(
+                        stac_version="1.0.0",
+                        stac_extensions=["https://stac-extensions.github.io/eo/v1.1.0/schema.json"],
+                        properties={
+                            "eo:bands": [{"name": "B02"}, {"name": "B03"}],
+                        },
+                    ),
+                },
+                {},
+                [Band("B02"), Band("B03")],
+            ),
+            (
+                {
+                    "collection.json": StacDummyBuilder.collection(
+                        stac_version="1.0.0",
+                        links=[
+                            {"rel": "item", "href": "item1.json"},
+                            {"rel": "item", "href": "item2.json"},
+                        ],
+                    ),
+                    "item1.json": StacDummyBuilder.item(
+                        stac_version="1.0.0",
+                        stac_extensions=["https://stac-extensions.github.io/eo/v1.1.0/schema.json"],
+                        properties={
+                            "eo:bands": [{"name": "B02"}],
+                        },
+                    ),
+                    "item2.json": StacDummyBuilder.item(
+                        stac_version="1.0.0",
+                        stac_extensions=["https://stac-extensions.github.io/eo/v1.1.0/schema.json"],
+                        properties={
+                            "eo:bands": [{"name": "B03"}],
+                        },
+                    ),
+                },
+                {},
+                [Band("B02"), Band("B03")],
+            ),
+            (
+                {
+                    "collection.json": StacDummyBuilder.collection(
+                        stac_version="1.0.0",
+                        links=[
+                            {"rel": "item", "href": "item10.json"},
+                            {"rel": "item", "href": "item11.json"},
+                        ],
+                    ),
+                    "item10.json": StacDummyBuilder.item(
+                        stac_version="1.0.0",
+                        stac_extensions=["https://stac-extensions.github.io/eo/v1.1.0/schema.json"],
+                        properties={
+                            "eo:bands": [{"name": "B02"}],
+                        },
+                    ),
+                    "item11.json": StacDummyBuilder.item(
+                        stac_version="1.1.0",
+                        properties={
+                            "bands": [{"name": "B03"}],
+                        },
+                    ),
+                },
+                {},
+                [Band("B02"), Band("B03")],
+            ),
+            (
+                {
+                    "collection.json": StacDummyBuilder.collection(
+                        stac_version="1.0.0",
+                        links=[
+                            {"rel": "item", "href": "item.json"},
+                        ],
+                    ),
+                    "item.json": StacDummyBuilder.item(
+                        stac_version="1.0.0",
+                        stac_extensions=["https://stac-extensions.github.io/eo/v1.1.0/schema.json"],
+                        assets={
+                            "asset1": {
+                                "href": "https://stac.test/asset.tif",
+                                "roles": ["data"],
+                                "eo:bands": [{"name": "B02"}],
+                            }
+                        },
+                    ),
+                },
+                {},
+                [Band("B02")],
+            ),
+        ],
+    )
+    def test_bands_from_stac_collection_consult_items(self, tmp_path, entities, kwargs, expected):
+        for name, content in entities.items():
+            (tmp_path / name).write_text(json.dumps(content))
+        collection = pystac.Collection.from_file(tmp_path / "collection.json")
+        assert _StacMetadataParser().bands_from_stac_collection(collection=collection) == expected
+
     @pytest.mark.parametrize(
         ["data", "expected"],
         [