Skip to content

Commit 3e8860f

Browse files
committed
Issue #761 better diff for apex reference check (default ascii_art max_width and aspect ratio)
1 parent ce0cc5f commit 3e8860f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

openeo/testing/results.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,14 @@ def _as_xarray_dataarray(data: Union[str, Path, xarray.DataArray]) -> xarray.Dat
9191
return data
9292

9393

94-
def ascii_art(diff_data: DataArray) -> str:
95-
scale: int = max(1, int(diff_data.sizes["x"] / 100))
94+
def ascii_art(diff_data: DataArray, *, max_width: int = 60, y_vs_x_aspect_ratio=2.5) -> str:
95+
x_scale: int = max(1, int(diff_data.sizes["x"] / max_width))
96+
y_scale: int = max(1, int(diff_data.sizes["x"] / (max_width * y_vs_x_aspect_ratio)))
9697
data_max = diff_data.max().item()
9798
if data_max == 0:
9899
data_max = 1
99100
grayscale_characters = "$@B%8&WM#*oahkbdpqwmZO0QLCJUYXzcvunxrjft/\|()1{}[]?-_+~<>i!lI;:,\"^`'. "
100-
coarsened = diff_data.coarsen(dim={"x": scale, "y": scale}, boundary="pad").mean()
101+
coarsened = diff_data.coarsen(dim={"x": x_scale, "y": y_scale}, boundary="pad").mean()
101102
coarsened = coarsened.transpose("y", "x", ...)
102103
top = "┌" + "─" * coarsened.sizes["x"] + "┐\n"
103104
bottom = "\n└" + "─" * coarsened.sizes["x"] + "┘"

0 commit comments

Comments
 (0)