Issue #738 todo notes about lack of urllib/pystac mocking

mark places were we currently workaround the lack of proper pystac/urllib mocking

Author: soxofaan

tests/rest/test_connection.py

@@ -2891,12 +2891,11 @@ def test_load_stac_from_job_empty_result(self, con120, requests_mock):
 
     @pytest.mark.parametrize("temporal_dim", ["t", "datezz"])
     def test_load_stac_reduce_temporal(self, con120, tmp_path, temporal_dim):
-        # TODO: reusable utility to create/generate a STAC resource for testing
-        #       (a file, but preferably a URL, but that requires urllib mocking)
         stac_path = tmp_path / "stac.json"
         stac_data = StacDummyBuilder.collection(
             cube_dimensions={temporal_dim: {"type": "temporal", "extent": ["2024-01-01", "2024-04-04"]}}
         )
+        # TODO #738 real request mocking of STAC resources compatible with pystac?
         stac_path.write_text(json.dumps(stac_data))
 
         cube = con120.load_stac(str(stac_path))
@@ -2952,6 +2951,7 @@ def test_load_stac_no_cube_extension_temporal_dimension(self, con120, tmp_path,
         # No cube:dimensions, but at least "temporal" extent is set as indicator for having a temporal dimension
         assert "cube:dimensions" not in stac_data
         assert deep_get(stac_data, "extent", "temporal")
+        # TODO #738 real request mocking of STAC resources compatible with pystac?
         stac_path.write_text(json.dumps(stac_data))
 
         cube = con120.load_stac(str(stac_path))
@@ -2962,6 +2962,7 @@ def test_load_stac_band_filtering(self, con120, tmp_path):
         stac_data = StacDummyBuilder.collection(
             summaries={"eo:bands": [{"name": "B01"}, {"name": "B02"}, {"name": "B03"}]}
         )
+        # TODO #738 real request mocking of STAC resources compatible with pystac?
         stac_path.write_text(json.dumps(stac_data))
 
         cube = con120.load_stac(str(stac_path))

tests/test_metadata.py

@@ -844,6 +844,7 @@ def filter_bbox(self, bbox):
 )
 def test_metadata_from_stac_bands(tmp_path, test_stac, expected):
     path = tmp_path / "stac.json"
+    # TODO #738 real request mocking of STAC resources compatible with pystac?
     path.write_text(json.dumps(test_stac))
     metadata = metadata_from_stac(str(path))
     assert metadata.band_names == expected
@@ -925,6 +926,7 @@ def test_metadata_from_stac_collection_bands_from_item_assets(test_data, tmp_pat
 )
 def test_metadata_from_stac_temporal_dimension(tmp_path, stac_dict, expected):
     path = tmp_path / "stac.json"
+    # TODO #738 real request mocking of STAC resources compatible with pystac?
     path.write_text(json.dumps(stac_dict))
     metadata = metadata_from_stac(str(path))
     if expected: