Add test and add to changelog. Open-EO/openeo-geopyspark-driver#877

Author: EmileSonneveld

CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `MultiBackendJobManager`: Fix issue with duplicate job starting across multiple backends ([#654](https://github.com/Open-EO/openeo-python-client/pull/654))
 - `MultiBackendJobManager`: Fix encoding issue of job metadata in `on_job_done` ([#657](https://github.com/Open-EO/openeo-python-client/issues/657))
 - `MultiBackendJobManager`: Avoid `SettingWithCopyWarning` ([#641](https://github.com/Open-EO/openeo-python-client/issues/641))
+- Avoid creating empty file if asset download request failed.
 
 
 ## [0.34.0] - 2024-10-31

tests/rest/test_job.py

@@ -606,6 +606,24 @@ def test_result_asset_download_file(con100, requests_mock, tmp_path):
         assert f.read() == TIFF_CONTENT
 
 
+def test_result_asset_download_file_error(con100, requests_mock, tmp_path):
+    href = API_URL + "/dl/jjr1.tiff"
+    requests_mock.get(href, content=TIFF_CONTENT)
+    href_404 = API_URL + "/dl/non-existing-url.tiff"
+
+    job = BatchJob("jj", connection=con100)
+    asset = ResultAsset(job, name="1.tiff", href=href_404, metadata={"type": "image/tiff; application=geotiff"})
+    target = tmp_path / "res.tiff"
+    path = target
+    # noinspection PyBroadException
+    try:
+        path = asset.download(target)
+    except:
+        pass
+    assert not target.exists()
+    assert not path.exists()
+
+
 def test_result_asset_download_folder(con100, requests_mock, tmp_path):
     href = API_URL + "/dl/jjr1.tiff"
     requests_mock.get(href, content=TIFF_CONTENT)