remove (now) unused ProcessSpec.to_dict_040 #47

Author: soxofaan

openeo_driver/processes.py

@@ -60,23 +60,6 @@ def returns(self, description: str, schema: dict) -> 'ProcessSpec':
         self._returns = {"description": description, "schema": schema}
         return self
 
-    def to_dict_040(self) -> dict:
-        """Generate process spec as (JSON-able) dictionary (API 0.4.0 style)."""
-        # TODO #47 drop this
-        if len(self._parameters) == 0:
-            _log.debug("Process with no parameters")
-        assert self._returns is not None
-        return {**self.extra, **{
-            "id": self.id,
-            "description": self.description,
-            "parameters": {
-                p.name: {"description": p.description, "schema": p.schema, "required": p.required}
-                for p in self._parameters
-            },
-            "parameter_order": [p.name for p in self._parameters],
-            "returns": self._returns
-        }}
-
     def to_dict_100(self) -> dict:
         """Generate process spec as (JSON-able) dictionary (API 1.0.0 style)."""
         if len(self._parameters) == 0:

tests/test_processes.py

@@ -15,31 +15,6 @@
 from openeo_driver.processes import ProcessArgs, ProcessRegistry, ProcessRegistryException, ProcessSpec
 
 
-def test_process_spec_basic_040():
-    spec = (
-        ProcessSpec("mean", "Mean value")
-            .param("input", "Input data", schema={"type": "array", "items": {"type": "number"}})
-            .param("mask", "The mask", schema=ProcessSpec.RASTERCUBE, required=False)
-            .returns("Mean value of data", schema={"type": "number"})
-    )
-    assert spec.to_dict_040() == {
-        "id": "mean",
-        "description": "Mean value",
-        "parameters": {
-            "input": {
-                "description": "Input data",
-                "required": True,
-                "schema": {"type": "array", "items": {"type": "number"}}
-            },
-            "mask": {
-                "description": "The mask",
-                "required": False,
-                "schema": {"type": "object", "format": "raster-cube"}
-            }
-        },
-        "parameter_order": ["input", "mask"],
-        "returns": {"description": "Mean value of data", "schema": {"type": "number"}},
-    }
 
 
 def test_process_spec_basic_100():
@@ -70,19 +45,6 @@ def test_process_spec_basic_100():
     }
 
 
-def test_process_spec_no_params_040(caplog):
-    caplog.set_level(logging.DEBUG)
-    spec = ProcessSpec("foo", "bar").returns("output", schema={"type": "number"})
-    assert spec.to_dict_040() == {
-        "id": "foo",
-        "description": "bar",
-        "parameters": {},
-        "parameter_order": [],
-        "returns": {"description": "output", "schema": {"type": "number"}},
-    }
-    assert caplog.messages == ["Process with no parameters"]
-
-
 def test_process_spec_no_params_100(caplog):
     caplog.set_level(logging.DEBUG)
     spec = ProcessSpec("foo", "bar").returns("output", schema={"type": "number"})
@@ -269,34 +231,6 @@ def max(*args):
     }
 
 
-def test_process_registry_with_spec_040():
-    reg = ProcessRegistry()
-
-    def add_function_with_spec(spec: ProcessSpec):
-        def decorator(f):
-            reg.add_function(f=f, spec=spec.to_dict_040())
-            return f
-
-        return decorator
-
-    @add_function_with_spec(
-        ProcessSpec("foo", "bar")
-            .param("input", "Input", schema=ProcessSpec.RASTERCUBE)
-            .returns(description="Output", schema=ProcessSpec.RASTERCUBE)
-    )
-    def foo(*args):
-        return 42
-
-    assert reg.get_spec('foo') == {
-        "id": "foo",
-        "description": "bar",
-        "parameters": {
-            "input": {"description": "Input", "schema": {"type": "object", "format": "raster-cube"},
-                      "required": True},
-        },
-        "parameter_order": ["input"],
-        "returns": {"description": "Output", "schema": {"type": "object", "format": "raster-cube"}}
-    }
 
 
 def test_process_registry_with_spec_100():