Harden bands metadata in batch job results Open-EO/openeo-aggregator#183

Author: soxofaan

CHANGELOG.md

@@ -30,6 +30,7 @@ and start a new "In Progress" section above it.
 - Allow `overlap` in `apply_neighborhood` to be not specified ([#401](https://github.com/Open-EO/openeo-python-driver/issues/401))
 - Start including STAC-1.1.0-style "bands" metadata in assets in batch job results ([#298](https://github.com/Open-EO/openeo-python-driver/issues/298))
 - Start including STAC-1.1.0-style "bands" summaries in collection metadata ([#298](https://github.com/Open-EO/openeo-python-driver/issues/298))
+- Harden "bands" metadata handling in batch job results listings ([Open-EO/openeo-aggregator#183](https://github.com/Open-EO/openeo-aggregator/issues/183))
 
 
 ## 0.133.0

openeo_driver/dummy/dummy_backend.py

@@ -826,7 +826,7 @@ def get_result_assets(self, job_id: str, user_id: str) -> Dict[str, dict]:
                     "roles": ["data"],
                     "type": "text/csv",
                     "href": "s3://OpenEO-data/batch_jobs/j-2406047c20fc4966ab637d387502728f/timeseries.csv",
-                    "bands": [Band(name="S2-L2A-EVI_t0"), Band(name="S2-L2A-EVI_t1"), Band(name="S2-L2A-EVI_t2")],
+                    "bands": [Band(name="S2-L2A-EVI_t0"), Band(name="S2-L2A-EVI_t1"), {"name": "S2-L2A-EVI_t2"}],
                     "geometry": {"type": "Polygon",
                                  "coordinates": [[[2.70964374625748, 51.00377983772219],
                                                   [2.70964374625748, 51.10589339112414],

openeo_driver/views.py

@@ -25,6 +25,7 @@
     send_from_directory,
     url_for,
 )
+import openeo.metadata
 from openeo.util import Rfc3339, TimingLogger, deep_get, dict_no_none, rfc3339
 from openeo.utils.version import ComparableVersion
 from pyproj import CRS
@@ -1535,6 +1536,22 @@ def _asset_object(job_id, user_id, filename: str, asset_metadata: dict, job_info
         bands = asset_metadata.get("bands")
 
         if bands:
+            # TODO: #298 this is a quick stop-gap solution for lack of clear API
+            #       what "bands" actually is expected to be:
+            #       a list of Band objects (current approach in openeo-geopyspark-driver)
+            #       or a list of dictionaries (as handled in openeo-aggregator)
+            # TODO: move this normalization to a more general utility?
+            bands = [
+                openeo.metadata.Band(
+                    name=b.get("name"),
+                    common_name=b.get("eo:common_name") or b.get("common_name"),
+                    wavelength_um=b.get("eo:center_wavelength") or b.get("center_wavelength"),
+                )
+                if isinstance(b, dict)
+                else b
+                for b in bands
+            ]
+
             # TODO: eliminate this legacy "eo:bands" construct at some point?
             result_dict["eo:bands"] = [
                 dict_no_none(