Update to slnx (#705)

* Update to slnx

This upgrades all the solution files to the new Solution Format .slnx

* Use .slnx in the builds

* Update README.md and CodeQL

* Address PR feedback

Removed FileIO as BuildDependency for KscViewer
Added sync-submodule dependency to fetch-argparse.vcxproj

* Delete old .sln files

---------

Co-authored-by: twostars <i.am.twostars@gmail.com>

Author: stefannikolei

.github/workflows/build_msbuild_all.yml

@@ -20,8 +20,8 @@ on:
       - '**/*.hpp'
       - '**/*.vcxproj'
       - 'deps/**'
-      - 'All.sln'
-      - 'ThirdParty.sln'
+      - 'All.slnx'
+      - 'ThirdParty.slnx'
 
   pull_request:
     branches:
@@ -37,8 +37,8 @@ on:
       - '**/*.hpp'
       - '**/*.vcxproj'
       - 'deps/**'
-      - 'All.sln'
-      - 'ThirdParty.sln'
+      - 'All.slnx'
+      - 'ThirdParty.slnx'
 
   merge_group: 
   workflow_dispatch:
@@ -70,22 +70,22 @@ jobs:
 
     # NOTE: We could simply run All.sln, but it makes it far more obvious in the Github output when it's broken up across its solutions.
     - name: Build third party dependencies
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" ThirdParty.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" ThirdParty.slnx
 
     - name: Build client
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Client.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Client.slnx
 
     - name: Build server
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Server.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Server.slnx
 
     - name: Build tools
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Tools.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Tools.slnx
 
     - name: Build client tools
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" ClientTools.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" ClientTools.slnx
 
     - name: Build tests
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Tests.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Tests.slnx
 
     - name: Run tests - MathUtils
       shell: cmd

.github/workflows/build_msbuild_client.yml

@@ -43,4 +43,4 @@ jobs:
 
     - name: Build client
       working-directory: ${{env.GITHUB_WORKSPACE}}
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Client.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" Client.slnx

.github/workflows/build_msbuild_client_tools.yml

@@ -43,4 +43,4 @@ jobs:
       uses: microsoft/setup-msbuild@v2
 
     - name: Build tools
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" ClientTools.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" ClientTools.slnx

.github/workflows/build_msbuild_server.yml

@@ -42,4 +42,4 @@ jobs:
       uses: microsoft/setup-msbuild@v2
 
     - name: Build server
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" Server.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" Server.slnx

.github/workflows/build_msbuild_tools.yml

@@ -42,4 +42,4 @@ jobs:
       uses: microsoft/setup-msbuild@v2
 
     - name: Build tools
-      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" Tools.sln
+      run: msbuild /p:Configuration="${{matrix.BUILD_CONFIGURATION}}" /p:Platform="${{matrix.BUILD_PLATFORM}}" Tools.slnx

.github/workflows/codeql.yml

@@ -42,7 +42,7 @@ jobs:
     # as needed from within All.sln; this ensures they're built first so they won't build again during
     # CodeQL monitoring.
     - name: Build third party dependencies
-      run: msbuild /p:Configuration="${{env.BUILD_CONFIGURATION}}" /p:Platform="${{env.BUILD_PLATFORM}}" ThirdParty.sln
+      run: msbuild /p:Configuration="${{env.BUILD_CONFIGURATION}}" /p:Platform="${{env.BUILD_PLATFORM}}" ThirdParty.slnx
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
@@ -52,7 +52,7 @@ jobs:
         build-mode: manual
 
     - name: Build all
-      run: msbuild /p:Configuration="${{env.BUILD_CONFIGURATION}}" /p:Platform="${{env.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" All.sln
+      run: msbuild /p:Configuration="${{env.BUILD_CONFIGURATION}}" /p:Platform="${{env.BUILD_PLATFORM}}" /p:NO_CLIENT_ASSETS="1" All.slnx
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v3