* Protect gold, bank gold, loyalty, and manner changes with CurrencyChange

* Remove StripEvtComment to handle using string_views instead

Author: kenner2

src/Server/Ebenezer/AISocket.cpp

@@ -1129,7 +1129,7 @@ void CAISocket::RecvUserExp(char* pBuf)
 		return;
 	}
 
-	pUser->m_pUserData->m_iLoyalty += sLoyalty;
+	CurrencyChange(pUser->m_pUserData->m_iLoyalty, sLoyalty);
 	pUser->ExpChange(sExp);
 
 	if (sLoyalty > 0)

src/Server/Ebenezer/EXEC.cpp

@@ -22,10 +22,14 @@ bool EXEC::Parse(const char* line, const std::string& filename, int lineNumber)
 	bool handled = true;
 	char temp[1024] {};
 
-	std::string commentStripped = StripEvtComment(line);
-	ParseSpace(temp, commentStripped.c_str(), index);
-
-	size_t opcode = hashing::djb2::hash(std::string_view(temp));
+	ParseSpace(temp, line, index);
+	std::string_view tempView(temp);
+	size_t commentPosition = tempView.find(';');
+	size_t opcode;
+	if (commentPosition != std::string::npos)
+		opcode = hashing::djb2::hash(tempView.substr(0, commentPosition));
+	else
+		opcode = hashing::djb2::hash(tempView);
 	switch (opcode)
 	{
 		// E SAY {'up' event ID} {'ok' event ID} {talk ID 1} {talk ID 2} {talk ID 3} {talk ID 4} {talk ID 5} {talk ID 6} {talk ID 7} {talk ID 8}

src/Server/Ebenezer/EbenezerApp.cpp

@@ -2514,7 +2514,7 @@ void EbenezerApp::BattleZoneVictoryCheck()
 		if (pTUser->m_pUserData->m_bNation == m_bVictory
 			// Zone Check!
 			&& pTUser->m_pUserData->m_bZone == pTUser->m_pUserData->m_bNation)
-			pTUser->m_pUserData->m_iGold += AWARD_GOLD; // Target is in the area.
+			CurrencyChange(pTUser->m_pUserData->m_iGold, AWARD_GOLD); // Target is in the area.
 	}
 }
 

src/Server/Ebenezer/KnightsManager.cpp

@@ -896,8 +896,9 @@ void CKnightsManager::ReceiveKnightsProcess(CUser* pUser, const char* pBuf, uint
 
 void CKnightsManager::RecvCreateKnights(CUser* pUser, const char* pBuf)
 {
+	static constexpr uint32_t CLAN_CREATE_COST = 500'000;
 	int index = 0, sendIndex = 0, namelen = 0, idlen = 0, knightsindex = 0, nation = 0,
-		community = 0, money = 0;
+		community      = 0;
 	CKnights* pKnights = nullptr;
 	char sendBuffer[128] {}, knightsname[MAX_ID_SIZE + 1] {}, chiefname[MAX_ID_SIZE + 1] {};
 
@@ -931,8 +932,7 @@ void CKnightsManager::RecvCreateKnights(CUser* pUser, const char* pBuf)
 
 	pUser->m_pUserData->m_bKnights = knightsindex;
 	pUser->m_pUserData->m_bFame    = KNIGHTS_DUTY_CHIEF;
-	money                          = pUser->m_pUserData->m_iGold - 500000;
-	pUser->m_pUserData->m_iGold    = money;
+	CurrencyChange(pUser->m_pUserData->m_iGold, -CLAN_CREATE_COST);
 
 	for (int i = 0; i < MAX_CLAN; i++)
 	{
@@ -968,7 +968,7 @@ void CKnightsManager::RecvCreateKnights(CUser* pUser, const char* pBuf)
 	SetString(sendBuffer, knightsname, namelen, sendIndex);
 	SetByte(sendBuffer, 5, sendIndex); // knights grade
 	SetByte(sendBuffer, 0, sendIndex);
-	SetDWORD(sendBuffer, money, sendIndex);
+	SetDWORD(sendBuffer, pUser->m_pUserData->m_iGold, sendIndex);
 	m_pMain->Send_Region(sendBuffer, sendIndex, pUser->m_pUserData->m_bZone, pUser->m_RegionX,
 		pUser->m_RegionZ, nullptr, false);
 	//pUser->Send( sendBuffer, sendIndex );

src/Server/Ebenezer/LOGIC_ELSE.cpp

@@ -34,10 +34,14 @@ bool LOGIC_ELSE::Parse_and(const char* line, const std::string& filename, int li
 	bool handled = true;
 	char temp[1024] {};
 
-	std::string commentStripped = StripEvtComment(line);
-	ParseSpace(temp, commentStripped.c_str(), index);
-
-	size_t opcode = hashing::djb2::hash(std::string_view(temp));
+	ParseSpace(temp, line, index);
+	std::string_view tempView(temp);
+	size_t commentPosition = tempView.find(';');
+	size_t opcode;
+	if (commentPosition != std::string::npos)
+		opcode = hashing::djb2::hash(tempView.substr(0, commentPosition));
+	else
+		opcode = hashing::djb2::hash(tempView);
 	switch (opcode)
 	{
 		// A CHECK_UNDER_WEIGHT