CN3BaseFileAccess: Release() when a file fails to load (#808)

This ensures that it isn't in a failed state, which can happen due to exceptions being thrown.

Author: twostars

src/N3Base/N3BaseFileAccess.cpp

@@ -109,7 +109,8 @@ bool CN3BaseFileAccess::LoadFromFile()
 
 	try
 	{
-		return LoadSupportedVersions(file);
+		if (LoadSupportedVersions(file))
+			return true;
 	}
 	catch (const std::exception& ex)
 	{
@@ -122,6 +123,9 @@ bool CN3BaseFileAccess::LoadFromFile()
 #endif
 	}
 
+	// File failed to load. To avoid it being in an unexpected inconsistent state,
+	// we should release it.
+	Release();
 	return false;
 }
 

src/Server/shared-server/SharedMemoryBlock.cpp

@@ -74,9 +74,11 @@ char* SharedMemoryBlock::Open(const std::string& name)
 	catch (const interprocess_exception& ex)
 	{
 		if (ex.get_error_code() != not_found_error)
+		{
 			spdlog::error("SharedMemoryBlock::Open: failed to open existing shared memory block. "
 						  "name='{}' ex={}",
 				name, ex.what());
+		}
 	}
 
 	return nullptr;