Skip to content

Commit 25e0001

Browse files
author
divaajainn
committed
remove cred from keyring (msui)
1 parent e71f2d5 commit 25e0001

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

mslib/mscolab/file_manager.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
from mslib.utils.verify_waypoint_data import verify_waypoint_data
4040
from mslib.mscolab.models import db, Operation, Permission, User, Change, Message
4141
from mslib.mscolab.conf import mscolab_settings
42-
from mslib.utils.auth import del_password_from_keyring
43-
from mslib.utils.config import config_loader
4442

4543

4644
class FileManager:
@@ -235,8 +233,6 @@ def modify_user(self, user, attribute=None, value=None, action=None):
235233
# Delete profile image if it exists
236234
if user.profile_image_path:
237235
self.delete_user_profile_image(user.profile_image_path)
238-
mscolab_server_url = config_loader(dataset="default_MSCOLAB")
239-
del_password_from_keyring(service_name=mscolab_server_url[0], username=user.emailid)
240236
db.session.delete(user)
241237
db.session.commit()
242238
user_query = User.query.filter_by(id=user.id).first()

mslib/msui/mscolab.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
from PyQt5.QtWidgets import QDialog, QFileDialog, QMessageBox
6262
from PyQt5.QtGui import QPixmap
6363

64-
from mslib.utils.auth import get_password_from_keyring, save_password_to_keyring
64+
from mslib.utils.auth import get_password_from_keyring, save_password_to_keyring, del_password_from_keyring
6565
from mslib.utils.verify_user_token import verify_user_token as _verify_user_token
6666
from mslib.utils.verify_waypoint_data import verify_waypoint_data
6767
from mslib.utils.qt import get_open_filename, get_save_filename, dropEvent, dragEnterEvent, show_popup
@@ -937,6 +937,7 @@ def delete_account(self, _=None):
937937
if reply == QMessageBox.No:
938938
return
939939
try:
940+
del_password_from_keyring(self.mscolab_server_url, self.email)
940941
response = self.conn.request_post("delete_own_account")
941942
except requests.exceptions.RequestException as ex:
942943
raise MSColabConnectionError(f"Some error occurred ({ex})! Please reconnect.")

0 commit comments

Comments
 (0)