Skip to content

Commit ed687ce

Browse files
authored
docker urls updated (#45)
1 parent 502b345 commit ed687ce

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

docs/_posts/2021-01-27-automated-testing.markdown

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,27 @@ Implementing automatic testing required multiple steps to be done effectively.
1010

1111
Not wanting tests to fail due to updated packages or similar environmental issues,
1212
the first step was to create a docker image in which MSS is guaranteed to run.
13-
Dockerfiles were created over at the [Open-MSS/dockerhub](https://github.com/Open-MSS/dockerhub) repository on Github.
13+
Dockerfiles were created over at the [Open-MSS/dockerhub](https://github.com/Open-MSS/dockerhub) repository on GitHub.
1414
One image for testing, one image of the develop branch of MSS and one image containing the latest stable release of MSS.
15-
All of these images can be found publicly on the [yourmss](https://hub.docker.com/u/yourmss) dockerhub account.
15+
All of these images can be found publicly on the [openmss](https://hub.docker.com/u/openmss) dockerhub account.
1616

1717
The second step was to automatically build and test each of these images every day, to make sure they are all up-to-date and working.
1818
This was realised through GitHub Actions. Via a scheduled Action, every image is getting built using their respective Dockerfile.
19-
Afterwards, MSS is getting tested on them through pytest, and finally, if there were no errors during this process, the images get uploaded to dockerhub.
19+
Afterward, MSS is getting tested on them through pytest, and finally, if there were no errors during this process, the images get uploaded to dockerhub.
2020

2121
The final step was to use the docker images for automated testing on each push and pull request on the Open-MSS/MSS repository.
2222
This was also done through GitHub Actions. Every push and every pull request triggers an Action to run.
23-
This Action pulls the latest testing image from [yourmss/mss-test](https://hub.docker.com/r/yourmss/mss-test) and
23+
This Action pulls the latest testing image from [openmss/testing-develop](https://hub.docker.com/r/openmss/testing-develop) and
2424
runs the changed code through pytest.
2525

2626
In the end three things were accomplished:
27-
1. There is always a working docker image for MSS over at https://hub.docker.com/u/yourmss
28-
2. If environmental changes, like package updates, break MSS, this will be visible at the daily image creation over at [Open-MSS/dockerhub](https://github.com/Open-MSS/dockerhub/actions?query=workflow%3A%22Update+image%22)
27+
1. There is always a working docker image for MSS over at https://hub.docker.com/u/openmss
28+
2. If environmental changes, like package updates, break MSS, this will be visible at the [scheduled test at](https://github.com/Open-MSS/MSS/actions/workflows/testing-scheduled.yml)
2929
3. Every push and pull request gets tested, and if the test fails, it is a clear sign of issues in the code, not in the environment
30+
31+
32+
33+
### Update 2024-10-31
34+
- Urls to DockerHub updated
35+
- Url for scheduled test updated
36+
- Typos corrected

0 commit comments

Comments
 (0)