Enforce explicit type declarations and update coding styles

Updated .editorconfig to include new style rules for C# coding conventions.
Replaced `var` with explicit type declarations across multiple files to improve
code readability and maintainability. Added `ConfigureAwait(false)` to some
`await` calls to avoid potential deadlocks. Made minor formatting adjustments
and clarified access levels of classes and methods. Updated `NoWarn` property
in the project file to include `IDE0079`.

Author: electricessence

.editorconfig

@@ -74,8 +74,8 @@ dotnet_style_allow_statement_immediately_after_block_experimental = false
 #### C# Coding Conventions ####
 
 # var preferences
-csharp_style_var_elsewhere = false
-csharp_style_var_for_built_in_types = false
+csharp_style_var_elsewhere = false:silent
+csharp_style_var_for_built_in_types = false:silent
 csharp_style_var_when_type_is_apparent = true:suggestion
 
 # Expression-bodied members
@@ -99,7 +99,7 @@ csharp_style_prefer_switch_expression = true:suggestion
 csharp_style_conditional_delegate_call = true:warning
 
 # Modifier preferences
-csharp_prefer_static_local_function = true
+csharp_prefer_static_local_function = true:suggestion
 csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
 
 # Code-block preferences
@@ -108,14 +108,14 @@ csharp_prefer_simple_using_statement = true:suggestion
 csharp_style_namespace_declarations = file_scoped:suggestion
 
 # Expression-level preferences
-csharp_prefer_simple_default_expression = true
-csharp_style_deconstructed_variable_declaration = true
-csharp_style_implicit_object_creation_when_type_is_apparent = true
-csharp_style_inlined_variable_declaration = true
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
 csharp_style_pattern_local_over_anonymous_function = true
 csharp_style_prefer_index_operator = true:silent
 csharp_style_prefer_null_check_over_type_check = true:warning
-csharp_style_prefer_range_operator = true:silent
+csharp_style_prefer_range_operator = false:silent
 csharp_style_throw_expression = true:warning
 csharp_style_unused_value_assignment_preference = discard_variable:suggestion
 csharp_style_unused_value_expression_statement_preference = discard_variable:silent
@@ -125,8 +125,8 @@ csharp_using_directive_placement = outside_namespace:warning
 
 # New line preferences
 csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = false:warning
-csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
-csharp_style_allow_embedded_statements_on_same_line_experimental = true
+csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true:silent
+csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent
 
 #### C# Formatting Rules ####
 
@@ -225,6 +225,16 @@ dotnet_diagnostic.IDE0290.severity = silent
 csharp_style_prefer_method_group_conversion = true:silent
 csharp_style_prefer_top_level_statements = true:silent
 csharp_style_prefer_primary_constructors = true:suggestion
+csharp_prefer_system_threading_lock = true:suggestion
+csharp_style_prefer_local_over_anonymous_function = true:suggestion
+csharp_style_prefer_tuple_swap = true:suggestion
+csharp_style_prefer_utf8_string_literals = true:suggestion
+csharp_prefer_static_anonymous_function = true:warning
+csharp_style_prefer_readonly_struct = true:error
+csharp_style_prefer_readonly_struct_member = true:suggestion
+csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = false:error
+csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = false:error
+csharp_style_prefer_extended_property_pattern = true:suggestion
 
 [*.{cs,vb}]
 dotnet_style_operator_placement_when_wrapping = beginning_of_line
@@ -243,4 +253,27 @@ dotnet_style_prefer_conditional_expression_over_assignment = true:warning
 dotnet_style_prefer_conditional_expression_over_return = true:warning
 dotnet_style_explicit_tuple_names = true:suggestion
 dotnet_diagnostic.CA1510.severity = none
-dotnet_code_quality_unused_parameters = all:suggestion
+dotnet_code_quality_unused_parameters = all:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_compound_assignment = true:suggestion
+dotnet_style_prefer_simplified_interpolation = true:suggestion
+dotnet_style_namespace_match_folder = true:suggestion
+dotnet_style_readonly_field = true:suggestion
+dotnet_style_predefined_type_for_locals_parameters_members = true:warning
+dotnet_style_predefined_type_for_member_access = true:warning
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+dotnet_style_allow_multiple_blank_lines_experimental = true:silent
+dotnet_style_allow_statement_immediately_after_block_experimental = false:silent
+dotnet_style_parentheses_in_arithmetic_binary_operators = never_if_unnecessary:suggestion
+dotnet_style_parentheses_in_other_binary_operators = never_if_unnecessary:suggestion
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:suggestion
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:suggestion
+dotnet_style_qualification_for_field = false:silent
+dotnet_style_qualification_for_property = false:suggestion
+dotnet_style_qualification_for_method = false:suggestion
+dotnet_style_qualification_for_event = false:suggestion
+dotnet_diagnostic.CA1832.severity = silent
+dotnet_diagnostic.CA1833.severity = silent
+dotnet_diagnostic.CA1831.severity = silent
+dotnet_diagnostic.IDE0058.severity = silent

Open.ChannelExtensions.ComparisonTests/Program.cs

@@ -109,7 +109,7 @@ await Enumerable
 		{
 			Console.WriteLine("Async Enumerable test...");
 			var sw = Stopwatch.StartNew();
-			await foreach (var e in Enumerable
+			await foreach (int e in Enumerable
 				.Repeat(Delay, repeat)
 				.Select((t, i) => t(i))
 				.ToChannelAsync()

Open.ChannelExtensions.Tests/AssumptionTests.cs

@@ -10,7 +10,7 @@ public static async Task WaitCancellation()
 		{
 			CancellationToken token = tokenSource.Token;
 
-			var t = channel.Reader.WaitToReadAsync(token);
+			ValueTask<bool> t = channel.Reader.WaitToReadAsync(token);
 			tokenSource.Cancel();
 
 			// NOTE: a cancelled WaitToReadAsync will throw. 
@@ -21,8 +21,8 @@ public static async Task WaitCancellation()
 		{
 			CancellationToken token = tokenSource.Token;
 
-			var t1 = channel.Reader.WaitToReadAsync(token);
-			var t2 = channel.Reader.WaitToReadAsync();
+			ValueTask<bool> t1 = channel.Reader.WaitToReadAsync(token);
+			ValueTask<bool> t2 = channel.Reader.WaitToReadAsync();
 			tokenSource.Cancel();
 
 			// NOTE: a cancelled WhenAny will not throw!

Open.ChannelExtensions.Tests/BasicTests.cs

@@ -58,14 +58,14 @@ public static async Task ReadAll(int testSize)
 	public static async Task ReadAllAsEnumerables1()
 	{
 		var channel = Channel.CreateUnbounded<int>();
-		var read = channel.Reader.ReadAllAsEnumerables(e =>
+		ValueTask read = channel.Reader.ReadAllAsEnumerables(e =>
 		{
 			Thread.Sleep(100);
 			Assert.Equal(1000, e.Count());
 		});
 
 		await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
-		for (var i = 0; i < 5; i++)
+		for (int i = 0; i < 5; i++)
 		{
 			await Task.Delay(1000);
 			await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
@@ -79,14 +79,14 @@ public static async Task ReadAllAsEnumerables1()
 	public static async Task ReadAllAsEnumerablesAsync1()
 	{
 		var channel = Channel.CreateUnbounded<int>();
-		var read = channel.Reader.ReadAllAsEnumerablesAsync(async e =>
+		ValueTask read = channel.Reader.ReadAllAsEnumerablesAsync(async e =>
 		{
 			await Task.Delay(100);
 			Assert.Equal(1000, e.Count());
 		});
 
 		await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
-		for (var i = 0; i < 5; i++)
+		for (int i = 0; i < 5; i++)
 		{
 			await Task.Delay(1000);
 			await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
@@ -101,17 +101,17 @@ public static async Task ReadAllConcurrentlyAsEnumerablesAsync()
 	{
 		var channel = Channel.CreateUnbounded<int>();
 		int total = 0;
-		var read = channel.Reader.ReadAllConcurrentlyAsEnumerablesAsync(3, async e =>
+		Task read = channel.Reader.ReadAllConcurrentlyAsEnumerablesAsync(3, async e =>
 		{
-			foreach (var i in e)
+			foreach (int i in e)
 			{
 				await Task.Delay(1);
 				Interlocked.Increment(ref total);
 			}
 		});
 
 		await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
-		for (var i = 0; i < 5; i++)
+		for (int i = 0; i < 5; i++)
 		{
 			await Task.Delay(1000);
 			await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
@@ -128,11 +128,11 @@ public static async Task ReadAllConcurrentlyAsEnumerables()
 	{
 		var channel = Channel.CreateUnbounded<int>();
 		int total = 0;
-		var read = channel.Reader.ReadAllConcurrentlyAsEnumerables(3, e =>
+		Task read = channel.Reader.ReadAllConcurrentlyAsEnumerables(3, e =>
 		{
-			foreach (var i in e)
+			foreach (int i in e)
 			{
-				for (var n = 0; n < 2000000; n++)
+				for (int n = 0; n < 2000000; n++)
 				{
 					// loop delay
 				}
@@ -141,7 +141,7 @@ public static async Task ReadAllConcurrentlyAsEnumerables()
 		});
 
 		await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
-		for (var i = 0; i < 5; i++)
+		for (int i = 0; i < 5; i++)
 		{
 			await Task.Delay(1000);
 			await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
@@ -158,10 +158,10 @@ public static async Task ReadAllAsEnumerables2()
 	{
 		var channel = Channel.CreateUnbounded<int>();
 		int total = 0;
-		var read = channel.Reader.ReadAllAsEnumerables(e => total += e.Count());
+		ValueTask read = channel.Reader.ReadAllAsEnumerables(e => total += e.Count());
 
 		await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
-		for (var i = 0; i < 5; i++)
+		for (int i = 0; i < 5; i++)
 		{
 			await Task.Delay(1000);
 			await channel.Writer.WriteAll(Enumerable.Range(0, 1000));
@@ -468,18 +468,18 @@ public static async Task PipeFilterTest()
 		const int each = 5_000;
 		const int total = 2 * each;
 
-		var source = Enumerable.Range(0, total).ToChannel(300);
+		ChannelReader<int> source = Enumerable.Range(0, total).ToChannel(300);
 
-		var evenFilter = source
-			.PipeFilter(out var unmatched, 100, 10,
+		ValueTask<List<int>> evenFilter = source
+			.PipeFilter(out ChannelReader<int> unmatched, 100, 10,
 				static e => e % 2 == 0)
 			.ToListAsync(each);
 
-		var oddFilter = unmatched
+		ValueTask<List<int>> oddFilter = unmatched
 			.ToListAsync(each);
 
-		var even = await evenFilter;
-		var odd = await oddFilter;
+		List<int> even = await evenFilter;
+		List<int> odd = await oddFilter;
 
 		even.Count.Should().Be(each);
 		odd.Count.Should().Be(each);
@@ -493,21 +493,21 @@ public static async Task PipeFilterAsyncTest()
 		const int each = 5_000;
 		const int total = 2 * each;
 
-		var source = Enumerable.Range(0, total).ToChannel(300);
+		ChannelReader<int> source = Enumerable.Range(0, total).ToChannel(300);
 
-		var evenFilter = source
-			.PipeFilterAsync(out var unmatched, 10, 100, static async e =>
+		ValueTask<List<int>> evenFilter = source
+			.PipeFilterAsync(out ChannelReader<int> unmatched, 10, 100, static async e =>
 			{
 				await Task.Yield();
 				return e % 2 == 0;
 			})
 			.ToListAsync(each);
 
-		var oddFilter = unmatched
+		ValueTask<List<int>> oddFilter = unmatched
 			.ToListAsync(each);
 
-		var even = await evenFilter;
-		var odd = await oddFilter;
+		List<int> even = await evenFilter;
+		List<int> odd = await oddFilter;
 
 		even.Count.Should().Be(each);
 		odd.Count.Should().Be(each);
@@ -539,7 +539,7 @@ static ValueTask<int> AsyncReceiver()
 		await Assert.ThrowsAsync<OperationCanceledException>(
 			async () =>
 			{
-				var reader = Enumerable.Repeat(0, 10)
+				ChannelReader<int> reader = Enumerable.Repeat(0, 10)
 					.ToChannel()
 					.PipeAsync(1, async _ => await AsyncReceiver());