Cleanup and fix null checks.

Author: electricessence

Open.ChannelExtensions/Extensions.Pipe.cs

@@ -1,6 +1,4 @@
-using static System.Net.Mime.MediaTypeNames;
-
-namespace Open.ChannelExtensions;
+namespace Open.ChannelExtensions;
 
 [SuppressMessage("Roslynator", "RCS1047:Non-asynchronous method name should not end with 'Async'.", Justification = "In order to differentiate between non async versions.")]
 public static partial class Extensions

Open.ChannelExtensions/Extensions._.cs

@@ -117,13 +117,16 @@ public static ChannelReader<TSource> PropagateCompletion<TSource, TTarget>(
 	[ExcludeFromCodeCoverage]
 	public static ChannelReader<TSource> PropagateCompletion<TSource, TTargetIn, TTargetOut>(
 		this ChannelReader<TSource> source, Channel<TTargetIn, TTargetOut> target, CancellationToken cancellationToken = default)
-		=> PropagateCompletion(source, target.Writer, cancellationToken);
+		=> target is null
+		? throw new ArgumentNullException(nameof(target))
+		: source.PropagateCompletion(target.Writer, cancellationToken);
 
 	/// <inheritdoc cref="PropagateCompletion{TSource, TTarget}(ChannelReader{TSource}, ChannelWriter{TTarget}, CancellationToken)"/>
 	[ExcludeFromCodeCoverage]
 	public static Channel<TSourceIn, TSourceOut> PropagateCompletion<TSourceIn, TSourceOut, TTarget>(
 		this Channel<TSourceIn, TSourceOut> source, ChannelWriter<TTarget> target, CancellationToken cancellationToken = default)
 	{
+		if (source is null) throw new ArgumentNullException(nameof(source));
 		_ = source.Reader.PropagateCompletion(target, cancellationToken);
 		return source;
 	}
@@ -132,7 +135,9 @@ public static Channel<TSourceIn, TSourceOut> PropagateCompletion<TSourceIn, TSou
 	[ExcludeFromCodeCoverage]
 	public static Channel<TSourceIn, TSourceOut> PropagateCompletion<TSourceIn, TSourceOut, TTargetIn, TTargetOut>(
 		this Channel<TSourceIn, TSourceOut> source, Channel<TTargetIn, TTargetOut> target, CancellationToken cancellationToken = default)
-		=> PropagateCompletion(source, target.Writer, cancellationToken);
+		=> target is null
+		? throw new ArgumentNullException(nameof(target))
+		: source.PropagateCompletion(target.Writer, cancellationToken);
 
 	/// <summary>
 	/// Uses <see cref="ChannelWriter{T}.WaitToWriteAsync(CancellationToken)"/> to peek and see if the channel can still be written to.

Open.ChannelExtensions/Open.ChannelExtensions.csproj

@@ -22,22 +22,18 @@
 		<RepositoryType>git</RepositoryType>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
-		<Version>8.4.2</Version>
+		<Version>8.4.3</Version>
 		<PackageReleaseNotes>Added .Merge, .PipeAsync, and .PropagateCompletion extensions.</PackageReleaseNotes>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
 		<IncludeSymbols>true</IncludeSymbols>
 		<SymbolPackageFormat>snupkg</SymbolPackageFormat>
 		<PackageIcon>logo.png</PackageIcon>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
-		<!-- Don't enforce colleciton expressions as they don't work in .NET 6. -->
+		<!-- Don't enforce collection expressions as they don't work in .NET 6. -->
 		<NoWarn>IDE0301;IDE0303;IDE0304</NoWarn>
 	</PropertyGroup>
 
-	<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
-		<NoWarn>$(NoWarn);nullable</NoWarn>
-	</PropertyGroup>
-
 	<ItemGroup>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.*" PrivateAssets="All" />
 	</ItemGroup>
@@ -58,4 +54,9 @@
 		<PackageReference Include="System.Collections.Immutable" Version="8.*" />
 	</ItemGroup>
 
+	<!-- Disable the nullable warnings when compiling for .NET Standard 2.0 -->
+	<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+		<NoWarn>$(NoWarn);nullable</NoWarn>
+	</PropertyGroup>
+
 </Project>