Fixed issue with expanded comination set.

Author: electricessence

source/Extensions.Combinations.cs

@@ -23,8 +23,8 @@ static IEnumerable<T[]> CombinationsCore<T>(IReadOnlyList<T> source, int length,
 				if (count == 1) yield break;
 			}
 
-			var pool = count > 128 ? ArrayPool<int>.Shared : null;
-			var indexes = pool?.Rent(count) ?? new int[count];
+			var pool = length > 128 ? ArrayPool<int>.Shared : null;
+			var indexes = pool?.Rent(length) ?? new int[length];
 			try
 			{
 				for (var i = 0; i < length; i++) indexes[i] = 0;

source/Open.Collections.csproj

@@ -17,7 +17,7 @@
 		<PackageProjectUrl>https://github.com/Open-NET-Libraries/Open.Collections/</PackageProjectUrl>
 		<RepositoryUrl>https://github.com/Open-NET-Libraries/Open.Collections/</RepositoryUrl>
 		<RepositoryType>git</RepositoryType>
-		<Version>2.12.7</Version>
+		<Version>2.12.8</Version>
 		<PackageReleaseNotes></PackageReleaseNotes>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>

testing/Open.Collections.Tests/CombinationTests.cs

@@ -8,6 +8,7 @@ public class CombinationTests
 	{
 		static ImmutableArray<int> Set1 = ImmutableArray.Create(1, 2);
 		static ImmutableArray<char> Set2 = ImmutableArray.Create('A', 'C', 'E');
+		static ImmutableArray<int> Set3 = ImmutableArray.Create(0, 1);
 
 		[Fact]
 		public void TestCombination1()
@@ -67,5 +68,30 @@ public void TestCombination2Distinct()
 			Assert.Equal(expected, actual);
 		}
 
+
+		[Fact]
+		public void TestCombination3()
+		{
+			var expected = new int[][] {
+				new int[] { 0, 0, 0, 0 },
+				new int[] { 0, 0, 0, 1 },
+				new int[] { 0, 0, 1, 0 },
+				new int[] { 0, 0, 1, 1 },
+				new int[] { 0, 1, 0, 0 },
+				new int[] { 0, 1, 0, 1 },
+				new int[] { 0, 1, 1, 0 },
+				new int[] { 0, 1, 1, 1 },
+				new int[] { 1, 0, 0, 0 },
+				new int[] { 1, 0, 0, 1 },
+				new int[] { 1, 0, 1, 0 },
+				new int[] { 1, 0, 1, 1 },
+				new int[] { 1, 1, 0, 0 },
+				new int[] { 1, 1, 0, 1 },
+				new int[] { 1, 1, 1, 0 },
+				new int[] { 1, 1, 1, 1 },
+			};
+			var actual = Set3.Combinations(4).ToArray();
+			Assert.Equal(expected, actual);
+		}
 	}
 }