Tweaks to use array pool.

Author: Oren (electricessence)

benchmarking/Program.cs

@@ -36,34 +36,30 @@ public static void Test1()
 		{
 			Console.WriteLine("Beginning LazyList concurrency test.");
 			var sw = new Stopwatch();
-			using (var list = new LazyList<TestEntry>(EndlessTest()))
+			using var list = new LazyList<TestEntry>(EndlessTest());
+			Parallel.For(0, 10000000, i =>
 			{
-				Parallel.For(0, 10000000, i =>
-				{
-					// ReSharper disable once AccessToDisposedClosure
-					var e = list[i];
-					if (e == null) throw new NullReferenceException();
-					Debug.Assert(e.Value == i);
-				});
-				Console.WriteLine(sw.Elapsed);
-				Debug.Assert(list.IndexOf(list[10000]) == 10000);
-			}
+				// ReSharper disable once AccessToDisposedClosure
+				var e = list[i];
+				if (e == null) throw new NullReferenceException();
+				Debug.Assert(e.Value == i);
+			});
+			Console.WriteLine(sw.Elapsed);
+			Debug.Assert(list.IndexOf(list[10000]) == 10000);
 
 		}
 
 		public static void Test2()
 		{
 			Console.WriteLine("Beginning LazyList.GetEnumerator() concurrency test.");
-			using (var list = new LazyList<TestEntry>(EndlessTest(10000000)))
+			using var list = new LazyList<TestEntry>(EndlessTest(10000000));
+			var sw = new Stopwatch();
+			Parallel.ForEach(list, e =>
 			{
-				var sw = new Stopwatch();
-				Parallel.ForEach(list, e =>
-				{
-					if (e == null) throw new NullReferenceException();
-				});
-				Console.WriteLine(sw.Elapsed);
-				Debug.Assert(list.IndexOf(list[10000]) == 10000);
-			}
+				if (e == null) throw new NullReferenceException();
+			});
+			Console.WriteLine(sw.Elapsed);
+			Debug.Assert(list.IndexOf(list[10000]) == 10000);
 
 		}
 

source/ConcurrentHashSet.cs

@@ -4,9 +4,9 @@
 namespace Open.Collections
 {
 	public class ConcurrentHashSet<T> : DictionaryToHashSetWrapper<T>
-    {
+	{
 		public ConcurrentHashSet(IEnumerable<T> intialValues = null)
-			: base(new ConcurrentDictionary<T,bool>())
+			: base(new ConcurrentDictionary<T, bool>())
 		{
 			if (intialValues != null)
 				UnionWith(intialValues);

source/Extensions.Stream.cs

@@ -15,11 +15,11 @@ public static void CopyTo(this Stream source, Stream target)
 			if (target == null)
 				throw new ArgumentNullException(nameof(target));
 
-			var bytes = new byte[4096];
-
+			var bytes = System.Buffers.ArrayPool<byte>.Shared.Rent(4096);
 			int cnt;
 			while ((cnt = source.Read(bytes, 0, bytes.Length)) != 0)
 				target.Write(bytes, 0, cnt);
+			System.Buffers.ArrayPool<byte>.Shared.Return(bytes, true);
 		}
 	}
 }

source/Extensions.cs

@@ -248,15 +248,13 @@ public static bool HasAtLeast<T>(this IEnumerable<T> source, int minimum)
 					return collection.Count >= minimum;
 			}
 
-			using (var e = source.GetEnumerator())
+			using var e = source.GetEnumerator();
+			while (e.MoveNext())
 			{
-				while (e.MoveNext())
-				{
-					if (--minimum == 0)
-						return true;
-				}
-				return false;
+				if (--minimum == 0)
+					return true;
 			}
+			return false;
 
 		}
 
@@ -300,7 +298,7 @@ static async Task PreCacheWorker<T>(IEnumerator<T> e, Channel<T> queue)
 					{
 						var value = e.Current;
 
-						retry:
+					retry:
 						if (queue.Writer.TryWrite(value)) continue;
 						if (await queue.Writer.WaitToWriteAsync()) goto retry;
 
@@ -419,7 +417,7 @@ public static string JoinToString<T>(this IEnumerable<T> source, char separator)
 			Contract.EndContractBlock();
 
 			var sb = new StringBuilder();
-			using(var enumerator = source.GetEnumerator())
+			using (var enumerator = source.GetEnumerator())
 			{
 				if (enumerator.MoveNext())
 					sb.Append(enumerator.Current);
@@ -847,14 +845,12 @@ public static IEnumerable<IEnumerable<T>> Combinations<T>(this IEnumerable<T> el
 			}
 			else
 			{
-				using (var el = elements.Memoize())
-				{
-					foreach (var combination in el.SelectMany((e, i) => el
-						.Skip(i + (uniqueOnly ? 1 : 0))
-						.Combinations(k - 1, uniqueOnly)
-						.Select(c => (new[] { e }).Concat(c))))
-						yield return combination;
-				}
+				using var el = elements.Memoize();
+				foreach (var combination in el.SelectMany((e, i) => el
+.Skip(i + (uniqueOnly ? 1 : 0))
+.Combinations(k - 1, uniqueOnly)
+.Select(c => (new[] { e }).Concat(c))))
+					yield return combination;
 			}
 
 		}

source/Open.Collections.csproj

@@ -15,9 +15,7 @@ Part of the "Open" set of libraries.</Description>
     <PackageProjectUrl>https://github.com/electricessence/Open.Collections/</PackageProjectUrl>
     <RepositoryUrl>https://github.com/electricessence/Open.Collections/</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <Version>2.7.0</Version>
-    <AssemblyVersion>2.7.0.0</AssemblyVersion>
-    <FileVersion>2.7.0.0</FileVersion>
+    <Version>2.7.1</Version>
     <PackageReleaseNotes></PackageReleaseNotes>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
@@ -41,6 +39,10 @@ Part of the "Open" set of libraries.</Description>
 
   <ItemGroup>
     <PackageReference Include="Open.Threading" Version="1.5.3" />
-  </ItemGroup>
+	</ItemGroup>
+
+	<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
+		<PackageReference Include="System.Buffers" Version="4.5.0" />
+	</ItemGroup>
 
 </Project>

source/Queue/IQueue.cs

@@ -1,6 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-
-namespace Open.Collections
+namespace Open.Collections
 {
 	public interface IQueue<T>
 	{

source/Synchronized/TrackedList.cs

@@ -3,7 +3,6 @@
  * Licensing: MIT https://github.com/electricessence/Genetic-Algorithm-Platform/blob/master/LICENSE.md
  */
 
-using Open.Disposable;
 using Open.Threading;
 using System;
 using System.Collections;