Update naming styles, nullability, and tests

- Updated `.editorconfig` for new naming styles and diagnostic settings.
- Removed `using System.Buffers;` in `ToChannel.Target.cs` and made `arrayPool` parameters nullable.
- Enhanced `ToChannel` and `ToChannelAsync` methods with null checks for `arrayPool`.
- Added a new constructor for `QueryResultQueue<T>` to initialize from an enumerable.
- Simplified `Processor` constructor in `Transformer.cs` using expression-bodied syntax.
- Made significant changes to `DataReaderExtensions` for nullable parameter support.
- Introduced new test classes for `IDataReader` and `IDbCommand` to validate null handling and behavior.
- Updated project file to include implicit usings and project references.
- Created `_Imports.cs` for global using directives to streamline the codebase.

Author: electricessence

.editorconfig

@@ -178,5 +178,11 @@ dotnet_diagnostic.CA1510.severity = silent
 # IDE0130: Namespace does not match folder structure
 dotnet_diagnostic.IDE0130.severity = silent
 
+# IDE0301: Simplify collection initialization
+dotnet_diagnostic.IDE0301.severity = silent
+
 # IDE0305: Simplify collection initialization
-dotnet_diagnostic.IDE0305.severity = silent
+dotnet_diagnostic.IDE0305.severity = silent
+
+# IDE0306: Simplify collection initialization
+dotnet_diagnostic.IDE0306.severity = silent

Source/Channel/ToChannel.Target.cs

@@ -1,6 +1,4 @@
-using System.Buffers;
-
-namespace Open.Database.Extensions;
+namespace Open.Database.Extensions;
 
 /// <summary>
 /// Extensions for writing data to a channel.
@@ -127,7 +125,7 @@ public static ValueTask<long> ToChannel(this IDataReader reader,
 	public static ValueTask<long> ToChannel(this IDataReader reader,
 		ChannelWriter<object[]> target,
 		bool complete,
-		ArrayPool<object> arrayPool,
+		ArrayPool<object>? arrayPool,
 		CancellationToken cancellationToken = default)
 	{
 		if (reader is null) throw new ArgumentNullException(nameof(reader));
@@ -546,7 +544,7 @@ public static ValueTask<long> ToChannelAsync(this DbDataReader reader,
 	public static ValueTask<long> ToChannelAsync(this DbDataReader reader,
 		ChannelWriter<object[]> target,
 		bool complete,
-		ArrayPool<object> arrayPool,
+		ArrayPool<object>? arrayPool,
 		CancellationToken cancellationToken = default)
 	{
 		if (reader is null) throw new ArgumentNullException(nameof(reader));
@@ -758,7 +756,7 @@ public static ValueTask<long> ToChannelAsync(this IExecuteReaderAsync command,
 	public static ValueTask<long> ToChannelAsync(this IExecuteReaderAsync command,
 		ChannelWriter<object[]> target,
 		bool complete,
-		ArrayPool<object> arrayPool)
+		ArrayPool<object>? arrayPool)
 		=> ToChannelAsyncCore(
 			command, target, complete,
 			reader => command.UseAsyncRead && reader is DbDataReader r

Source/Channel/ToChannel.cs

@@ -35,11 +35,10 @@ public static ChannelReader<object[]> ToChannel(this IDataReader reader,
 	/// <returns>The channel reader containing the results.</returns>
 	public static ChannelReader<object[]> ToChannel(this IDataReader reader,
 		bool singleReader,
-		ArrayPool<object> arrayPool,
+		ArrayPool<object>? arrayPool,
 		CancellationToken cancellationToken = default)
 	{
 		if (reader is null) throw new ArgumentNullException(nameof(reader));
-		if (arrayPool is null) throw new ArgumentNullException(nameof(arrayPool));
 		Contract.EndContractBlock();
 
 		Channel<object[]> channel = CreateChannel<object[]>(-1, singleReader);
@@ -580,7 +579,7 @@ public static ChannelReader<object[]> ToChannelAsync(this IExecuteReaderAsync co
 	/// <returns>The channel reader containing the results.</returns>
 	public static ChannelReader<object[]> ToChannelAsync(this IExecuteReaderAsync command,
 		bool singleReader,
-		ArrayPool<object> arrayPool)
+		ArrayPool<object>? arrayPool)
 	{
 		if (command is null) throw new ArgumentNullException(nameof(command));
 		Contract.EndContractBlock();

Source/Core/Core/QueryResult.cs

@@ -158,6 +158,15 @@ public QueryResultQueue(
 		: base(ordinals, names, result)
 	{
 	}
+
+	/// <inheritdoc cref="QueryResultQueue{T}.QueryResultQueue(ImmutableArray{int}, ImmutableArray{string}, Queue{T})" />
+	public QueryResultQueue(
+		IEnumerable<int> ordinals,
+		IEnumerable<string> names,
+		IEnumerable<T> result)
+		: base(ordinals, names, new (result))
+	{
+	}
 }
 
 /// <summary>

Source/Core/Core/Transformer.cs

@@ -116,10 +116,7 @@ public Processor(Transformer<T> transformer)
 		/// <param name="transformer">The transformer to use.</param>
 		/// <param name="names">The names of columns/properties to acquire.</param>
 		public Processor(Transformer<T> transformer, ImmutableArray<string> names)
-			: this(transformer)
-		{
-			SetNames(names);
-		}
+			: this(transformer) => SetNames(names);
 
 		/// <summary>
 		/// The transformer being used.
@@ -260,9 +257,7 @@ async IAsyncEnumerable<T> ResultsAsyncCore(DbDataReader reader, [EnumeratorCance
 			(string Name, int Ordinal)[] columns = reader.GetMatchingOrdinals(_propertyMap.Values, true);
 			var processor = new Processor(this, columns.Select(m => m.Name).ToImmutableArray());
 
-#pragma warning disable ConfigureAwaitEnforcer // ConfigureAwaitEnforcer
 			await foreach (object[] a in reader.AsAsyncEnumerable(columns.Select(m => m.Ordinal), LocalPool, cancellationToken))
-#pragma warning restore ConfigureAwaitEnforcer // ConfigureAwaitEnforcer
 			{
 				try
 				{

Source/Core/ExpressiveCommandBase.Param.cs

@@ -41,6 +41,7 @@ public override readonly bool Equals(object? obj)
 
 		/// <inheritdoc />
 #if NETSTANDARD2_0
+		[SuppressMessage("Roslynator", "RCS1123:Add parentheses when necessary", Justification = "<Pending>")]
 		public override readonly int GetHashCode()
 		{
 			int hashCode = 1477810893;

Source/Core/Extensions/DataReader.cs

@@ -1,4 +1,6 @@
-namespace Open.Database.Extensions;
+using System.Diagnostics;
+
+namespace Open.Database.Extensions;
 
 /// <summary>
 /// Extension methods for Data Readers.
@@ -140,113 +142,131 @@ public static async ValueTask ForEachAsync(
 	public static ValueTask ForEachAsync(this DbDataReader reader, Func<IDataRecord, ValueTask> handler, CancellationToken cancellationToken)
 		=> ForEachAsync(reader, handler, true, cancellationToken);
 
-	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
-	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader)
+	static IEnumerable<object[]> AsEnumerableCore(IDataReader reader)
 	{
-		return reader is null
-			? throw new ArgumentNullException(nameof(reader))
-			: AsEnumerableCore(reader);
+		Debug.Assert(reader is not null);
+
+		if (!reader.Read())
+			yield break;
 
-		static IEnumerable<object[]> AsEnumerableCore(IDataReader reader)
+		int fieldCount = reader.FieldCount;
+		do
 		{
-			if (!reader.Read())
-				yield break;
+			object[] row = new object[fieldCount];
+			reader.GetValues(row);
+			yield return row;
+		} while (reader.Read());
+	}
 
-			int fieldCount = reader.FieldCount;
-			do
-			{
-				object[] row = new object[fieldCount];
-				reader.GetValues(row);
-				yield return row;
-			} while (reader.Read());
-		}
+	static IEnumerable<object[]> AsEnumerableCore(IDataReader reader, ArrayPool<object> arrayPool)
+	{
+		Debug.Assert(reader is not null);
+		Debug.Assert(arrayPool is not null);
+
+		if (!reader.Read())
+			yield break;
+
+		int fieldCount = reader.FieldCount;
+		do
+		{
+			object[] row = arrayPool.Rent(fieldCount);
+			reader.GetValues(row);
+			yield return row;
+		} while (reader.Read());
 	}
 
 	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
-	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, ArrayPool<object> arrayPool)
-	{
-		return reader is null
+	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader)
+		=> reader is null
+			? throw new ArgumentNullException(nameof(reader))
+			: AsEnumerableCore(reader);
+
+	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
+	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, ArrayPool<object>? arrayPool)
+		=> reader is null
 			? throw new ArgumentNullException(nameof(reader))
 			: arrayPool is null
-			? throw new ArgumentNullException(nameof(arrayPool))
+			? AsEnumerableCore(reader)
 			: AsEnumerableCore(reader, arrayPool);
 
-		static IEnumerable<object[]> AsEnumerableCore(IDataReader reader, ArrayPool<object> arrayPool)
-		{
-			if (!reader.Read())
-				yield break;
+	static IEnumerable<object[]> AsEnumerableInternalCore(
+		IDataReader reader, IEnumerable<int> ordinals, bool readStarted)
+	{
+		Debug.Assert(reader is not null);
+		Debug.Assert(ordinals is not null);
 
-			int fieldCount = reader.FieldCount;
+		if (!readStarted && !reader.Read())
+			yield break;
+
+		IList<int> o = ordinals as IList<int> ?? ordinals.ToArray();
+		int fieldCount = o.Count;
+		if (fieldCount == 0)
+		{
 			do
 			{
-				object[] row = arrayPool.Rent(fieldCount);
-				reader.GetValues(row);
-				yield return row;
-			} while (reader.Read());
+				yield return Array.Empty<object>();
+			}
+			while (reader.Read());
+			yield break;
 		}
+
+		do
+		{
+			object[] row = new object[fieldCount];
+			for (int i = 0; i < fieldCount; i++)
+				row[i] = reader.GetValue(o[i]);
+			yield return row;
+		}
+		while (reader.Read());
 	}
 
-	internal static IEnumerable<object[]> AsEnumerableInternal(this IDataReader reader, IEnumerable<int> ordinals, bool readStarted)
+	static IEnumerable<object[]> AsEnumerableInternalCore(
+		IDataReader reader, IEnumerable<int> ordinals, bool readStarted, ArrayPool<object> arrayPool)
 	{
-		return reader is null
-			? throw new ArgumentNullException(nameof(reader))
-			: ordinals is null
-			? throw new ArgumentNullException(nameof(ordinals))
-			: AsEnumerableInternalCore(reader, ordinals, readStarted);
+		Debug.Assert(reader is not null);
+		Debug.Assert(ordinals is not null);
+		Debug.Assert(arrayPool is not null);
 
-		static IEnumerable<object[]> AsEnumerableInternalCore(IDataReader reader, IEnumerable<int> ordinals, bool readStarted)
-		{
-			if (!readStarted && !reader.Read())
-				yield break;
+		if (!readStarted && !reader.Read())
+			yield break;
 
-			IList<int> o = ordinals as IList<int> ?? ordinals.ToArray();
-			int fieldCount = o.Count;
-			if (fieldCount == 0)
-			{
-				do
-				{
-					yield return Array.Empty<object>();
-				}
-				while (reader.Read());
-				yield break;
-			}
-
-			do
-			{
-				object[] row = new object[fieldCount];
-				for (int i = 0; i < fieldCount; i++)
-					row[i] = reader.GetValue(o[i]);
-				yield return row;
-			}
-			while (reader.Read());
+		IList<int> o = ordinals as IList<int> ?? ordinals.ToArray();
+		int fieldCount = o.Count;
+		do
+		{
+			object[] row = arrayPool.Rent(fieldCount);
+			for (int i = 0; i < fieldCount; i++)
+				row[i] = reader.GetValue(o[i]);
+			yield return row;
 		}
+		while (reader.Read());
 	}
 
-	internal static IEnumerable<object[]> AsEnumerableInternal(this IDataReader reader, IEnumerable<int> ordinals, bool readStarted, ArrayPool<object> arrayPool)
+	internal static IEnumerable<object[]> AsEnumerableInternal(
+		this IDataReader reader,
+		IEnumerable<int> ordinals,
+		bool readStarted)
 	{
-		return reader is null
-			? throw new ArgumentNullException(nameof(reader))
-			: ordinals is null
-			? throw new ArgumentNullException(nameof(ordinals))
-			: arrayPool is null ? throw new ArgumentNullException(nameof(arrayPool))
-			: AsEnumerableInternalCore();
+		if (reader is null) throw new ArgumentNullException(nameof(reader));
+		if (ordinals is null) throw new ArgumentNullException(nameof(ordinals));
+		Contract.EndContractBlock();
 
-		IEnumerable<object[]> AsEnumerableInternalCore()
-		{
-			if (!readStarted && !reader.Read())
-				yield break;
+		return AsEnumerableInternalCore(reader, ordinals, readStarted);
+	}
 
-			IList<int> o = ordinals as IList<int> ?? ordinals.ToArray();
-			int fieldCount = o.Count;
-			do
-			{
-				object[] row = arrayPool.Rent(fieldCount);
-				for (int i = 0; i < fieldCount; i++)
-					row[i] = reader.GetValue(o[i]);
-				yield return row;
-			}
-			while (reader.Read());
-		}
+	internal static IEnumerable<object[]> AsEnumerableInternal(
+		this IDataReader reader,
+		IEnumerable<int> ordinals,
+		bool readStarted,
+		ArrayPool<object>? arrayPool)
+	{
+		if (reader is null) throw new ArgumentNullException(nameof(reader));
+		if (ordinals is null) throw new ArgumentNullException(nameof(ordinals));
+		Contract.EndContractBlock();
+
+		return arrayPool is null
+			? AsEnumerableInternalCore(reader, ordinals, readStarted)
+			: AsEnumerableInternalCore(reader, ordinals, readStarted, arrayPool);
 	}
 
 	/// <inheritdoc cref="AsEnumerable(IDataReader, IEnumerable{int}, ArrayPool{object?})"/>
@@ -257,7 +277,7 @@ public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, IEnume
 	/// <param name="ordinals">The limited set of ordinals to include.  If none are specified, the returned objects will be empty.</param>
 	/// <param name="arrayPool">The array pool to acquire buffers from.</param>
 	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
-	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, IEnumerable<int> ordinals, ArrayPool<object> arrayPool)
+	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, IEnumerable<int> ordinals, ArrayPool<object>? arrayPool)
 		=> AsEnumerableInternal(reader, ordinals, false, arrayPool);
 
 	/// <param name="reader">The reader to enumerate.</param>
@@ -276,7 +296,7 @@ public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, int n,
 	/// <param name="n">The first ordinal to include in the request to the reader for each record.</param>
 	/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 	/// <returns>An enumerable of the values returned from a data reader.</returns>
-	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, ArrayPool<object> arrayPool, int n, params int[] others)
+	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, ArrayPool<object>? arrayPool, int n, params int[] others)
 		=> AsEnumerable(reader, CoreExtensions.Concat(n, others), arrayPool);
 
 	/// <inheritdoc cref="Select{T}(IDataReader, Func{IDataRecord, T}, CancellationToken, bool)"/>
@@ -392,12 +412,15 @@ static async IAsyncEnumerable<object[]> AsAsyncEnumerableCore(DbDataReader reade
 	/// <param name="arrayPool">An optional array pool to acquire buffers from.</param>
 	/// <param name="cancellationToken">Optional iteration cancellation token.</param>
 	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
-	public static IAsyncEnumerable<object[]> AsAsyncEnumerable(this DbDataReader reader, ArrayPool<object> arrayPool, CancellationToken cancellationToken = default)
+	public static IAsyncEnumerable<object[]> AsAsyncEnumerable(
+		this DbDataReader reader,
+		ArrayPool<object>? arrayPool,
+		CancellationToken cancellationToken = default)
 	{
 		return reader is null
 			? throw new ArgumentNullException(nameof(reader))
 			: arrayPool is null
-			? throw new ArgumentNullException(nameof(arrayPool))
+			? AsAsyncEnumerable(reader, cancellationToken)
 			: AsAsyncEnumerableCore(reader, arrayPool, cancellationToken);
 
 		static async IAsyncEnumerable<object[]> AsAsyncEnumerableCore(DbDataReader reader, ArrayPool<object> arrayPool, [EnumeratorCancellation] CancellationToken cancellationToken)