Skip to content

Commit 6c472af

Browse files
Updated references.
Pinned minimum for SqlClient as per advisory.
1 parent a736ac9 commit 6c472af

File tree

10 files changed

+26
-25
lines changed

10 files changed

+26
-25
lines changed

Source/Channel/Open.Database.Extensions.Channel.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageTags>ado;ado extensions;sql;connection factory;extensions;channel;channels</PackageTags>
1515
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1616
<RepositoryType>git</RepositoryType>
17-
<Version>7.1.0</Version>
17+
<Version>7.2.0</Version>
1818
<PackageReleaseNotes></PackageReleaseNotes>
1919
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2020
<IncludeSymbols>true</IncludeSymbols>
@@ -28,7 +28,7 @@
2828

2929
<ItemGroup>
3030
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
31-
<PackageReference Include="Open.ChannelExtensions" Version="6.1.0" />
31+
<PackageReference Include="Open.ChannelExtensions" Version="6.2.2" />
3232
</ItemGroup>
3333

3434
<ItemGroup>

Source/Core/ExpressiveCommandBase.cs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ public TThis AddParam(string name, object value)
223223
Name = name,
224224
Value = value ?? DBNull.Value
225225
});
226+
226227
return (TThis)this;
227228
}
228229

@@ -241,10 +242,13 @@ public TThis AddParam<T>(string name, T? value, TDbType type)
241242
throw new ArgumentException("Parameter names cannot be empty or white space.", nameof(name));
242243
Contract.EndContractBlock();
243244

244-
var p = new Param { Name = name, Type = type };
245-
p.Value = value ?? (object)DBNull.Value;
245+
Params.Add(new Param
246+
{
247+
Name = name,
248+
Type = type,
249+
Value = value ?? (object)DBNull.Value
250+
});
246251

247-
Params.Add(p);
248252
return (TThis)this;
249253
}
250254

@@ -260,10 +264,12 @@ public TThis AddParam<T>(string name, T? value)
260264
if (name is null) throw new ArgumentNullException(nameof(name));
261265
Contract.EndContractBlock();
262266

263-
var p = new Param { Name = name };
264-
p.Value = value ?? (object)DBNull.Value;
267+
Params.Add(new Param
268+
{
269+
Name = name,
270+
Value = value ?? (object)DBNull.Value
271+
});
265272

266-
Params.Add(p);
267273
return (TThis)this;
268274
}
269275

Source/Core/Extensions/Command.AddParameter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public static IDbDataParameter AddParameter(
6666
string name,
6767
double value) => AddParameter(target, name, value, DbType.Double);
6868

69-
7069
/// <inheritdoc cref="AddParameter(IDbCommand, string, object, DbType, ParameterDirection)"/>
7170
public static IDbDataParameter AddParameter(
7271
this IDbCommand target,

Source/Core/Extensions/Command._.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@ public static async ValueTask<IDataReader> ExecuteReaderAsync(this IDbCommand co
252252
: command.ExecuteReader(behavior);
253253
}
254254

255-
256255
/// <summary>
257256
/// Asynchronously executes a reader on a command with a handler function.
258257
/// </summary>

Source/Core/Open.Database.Extensions.Core.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageTags>ado;ado extensions;sql;connection factory;extensions;</PackageTags>
1515
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1616
<RepositoryType>git</RepositoryType>
17-
<Version>7.1.0</Version>
17+
<Version>7.2.0</Version>
1818
<PackageReleaseNotes></PackageReleaseNotes>
1919
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2020
<IncludeSymbols>true</IncludeSymbols>
@@ -28,7 +28,7 @@
2828

2929
<ItemGroup>
3030
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
31-
<PackageReference Include="System.Collections.Immutable" Version="6.*" />
31+
<PackageReference Include="System.Collections.Immutable" Version="7.0.0" />
3232
</ItemGroup>
3333

3434
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">

Source/Dataflow/Open.Database.Extensions.Dataflow.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageTags>ado;ado extensions;dataflow;data;database</PackageTags>
1515
<RepositoryType>git</RepositoryType>
1616
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
17-
<Version>7.1.0</Version>
17+
<Version>7.2.0</Version>
1818
<PackageReleaseNotes></PackageReleaseNotes>
1919
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2020
<IncludeSymbols>true</IncludeSymbols>
@@ -28,7 +28,7 @@
2828

2929
<ItemGroup>
3030
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
31-
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="6.*" />
31+
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="7.0.0" />
3232
</ItemGroup>
3333

3434
<ItemGroup>

Source/Extensions/Open.Database.Extensions.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageTags>ado;ado extensions;sql;connection factory;extensions;</PackageTags>
1515
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1616
<RepositoryType>git</RepositoryType>
17-
<Version>7.1.0</Version>
17+
<Version>7.2.0</Version>
1818
<PackageReleaseNotes></PackageReleaseNotes>
1919
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2020
<IncludeSymbols>true</IncludeSymbols>

Source/SqlClient/Open.Database.Extensions.SqlClient.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageTags>ado;ado extensions;sql;connection factory;extensions;</PackageTags>
1515
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1616
<RepositoryType>git</RepositoryType>
17-
<Version>7.1.0</Version>
17+
<Version>7.2.0</Version>
1818
<PackageReleaseNotes></PackageReleaseNotes>
1919
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2020
<IncludeSymbols>true</IncludeSymbols>
@@ -28,7 +28,7 @@
2828

2929
<ItemGroup>
3030
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
31-
<PackageReference Include="System.Data.SqlClient" Version="4.*" />
31+
<PackageReference Include="System.Data.SqlClient" Version="4.8.5" />
3232
</ItemGroup>
3333

3434
<ItemGroup>

Tests/Open.Database.Extensions.Core.Tests/Basic.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@ public void ExpressiveCommandValidation()
1717
return conn;
1818
});
1919

20-
2120
Assert.Throws<ArgumentNullException>(() => factory.Command(null));
2221
Assert.Throws<ArgumentException>(() => factory.Command(string.Empty));
2322
}
2423

2524
[System.Diagnostics.CodeAnalysis.SuppressMessage("CodeQuality", "IDE0051:Remove unused private members", Justification = "Compile test.")]
2625
static async Task AmbiguityValidation(IDbCommand command)
27-
{
28-
await command.Connection.EnsureOpenAsync();
29-
}
26+
=> await command.Connection.EnsureOpenAsync();
3027
}

Tests/Open.Database.Extensions.Core.Tests/Open.Database.Extensions.Core.Tests.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
11-
<PackageReference Include="NSubstitute" Version="4.3.0" />
12-
<PackageReference Include="xunit" Version="2.4.1" />
10+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
11+
<PackageReference Include="NSubstitute" Version="4.4.0" />
12+
<PackageReference Include="xunit" Version="2.4.2" />
1313
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
1414
<PrivateAssets>all</PrivateAssets>
1515
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1616
</PackageReference>
17-
<PackageReference Include="coverlet.collector" Version="3.1.2">
17+
<PackageReference Include="coverlet.collector" Version="3.2.0">
1818
<PrivateAssets>all</PrivateAssets>
1919
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2020
</PackageReference>

0 commit comments

Comments
 (0)